[phpwsbb] [ phpwsbb-Bugs-1209372 ] Missed a few &s

[SourceForge.net <no...@so...>]

Bugs item #1209372, was opened at 2005-05-26 20:54
Message generated for change (Tracker Item Submitted) made by Item Submitter
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=562402&aid=1209372&group_id=81260

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Submitted By: rck (rck000)
Assigned to: Nobody/Anonymous (nobody)
Summary: Missed a few &s

Initial Comment:
In Message.php:

    474                 // Got rid of the brackets so
that the link isn't broken in email messages
    475                 $message = str_replace('[url]',
'http://' . PHPWS_HOME_HTTP .
'index.php?module=phpwsbb&PHPWSBB_MAN_OP=view&PHPWS_MAN_ITEMS='
. $thread->getId(), $message);
 

and

    615             $from = '"' .
$_SESSION['translate']->it('Bulletin Board Admin') . '"
<'.$admin_email.'>';
    616             $subject =
$_SESSION['translate']->it('Reported BB Post:
"[var1]"', $this->getLabel());
    617             $message = str_replace('[url]',
'http://' . PHPWS_HOME_HTTP .
'index.php?module=phpwsbb&PHPWSBB_MAN_OP=view&PHPWS_MAN_ITEMS='
. $this->getId(), $message);



and


    618             $message =
$_SESSION['translate']->it('A bulletin board post
reported a bulletin board post for review.  Please
visit [var1] to view the post and take action.','     
  http://' . PHPWS_HOME_HTTP .
'index.php?module=phpwsbb&PHPWSBB_MAN_OP=view&PHPWS_MAN_ITEMS[]='
. $this->_tid . '#' . $_REQUEST['Message_id']);
    619             $message .= "\n\nReason:\n\n" .
$_REQUEST['Message_reason'];
 

 
...that doesn't validate. I changed it to

 474                 // Got rid of the brackets so that
the link isn't broken in email messages
    475                 $message = str_replace('[url]',
'http://' . PHPWS_HOME_HTTP .
'index.php?module=phpwsbb&amp;PHPWSBB_MAN_OP=view&amp;PHPWS_MAN_ITEMS='
. $thread->getId(), $me        ssage);


and


    616             $subject =
$_SESSION['translate']->it('Reported BB Post:
"[var1]"', $this->getLabel());
    617             $message = str_replace('[url]',
'http://' . PHPWS_HOME_HTTP .
'index.php?module=phpwsbb&amp;PHPWSBB_MAN_OP=view&amp;PHPWS_MAN_ITEMS='
. $this->getId(), $message)        ;
    618             $message =
$_SESSION['translate']->it('A bulletin board post
reported a bulletin board post for review.  Please
visit [var1] to view the post and take action.',' 


and


    618             $message =
$_SESSION['translate']->it('A bulletin board post
reported a bulletin board post for review.  Please
visit [var1] to view the post and take action.','     
  http://' . PHPWS_HOME_HTTP .
'index.php?module=phpwsbb&amp;PHPWSBB_MAN_OP=view&amp;PHPWS_MAN_ITEMS[]='
. $this->_tid . '#' . $_REQUEST['Message_id']);
    619             $message .= "\n\nReason:\n\n" .
$_REQUEST['Message_reason'];
 



...and now it does.

Also, in Threads.php:


    380             // Got rid of the brackets so that
the link isn't broken in email messages
    381             $message = str_replace('[url]',
'http://' . PHPWS_HOME_HTTP .
'index.php?module=phpwsbb&PHPWSBB_MAN_OP=view&PHPWS_MAN_ITEMS='
. $this->getId(), $message);
 

changed to


    380             // Got rid of the brackets so that
the link isn't broken in email messages
    381             $message = str_replace('[url]',
'http://' . PHPWS_HOME_HTTP .
'index.php?module=phpwsbb&amp;PHPWSBB_MAN_OP=view&amp;PHPWS_MAN_ITEMS='
. $this->getId(), $message)        ;
 

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=562402&aid=1209372&group_id=81260