#89 strict ftp server: fixing invalid buttons filenames

1.3.x
closed
Reini Urban
None
2
2012-10-11
2004-05-22
Anonymous
No

My server didn't like the names of the buttons with plus-
marks like (1+day.png) or parentheses ( (diff).png ). I
substituted underscores and uploaded them, but of course
couldn't change the names back, either. Where do I change
the code to access the images with the changed names, lib/
Theme.php, themes/MacOSX/themeinfo.php, or ...
somewhere else?

ron@ospgli.org

Discussion

  • Logged In: NO

    Thanks, but you can remove this one--solved it myself:

    1. Removed all spaces and underscores in the button image
      filenames and changed (diff).png to diffs.png.

    2. In themes/MacOSX/themeinfo.php, change lines 135-150 to:

    $Theme->addButtonAlias(("Lock Page"), "LockPage");
    $Theme->addButtonAlias(
    ("Unlock Page"), "UnlockPage");
    $Theme->addButtonAlias(("Page Locked"), "PageLocked");
    $Theme->addButtonAlias("...", "alltime");
    $Theme->addButtonAlias(
    ("View Source"), "ViewSource");
    $Theme->addButtonAlias(("Sign Out"), "SignOut");
    $Theme->addButtonAlias(
    ("(diff)"), "diffs");
    $Theme->addButtonAlias(("Edit Old Revision"),
    "EditOldRevision");
    $Theme->addButtonAlias(
    ("1 day"), "1day");
    $Theme->addButtonAlias(("2 days"), "2days");
    $Theme->addButtonAlias(
    ("3 days"), "3days");
    $Theme->addButtonAlias(("4 days"), "4days");
    $Theme->addButtonAlias(
    ("7 days"), "7days");
    $Theme->addButtonAlias(("30 days"), "30days");
    $Theme->addButtonAlias(
    ("90 days"), "90days");
    $Theme->addButtonAlias(_("Remove Page"), "RemovePage");

    You might consider changing the filenames and this code in the
    distribution; someone else might want to use the Mac theme on a
    non-Mac server.

    Ron Craig (ron@ospgli.org)

     
  • Logged In: NO

    Also, there is no PageDump.png image file.

    (Sorry, realized this after posting above and tinkering with it a bit
    more. Last post/comment!)

    I made one, but didn't get the font quite right....

    Ron (ron@ospgli.org)

     
  • Reini Urban
    Reini Urban
    2004-05-25

    Logged In: YES
    user_id=13755

    We use urldecode in Theme.php for the button basename.
    You could add a rule to replace "+" by "_"

    But I see that you fixed that yourself with adding special
    aliases.