phpwiki-talk

[Phpwiki-talk] Small Fix: base64 encoding for cookie variables.

[Konstantin Z. <kza...@ho...>]

Hello, All!

Without it I constantly get erros like "unserialize() failed".

File: Request.php
Line 454:
    @$val = unserialize(base64_decode($vars[$key]));

Line 476:
    $packedval = base64_encode(serialize($val));

File: WikiUserNew.php
Line 558:
    setcookie(WIKI_NAME, base64_encode(serialize(array('userid' =>
$prefs->get('userid')))),
        COOKIE_EXPIRATION_DAYS, COOKIE_DOMAIN);


With best regards, Konstantin Zadorozhny.
http://www.fidolook.org

[Phpwiki-talk] Re: Small Fix: base64 encoding for cookie variables.

[Konstantin Z. <kza...@ho...>]

Hello, Konstantin!
You wrote to All on Fri, 12 Mar 2004 10:17:55 -0800:

Also _AnonUser should be fixed this way.

Index: WikiUserNew.php
===================================================================
RCS file: /cvsroot/phpwiki/phpwiki/lib/WikiUserNew.php,v
retrieving revision 1.29
diff -r1.29 WikiUserNew.php
544a545
>         global $request;
558,559c559,560
<                 setcookie(WIKI_NAME, serialize(array('userid' =>
$prefs->get('userid'))),
<                           COOKIE_EXPIRATION_DAYS, COOKIE_DOMAIN);
---
>           $request->setCookieVar(WIKI_NAME,
>            serialize(array('userid' => $prefs->get('userid'))),
COOKIE_EXPIRATION_DAYS);
2127c2128
<  $pref->set($name,$newvalue);
---
>      $pref->set($name,$newvalue);


 KZ> Hello, All!

 KZ> Without it I constantly get erros like "unserialize() failed".

 KZ> File: Request.php
 KZ> Line 454:
 KZ>     @$val = unserialize(base64_decode($vars[$key]));

 KZ> Line 476:
 KZ>     $packedval = base64_encode(serialize($val));

 KZ> File: WikiUserNew.php
 KZ> Line 558:
 KZ>     setcookie(WIKI_NAME, base64_encode(serialize(array('userid' =>
 KZ> $prefs->get('userid')))),
 KZ>         COOKIE_EXPIRATION_DAYS, COOKIE_DOMAIN);

 KZ> With best regards, Konstantin Zadorozhny.
 KZ> http://www.fidolook.org

 KZ> -------------------------------------------------------
 KZ> This SF.Net email is sponsored by: IBM Linux Tutorials
 KZ> Free Linux tutorial presented by Daniel Robbins, President and CEO of
 KZ> GenToo technologies. Learn everything from fundamentals to system
 KZ> administration.http://ads.osdn.com/?ad_id=1470&alloc_id=3638&op=click

With best regards, Konstantin Zadorozhny.
http://www.fidolook.org

Re: [Phpwiki-talk] Re: Small Fix: base64 encoding for cookie variables.

[Reini U. <ru...@x-...>]

Excellent catch!
Thanks a lot. This problem only appears on non-windows boxes:
I can now easily reproduce it.

Konstantin Zadorozhny schrieb:
> Also _AnonUser should be fixed this way.
> Index: WikiUserNew.php
> ===================================================================
> RCS file: /cvsroot/phpwiki/phpwiki/lib/WikiUserNew.php,v
> retrieving revision 1.29
> diff -r1.29 WikiUserNew.php
> 544a545
> 
>>        global $request;
> 
> 558,559c559,560
> <                 setcookie(WIKI_NAME, serialize(array('userid' =>
> $prefs->get('userid'))),
> <                           COOKIE_EXPIRATION_DAYS, COOKIE_DOMAIN);
> ---
> 
>>          $request->setCookieVar(WIKI_NAME,
>>           serialize(array('userid' => $prefs->get('userid'))),
> 
> COOKIE_EXPIRATION_DAYS);
> 2127c2128
> <  $pref->set($name,$newvalue);
> ---
> 
>>     $pref->set($name,$newvalue);
> 
> 
> 
>  KZ> Hello, All!
> 
>  KZ> Without it I constantly get erros like "unserialize() failed".
> 
>  KZ> File: Request.php
>  KZ> Line 454:
>  KZ>     @$val = unserialize(base64_decode($vars[$key]));
> 
>  KZ> Line 476:
>  KZ>     $packedval = base64_encode(serialize($val));
> 
>  KZ> File: WikiUserNew.php
>  KZ> Line 558:
>  KZ>     setcookie(WIKI_NAME, base64_encode(serialize(array('userid' =>
>  KZ> $prefs->get('userid')))),
>  KZ>         COOKIE_EXPIRATION_DAYS, COOKIE_DOMAIN);

-- 
Reini Urban
http://xarch.tu-graz.ac.at/home/rurban/