From: Micki K. <mic...@co...> - 2004-02-24 18:02:40
|
Hi Reini. Unfortunately, after pulling down the latest build I'm still getting the bug. 'Fatal PhpWiki Error No uploaded file to upload? '. Although is it possible your committed code isn't available for updating locally yet? Thanks, Micki >Message: 12 >Date: Tue, 24 Feb 2004 18:27:27 +0100 >From: Reini Urban <ru...@x-...> >To: php...@li... >Subject: Re: [Phpwiki-talk] Re: Fatal Error restoring from .zip file > >Micki Kaufman schrieb: >> Using the latest dev code from CVS, checked out and installed well, but >> it won't recognize a .zip file under 'Restoring'. >> >> Using the same 'Upload File' method, I get a "'fatal PhpWiki Error' No >> uploaded file to upload?" message. >> >> Is this a known issue? Thanks so much, this build is looking GOOD! > >Micki, is it fixed now? > >I found some possible problems and made a workaround in is_upladed_file() >Works fine for me now. Also for my win32 \r\r\n problem. > >The only problem/feature is that conflicts are skipped and not overwritten. >-- >Reini Urban >http://xarch.tu-graz.ac.at/home/rurban/ > -- Micki mailto:mic...@co... |
From: Micki K. <mic...@co...> - 2004-02-24 19:32:55
|
>The only problem/feature is that conflicts are skipped and not overwritten. >-- >Reini Urban Hi Reini: The patch Carsten sent me should allow an 'upload and overwrite' function, which will retrieve and restore ALL page versions, not just the first. I'd consider the current behavior a bug, since it only loads the first version of the page, not the latest - if it only loaded the latest it would only be a 'functionality gap', in my opinion. I attached the patch below for your review. Rock on! Thanks, Micki PATCH >Admittedly the loadsave functions do need some more work. In the >mean time, here's a quick hack I whipped up to do exactly what you >need. > >Add this line to PhpWikiAdministration: <?plugin WikiForm action=upload buttontext="Upload & OVERWRITE" overwrite=1 ?> >Patch lib/plugin/WikiForm.php with the enclosed patch. > >It should go without saying, but here it is anyway: BE CAREFUL you >don't do something silly like upload the wrong file! :) > >Carsten Index: WikiForm.php =================================================================== RCS file: /cvsroot/phpwiki/phpwiki/lib/plugin/WikiForm.php,v retrieving revision 1.9 diff -U2 -r1.9 WikiForm.php --- WikiForm.php 26 Feb 2003 01:56:52 -0000 1.9 +++ WikiForm.php 7 Dec 2003 17:08:54 -0000 @@ -43,4 +43,5 @@ 'default' => false, 'buttontext' => false, + 'overwrite' => false, // HACK ALERT 'size' => 50); } @@ -107,4 +108,8 @@ $input = HTML::input($input); + if ($overwrite) + $input->pushContent(HTML::input(array('name' => 'overwrite', + 'value' => 1, + 'type' => 'hidden'))); $input->addTooltip($buttontext); $button = Button('submit:', $buttontext, $class); -- Micki mailto:mic...@co... |
From: Micki K. <mic...@co...> - 2004-02-25 00:44:25
|
Nope, no joy. I have the latest and on mac osx/php 4.3.2, and I'm still getting a fatal error on restoring. Thanks, Micki At 3:55 PM -0800 2/24/04, php...@li... wrote: >Message: 5 >Date: Tue, 24 Feb 2004 19:34:24 +0100 >From: Reini Urban <ru...@x-...> >To: php...@li... >Subject: Re: [Phpwiki-talk] Re: Fatal Error restoring from .zip file > >This is a multi-part message in MIME format. >--------------010202090902010904060908 >Content-Type: text/plain; charset=us-ascii; format=flowed >Content-Transfer-Encoding: 7bit > >Micki Kaufman schrieb: >> Unfortunately, after pulling down the latest build I'm still getting the >> bug. 'Fatal PhpWiki Error >> No uploaded file to upload? '. >> >> Although is it possible your committed code isn't available for updating >> locally yet? > >loadsave.php -r1.88 >Request.php -r1.38 >should have fixed it. > >attached is a patch from the versions above for these two. >-- >Reini Urban >http://xarch.tu-graz.ac.at/home/rurban/ > -- Micki mailto:mic...@co... |
From: Reini U. <ru...@x-...> - 2004-02-24 18:35:17
Attachments:
upload.patch
|
Micki Kaufman schrieb: > Unfortunately, after pulling down the latest build I'm still getting the > bug. 'Fatal PhpWiki Error > No uploaded file to upload? '. > > Although is it possible your committed code isn't available for updating > locally yet? loadsave.php -r1.88 Request.php -r1.38 should have fixed it. attached is a patch from the versions above for these two. -- Reini Urban http://xarch.tu-graz.ac.at/home/rurban/ |