phpwiki-talk

Re: [Phpwiki-talk] [patch] efficiency improvement

[Gary B. <ga...@in...>]

On Fri, 21 Sep 2001, Gary Benson wrote:

> > > Any of you guys who are running a PhpWiki-1.2.0 site may benefit from this
> > > patch, which should lower the load on your server. It removes an
> > > "efficiency" thing which meant that the MostPopular list was generated on
> > > every pageview.
> >
> > Hi Gary,
> >
> > Good catch!
> >
> > But... I think your patch makes the situation worse.
> >
> > > +      $tmpline = str_replace('%%Search%%', RenderQuickSearch(), $tmpline);
> > > +      $tmpline = str_replace('%%Fullsearch%%', RenderFullSearch(), $tmpline);
> > > +      $tmpline = str_replace('%%Mostpopular%%', RenderMostPopular(), $tmpline);
> >
> > I think this calls RenderMostPopular() once for every line in the
> > page...
> > I think the correct fix is something like:
> >
> >   if (strstr($tmpline, '%%Mostpopular%%'))
> >       $tmpline = str_replace('%%Mostpopular%%', RenderMostPopular(),
> > $tmpline);
> >
> > (Not that I've tested any of this or anything...)
>
> Doh!
>
> Expect a revised patch soonish...

Try these two instead...

Re: [Phpwiki-talk] [patch] efficiency improvement

[Steve W. <sw...@pa...>]

Gary, could you post these to
https://sourceforge.net/tracker/?group_id=6121&atid=306121

That way they are more accessible... patches sometimes get truncated in
the mail archive.

thx!
~swain

On Fri, 21 Sep 2001, Gary Benson wrote:

>
> On Fri, 21 Sep 2001, Gary Benson wrote:
>
> > > > Any of you guys who are running a PhpWiki-1.2.0 site may benefit from this
> > > > patch, which should lower the load on your server. It removes an
> > > > "efficiency" thing which meant that the MostPopular list was generated on
> > > > every pageview.
> > >
> > > Hi Gary,
> > >
> > > Good catch!
> > >
> > > But... I think your patch makes the situation worse.
> > >
> > > > +      $tmpline = str_replace('%%Search%%', RenderQuickSearch(), $tmpline);
> > > > +      $tmpline = str_replace('%%Fullsearch%%', RenderFullSearch(), $tmpline);
> > > > +      $tmpline = str_replace('%%Mostpopular%%', RenderMostPopular(), $tmpline);
> > >
> > > I think this calls RenderMostPopular() once for every line in the
> > > page...
> > > I think the correct fix is something like:
> > >
> > >   if (strstr($tmpline, '%%Mostpopular%%'))
> > >       $tmpline = str_replace('%%Mostpopular%%', RenderMostPopular(),
> > > $tmpline);
> > >
> > > (Not that I've tested any of this or anything...)
> >
> > Doh!
> >
> > Expect a revised patch soonish...
>
> Try these two instead...
>

---
                  http://www.panix.com/~swain/
"Without music to decorate it, time is just a bunch of boring
production deadlines or dates by which bills must be paid."
                     -- Frank Zappa
http://pgp.document_type.org:11371/pks/lookup?op=get&search=0xF7323BAC

Re: [Phpwiki-talk] [patch] efficiency improvement

[Gary B. <ga...@in...>]

On Fri, 21 Sep 2001, Steve Wainstead wrote:

> Gary, could you post these to
> https://sourceforge.net/tracker/?group_id=6121&atid=306121
>
> That way they are more accessible... patches sometimes get truncated in
> the mail archive.

Jeff committed them; do you still want them posting?

Re: [Phpwiki-talk] [patch] efficiency improvement

[Steve W. <sw...@pa...>]

Sure, it would be a convenience to users of 1.2.0.

~swain

On Fri, 21 Sep 2001, Gary Benson wrote:

>
> On Fri, 21 Sep 2001, Steve Wainstead wrote:
>
> > Gary, could you post these to
> > https://sourceforge.net/tracker/?group_id=6121&atid=306121
> >
> > That way they are more accessible... patches sometimes get truncated in
> > the mail archive.
>
> Jeff committed them; do you still want them posting?
>
>
> _______________________________________________
> Phpwiki-talk mailing list
> Php...@li...
> https://lists.sourceforge.net/lists/listinfo/phpwiki-talk
>

---
                  http://www.panix.com/~swain/
"Without music to decorate it, time is just a bunch of boring
production deadlines or dates by which bills must be paid."
                     -- Frank Zappa
http://pgp.document_type.org:11371/pks/lookup?op=get&search=0xF7323BAC

Re: [Phpwiki-talk] [patch] efficiency improvement

[Gary B. <ga...@in...>]

I just merged my PersonalWiki up to the head of the 1.2 branch. There's
quite a few changes; do you think it would be worth tagging and rolling a
1.2.1 release?

Gary

On Fri, 21 Sep 2001, Steve Wainstead wrote:

> Sure, it would be a convenience to users of 1.2.0.
>
> ~swain
>
> On Fri, 21 Sep 2001, Gary Benson wrote:
>
> >
> > On Fri, 21 Sep 2001, Steve Wainstead wrote:
> >
> > > Gary, could you post these to
> > > https://sourceforge.net/tracker/?group_id=6121&atid=306121
> > >
> > > That way they are more accessible... patches sometimes get truncated in
> > > the mail archive.
> >
> > Jeff committed them; do you still want them posting?
> >
> >
> > _______________________________________________
> > Phpwiki-talk mailing list
> > Php...@li...
> > https://lists.sourceforge.net/lists/listinfo/phpwiki-talk
> >
>
> ---
>                   http://www.panix.com/~swain/
> "Without music to decorate it, time is just a bunch of boring
> production deadlines or dates by which bills must be paid."
>                      -- Frank Zappa
> http://pgp.document_type.org:11371/pks/lookup?op=get&search=0xF7323BAC
>

[ ga...@in... ][ GnuPG 85A8F78B ][ http://inauspicious.org/ ]

Re: [Phpwiki-talk] [patch] efficiency improvement

[Steve W. <sw...@pa...>]

Yes, I've been meaning to for a few weeks. I'm updating my copy of the 1.2
branch right now...

~swain

On Fri, 21 Sep 2001, Gary Benson wrote:

>
> I just merged my PersonalWiki up to the head of the 1.2 branch. There's
> quite a few changes; do you think it would be worth tagging and rolling a
> 1.2.1 release?
>
> Gary
>
> On Fri, 21 Sep 2001, Steve Wainstead wrote:
>
> > Sure, it would be a convenience to users of 1.2.0.
> >
> > ~swain
> >
> > On Fri, 21 Sep 2001, Gary Benson wrote:
> >
> > >
> > > On Fri, 21 Sep 2001, Steve Wainstead wrote:
> > >
> > > > Gary, could you post these to
> > > > https://sourceforge.net/tracker/?group_id=6121&atid=306121
> > > >
> > > > That way they are more accessible... patches sometimes get truncated in
> > > > the mail archive.
> > >
> > > Jeff committed them; do you still want them posting?
> > >
> > >
> > > _______________________________________________
> > > Phpwiki-talk mailing list
> > > Php...@li...
> > > https://lists.sourceforge.net/lists/listinfo/phpwiki-talk
> > >
> >
> > ---
> >                   http://www.panix.com/~swain/
> > "Without music to decorate it, time is just a bunch of boring
> > production deadlines or dates by which bills must be paid."
> >                      -- Frank Zappa
> > http://pgp.document_type.org:11371/pks/lookup?op=get&search=0xF7323BAC
> >
>
> [ ga...@in... ][ GnuPG 85A8F78B ][ http://inauspicious.org/ ]
>
>
> _______________________________________________
> Phpwiki-talk mailing list
> Php...@li...
> https://lists.sourceforge.net/lists/listinfo/phpwiki-talk
>

---
                  http://www.panix.com/~swain/
"Without music to decorate it, time is just a bunch of boring
production deadlines or dates by which bills must be paid."
                     -- Frank Zappa
http://pgp.document_type.org:11371/pks/lookup?op=get&search=0xF7323BAC

Re: [Phpwiki-talk] [patch] efficiency improvement

[Gary B. <ga...@in...>]

Cool. I've got a couple of wikis lying around that need updating; it'll
save me a load of messing about.

Cheers,
Gary

On Fri, 21 Sep 2001, Steve Wainstead wrote:

> Yes, I've been meaning to for a few weeks. I'm updating my copy of the 1.2
> branch right now...
>
> ~swain
>
> On Fri, 21 Sep 2001, Gary Benson wrote:
>
> >
> > I just merged my PersonalWiki up to the head of the 1.2 branch. There's
> > quite a few changes; do you think it would be worth tagging and rolling a
> > 1.2.1 release?
> >
> > Gary
> >
> > On Fri, 21 Sep 2001, Steve Wainstead wrote:
> >
> > > Sure, it would be a convenience to users of 1.2.0.
> > >
> > > ~swain
> > >
> > > On Fri, 21 Sep 2001, Gary Benson wrote:
> > >
> > > >
> > > > On Fri, 21 Sep 2001, Steve Wainstead wrote:
> > > >
> > > > > Gary, could you post these to
> > > > > https://sourceforge.net/tracker/?group_id=6121&atid=306121
> > > > >
> > > > > That way they are more accessible... patches sometimes get truncated in
> > > > > the mail archive.
> > > >
> > > > Jeff committed them; do you still want them posting?
> > > >
> > > >
> > > > _______________________________________________
> > > > Phpwiki-talk mailing list
> > > > Php...@li...
> > > > https://lists.sourceforge.net/lists/listinfo/phpwiki-talk
> > > >
> > >
> > > ---
> > >                   http://www.panix.com/~swain/
> > > "Without music to decorate it, time is just a bunch of boring
> > > production deadlines or dates by which bills must be paid."
> > >                      -- Frank Zappa
> > > http://pgp.document_type.org:11371/pks/lookup?op=get&search=0xF7323BAC
> > >
> >
> > [ ga...@in... ][ GnuPG 85A8F78B ][ http://inauspicious.org/ ]
> >
> >
> > _______________________________________________
> > Phpwiki-talk mailing list
> > Php...@li...
> > https://lists.sourceforge.net/lists/listinfo/phpwiki-talk
> >
>
> ---
>                   http://www.panix.com/~swain/
> "Without music to decorate it, time is just a bunch of boring
> production deadlines or dates by which bills must be paid."
>                      -- Frank Zappa
> http://pgp.document_type.org:11371/pks/lookup?op=get&search=0xF7323BAC
>

[ ga...@in... ][ GnuPG 85A8F78B ][ http://inauspicious.org/ ]