Menu
▾
▴
phpwiki-talk
|
From: Steve W. <sw...@wc...> - 2000-06-21 18:33:07
|
... I'd like to add is the ability to link ISBN numbers. I think the regexp for this might be on c2.com; I was browsing there today looking for something and saw mention of a page with regular expressions for common Wiki patterns. This is not high priority obviously but I think it's a Good Thing. sw ...............................ooo0000ooo................................. Hear FM quality freeform radio through the Internet: http://wcsb.org/ home page: www.wcsb.org/~swain |
|
From: Arno H. <aho...@in...> - 2000-06-21 19:50:34
|
Hi Steve, > ... I'd like to add is the ability to link ISBN numbers. I think the > regexp for this might be on c2.com; I was browsing there today looking for > something and saw mention of a page with regular expressions for common > Wiki patterns. Where would ISBN numbers link to? Or are they just pagenames as well? > I am thinking next of compiling Apache/PHP4/mSQL and writing a > wiki_msql.php3 for that (maybe it's time to rename all the files to just > wiki_something.php). I guess we can postpone this renaming until 1.2 (ok, I'm a lazy bastard who doesn't want to change his apache config just yet) Btw, I've just renamed pageviewer.php3 as wiki_pageinfo.php3. It now is called from index.php3 and uses template 'MESSAGE'. See [more info] link at the bottom of each page :o) I'm going to have a look at mySQL now. /Arno |
|
From: Steve W. <sw...@wc...> - 2000-06-21 20:31:13
|
On Wed, 21 Jun 2000, Arno Hollosi wrote: > Where would ISBN numbers link to? > Or are they just pagenames as well? Well, that is a configuration issue for the WikiMaster. At c2.com they are configured to link to Amazon because they have some kind of association thing going (I forget what those programs are called... if you buy a book from Amazon by following the link from c2.com, c2.com gets money). We'd just have to add a variable to wiki_config.php3 like $BookSeller and that would be the URL of the company you partner with. (It can be fatbrain.com if you have issues with Amazon :-) > I guess we can postpone this renaming until 1.2 > (ok, I'm a lazy bastard who doesn't want to change his apache config > just yet) No rush, no. But eventually. Someday all PHP installations will be >=4 and we don't want to look out of date :-) > Btw, I've just renamed pageviewer.php3 as wiki_pageinfo.php3. > It now is called from index.php3 and uses template 'MESSAGE'. > See [more info] link at the bottom of each page :o) I just caught that in the cvsweb page. Excellent. I like the idea of the info link. > I'm going to have a look at mySQL now. I was thinking ... there are at least two opportunities in wiki_pgsql.php3 to write little functions that prepare the data. This might be better than copy/paste. For example, before an INSERT or UPDATE statement is composed, some fields need AddSlashes() and some need serialize(), some need to be 'quoted' and some don't (columns that are integers). This could be moved into a function in wiki_stdlib.php3 (for example) and could be shared by the different databases; alternately they could be written into functions and left in wiki_pgsql.php3, and the functions could be copy/pasted by someone porting to mSQL. (I think I might prefer that solution). Let me know what you think. sw ...............................ooo0000ooo................................. Hear FM quality freeform radio through the Internet: http://wcsb.org/ home page: www.wcsb.org/~swain |
|
From: Arno H. <aho...@in...> - 2000-06-21 23:16:23
|
Steve, I just checked in my latest changes. I implemented the new data structure as described in DBLIB.txt throughout wiki. I replaced several $pagehash["date"] with "lastmodified" and changed its handling from string to time()-stamp. (this includes that there are now two config variables for the dateformat) Also, $pagehash["refs"] is now an array. I've updated wiki_mysql.php3 to the new schema too. I've tested my changes with mySQL and everything seems to work fine. [Actually I just discovered that FullSearch is broken - going to hunt that bug now] If you start from scratch, then the version should work with pgsql & dbm as well. Let me know, if there are any problems. On a side note: I added "__" bold markup, but didn't dare to remove "'''". Your turn. > I was thinking ... there are at least two opportunities in wiki_pgsql.php3 > to write little functions that prepare the data. I've written two such functions for wiki_mysql.php3 They are called MakeDBHash() and MakePageHash(). If you like you can move them to wiki_stdlib.php3 /Arno |
|
From: Steve W. <sw...@wc...> - 2000-06-22 05:03:33
|
On Thu, 22 Jun 2000, Arno Hollosi wrote:
> I implemented the new data structure as described in DBLIB.txt
> throughout wiki. I replaced several $pagehash["date"] with
> "lastmodified" and changed its handling from string to time()-stamp.
> (this includes that there are now two config variables for the dateformat)
> Also, $pagehash["refs"] is now an array. I've updated
> wiki_mysql.php3 to the new schema too.
Hmm... I coded against the original files, and was able to get everything
to work except searches; and I wound up putting in a weird hack to account
for the data structure... something like:
$ref["page"]["content"] = explode("\n", $o->content);
for fullsearch, which is probably all I'll have to revisit...
> If you start from scratch, then the version should work with pgsql & dbm
> as well. Let me know, if there are any problems.
>
> On a side note: I added "__" bold markup, but didn't dare to remove "'''".
> Your turn.
Hmm. Too late to discuss markup changes... I was drinking sake late into
the night :-)
> I've written two such functions for wiki_mysql.php3
> They are called MakeDBHash() and MakePageHash().
> If you like you can move them to wiki_stdlib.php3
Excellent. I'll check them out.
Just doing "cvs update," I found everything worked except fullsearch with
pgsql and DBM both, so my hunch is probably right and it will take only a
small amount of work here to fix.
sw
...............................ooo0000ooo.................................
Hear FM quality freeform radio through the Internet: http://wcsb.org/
home page: www.wcsb.org/~swain
|
Thanks for helping keep SourceForge clean.
X