From: Sabri L. <sab...@st...> - 2007-01-19 14:02:01
|
Hi all, Suppose that we have two wiki pages already created page1 and page2 and = that page1 contain a link to page2. If we delete page2 (using /Remove = admin action), The link to it in page1 become disabled with the question = mark at the end. If we want to access page2 directly, the page is = displayed ! It was not really removed.=20 Now back to page1, if I use the question mark to create the page, I have = this warning after saving it. lib/ArchiveCleaner.php:109: Notice: Warning: Page 'NewPage', version '1' = has no '_supplanted' timestamp (...repeated 2 times) It seems that it's a bug in phpwiki since removed pages should not be = displayed when we directly request them. What do you think ? Cheers, Sabri. |
From: Stefan <son...@ba...> - 2007-01-19 14:21:30
|
hello sabri, it works as designed. thats no bug but it's useless i think. the pages are only marked as deleted but shown as i think from the cached version table. when you edit a deleted page it is empty. i agree with you that deleted pages should'nt be shown anymore. The Problem with '_supplanted' timestamp' .... is nearly as old as phpwiki. nobody tried to fix it until today. for us we have disabled all the warnings. 2 years ago i asked about a tool to fix this errors but it seems to have priority 0 to fix it. i tried to fix it by my own but i did'nt understand how it really works. Stefan Sabri LABBENE schrieb: > Hi all, > > Suppose that we have two wiki pages already created page1 and page2 and that page1 contain a link to page2. If we delete page2 (using /Remove admin action), The link to it in page1 become disabled with the question mark at the end. If we want to access page2 directly, the page is displayed ! It was not really removed. > > Now back to page1, if I use the question mark to create the page, I have this warning after saving it. > > lib/ArchiveCleaner.php:109: Notice: Warning: Page 'NewPage', version '1' has no '_supplanted' timestamp (...repeated 2 times) > > It seems that it's a bug in phpwiki since removed pages should not be displayed when we directly request them. > > What do you think ? > > Cheers, > Sabri. > > > > ------------------------------------------------------------------------- > Take Surveys. Earn Cash. Influence the Future of IT > Join SourceForge.net's Techsay panel and you'll get the chance to share your > opinions on IT & business topics through brief surveys - and earn cash > http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV > _______________________________________________ > Phpwiki-talk mailing list > Php...@li... > https://lists.sourceforge.net/lists/listinfo/phpwiki-talk > > > |
From: Sabri L. <sab...@st...> - 2007-01-19 15:04:49
|
Stefan wrote >hello sabri, > >it works as designed. thats no bug but it's useless i think. >the pages are only marked as deleted but shown as i think from >the cached version table. when you edit a deleted page it is >empty. i agree with you that deleted pages should'nt be shown anymore. So, I think we should also delete them from the cached version table. Don't you? Then any request for a deleted page will show up a "Sorry, this page is not in the database." message for example. >The Problem with '_supplanted' timestamp' .... is nearly as >old as phpwiki. nobody tried to fix it until today. for us we >have disabled all the warnings. 2 years ago i asked about a >tool to fix this errors but it seems to have priority 0 to fix >it. i tried to fix it by my own but i did'nt understand how it >really works. > >Stefan > >Sabri LABBENE schrieb: >> Hi all, >> >> Suppose that we have two wiki pages already created page1 >and page2 and that page1 contain a link to page2. If we delete >page2 (using /Remove admin action), The link to it in page1 >become disabled with the question mark at the end. If we want >to access page2 directly, the page is displayed ! It was not >really removed. >> >> Now back to page1, if I use the question mark to create the >page, I have this warning after saving it. >> >> lib/ArchiveCleaner.php:109: Notice: Warning: Page 'NewPage', version >> '1' has no '_supplanted' timestamp (...repeated 2 times) >> >> It seems that it's a bug in phpwiki since removed pages >should not be displayed when we directly request them. >> >> What do you think ? >> >> Cheers, >> Sabri. >> >> >> >> >---------------------------------------------------------------------- >> --- Take Surveys. Earn Cash. Influence the Future of IT Join >> SourceForge.net's Techsay panel and you'll get the chance to share >> your opinions on IT & business topics through brief surveys >- and earn >> cash >> >http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEV >> DEV _______________________________________________ >> Phpwiki-talk mailing list >> Php...@li... >> https://lists.sourceforge.net/lists/listinfo/phpwiki-talk >> >> >> > > >--------------------------------------------------------------- >---------- >Take Surveys. Earn Cash. Influence the Future of IT Join >SourceForge.net's Techsay panel and you'll get the chance to >share your opinions on IT & business topics through brief >surveys - and earn cash >http://www.techsay.com/default.php?page=join.php&p=sourceforge& CID=DEVDEV >_______________________________________________ >Phpwiki-talk mailing list >Php...@li... >https://lists.sourceforge.net/lists/listinfo/phpwiki-talk > |
From: Manuel V. <man...@gm...> - 2007-01-19 16:34:50
|
2007/1/19, Stefan <son...@ba...>: > hello sabri, > > it works as designed. thats no bug but it's useless i think. the pages > are only marked as deleted but shown as i think from the cached version > table. when you edit a deleted page it is empty. i agree with you that > deleted pages should'nt be shown anymore. Hell Stefan, With phpwiki 1.3.10 I don't see this problem: After page2 deletion, when I access directly page2, I have the empty page with 'Describe page2 here'. Here we still access to page2 with full history and so on. -- Manuel |
From: Reini U. <ru...@x-...> - 2007-01-19 17:35:43
|
2007/1/19, Manuel Vacelet <man...@gm...>: > 2007/1/19, Stefan <son...@ba...>: > > hello sabri, > > > > it works as designed. thats no bug but it's useless i think. the pages > > are only marked as deleted but shown as i think from the cached version > > table. when you edit a deleted page it is empty. i agree with you that > > deleted pages should'nt be shown anymore. > > Hell Stefan, > > With phpwiki 1.3.10 I don't see this problem: > > After page2 deletion, when I access directly page2, I have the empty > page with 'Describe page2 here'. > > Here we still access to page2 with full history and so on. I changed (optimized) the db Cache after 1.3.11 and forgot to add the purge_cache for the remove action. rename also has a similar problem. sorry. the browser cache has also to be invalidated. with NO_CACHE this will not be triggered and your browser will fool you. |
From: Stefan <son...@ba...> - 2007-01-20 11:01:04
|
Hello Manuel, how do you access the page? If you access it with the link in recent changes (?) you are right. If you access the page with the url of the deleted page put it direct in the browser url field you will see the deleted page again. The Problem is that google etc. will send you users to the deleted page and they think it is the real one. -- Stefan Manuel Vacelet wrote: > 2007/1/19, Stefan <son...@ba...>: > >> hello sabri, >> >> it works as designed. thats no bug but it's useless i think. the pages >> are only marked as deleted but shown as i think from the cached version >> table. when you edit a deleted page it is empty. i agree with you that >> deleted pages should'nt be shown anymore. >> > > Hell Stefan, > > With phpwiki 1.3.10 I don't see this problem: > > After page2 deletion, when I access directly page2, I have the empty > page with 'Describe page2 here'. > > Here we still access to page2 with full history and so on. > > -- Manuel > > ------------------------------------------------------------------------- > Take Surveys. Earn Cash. Influence the Future of IT > Join SourceForge.net's Techsay panel and you'll get the chance to share your > opinions on IT & business topics through brief surveys - and earn cash > http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV > _______________________________________________ > Phpwiki-talk mailing list > Php...@li... > https://lists.sourceforge.net/lists/listinfo/phpwiki-talk > > > |
From: Manuel V. <man...@gm...> - 2007-01-22 12:58:47
|
2007/1/20, Stefan <son...@ba...>: > Hello Manuel, > > how do you access the page? If you access it with the link in recent > changes (?) you are right. > If you access the page with the url of the deleted page put it direct in > the browser url field you will see the deleted page again. Unfortunatly I think it's not a cache issue (at least neither proxy nor browser cache) because I tried to load page2 from a different browser on a different machine. Moreover, I already set cache settings to NO_CACHE :/ -- Manuel |
From: Reini U. <ru...@x-...> - 2007-01-23 08:37:59
|
Manuel Vacelet schrieb: > 2007/1/20, Stefan <son...@ba...>: >> Hello Manuel, >> >> how do you access the page? If you access it with the link in recent >> changes (?) you are right. >> If you access the page with the url of the deleted page put it direct in >> the browser url field you will see the deleted page again. > > Unfortunatly I think it's not a cache issue (at least neither proxy > nor browser cache) because I tried to load page2 from a different > browser on a different machine. > > Moreover, I already set cache settings to NO_CACHE :/ No, I meant our internal pagedb ache, not the browsers cache. I will check it today. -- Reini Urban http://phpwiki.org/ http://murbreak.at/ http://helsinki.at/ http://spacemovie.mur.at/ |
From: Manuel V. <man...@gm...> - 2007-01-26 14:53:28
|
2007/1/23, Reini Urban <ru...@x-...>: > Manuel Vacelet schrieb: > > 2007/1/20, Stefan <son...@ba...>: > >> Hello Manuel, > >> > >> how do you access the page? If you access it with the link in recent > >> changes (?) you are right. > >> If you access the page with the url of the deleted page put it direct in > >> the browser url field you will see the deleted page again. > > > > Unfortunatly I think it's not a cache issue (at least neither proxy > > nor browser cache) because I tried to load page2 from a different > > browser on a different machine. > > > > Moreover, I already set cache settings to NO_CACHE :/ > > No, I meant our internal pagedb ache, not the browsers cache. I found a solution. In getPackedContent method, I added a test to verify if the requested page is not deleted: ----------------------->8----------------------- if (empty($data['%content']) || (!$this->_wikidb->isWikiPage($this->_pagename) && $this->isCurrent())) { ----------------------->8----------------------- The remove a page will lead to following use case. On page deletion: - Page history add a mark about deletion. - Links in other pages show the page as not existing. - Direct access to the page give the same behaviour (Describe %s here). - Page history show the previous states of the page. - Access to an old revision of the page output the content of this old version. Is my fix right ? |
From: Stefan <son...@ba...> - 2007-01-26 18:35:58
|
Hello Manuel, i have inserted the patch here but the result for me is the same as before (1.3.13 RC2) Entering a delteted page with the deleted page link in "recend changes" there is a message to create the page. open the page with the full linkname in browser url field (widthout action=create) the page is shown as before i deleted it. i will make the code tests to see when it stops. Stefan Manuel Vacelet wrote: > 2007/1/23, Reini Urban <ru...@x-...>: > >> Manuel Vacelet schrieb: >> >>> 2007/1/20, Stefan <son...@ba...>: >>> >>>> Hello Manuel, >>>> >>>> how do you access the page? If you access it with the link in recent >>>> changes (?) you are right. >>>> If you access the page with the url of the deleted page put it direct in >>>> the browser url field you will see the deleted page again. >>>> >>> Unfortunatly I think it's not a cache issue (at least neither proxy >>> nor browser cache) because I tried to load page2 from a different >>> browser on a different machine. >>> >>> Moreover, I already set cache settings to NO_CACHE :/ >>> >> No, I meant our internal pagedb ache, not the browsers cache. >> > > I found a solution. > > In getPackedContent method, I added a test to verify if the requested > page is not deleted: > ----------------------->8----------------------- > if (empty($data['%content']) > || (!$this->_wikidb->isWikiPage($this->_pagename) > && $this->isCurrent())) { > ----------------------->8----------------------- > > The remove a page will lead to following use case. > On page deletion: > - Page history add a mark about deletion. > - Links in other pages show the page as not existing. > - Direct access to the page give the same behaviour (Describe %s here). > - Page history show the previous states of the page. > - Access to an old revision of the page output the content of this old version. > > Is my fix right ? > > ------------------------------------------------------------------------- > Take Surveys. Earn Cash. Influence the Future of IT > Join SourceForge.net's Techsay panel and you'll get the chance to share your > opinions on IT & business topics through brief surveys - and earn cash > http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV > _______________________________________________ > Phpwiki-talk mailing list > Php...@li... > https://lists.sourceforge.net/lists/listinfo/phpwiki-talk > > > |
From: Manuel V. <man...@gm...> - 2007-01-26 19:16:57
|
2007/1/26, Stefan <son...@ba...>: > Hello Manuel, > > i have inserted the patch here but the result for me is the same as > before (1.3.13 RC2) > Entering a delteted page with the deleted page link in "recend changes" > there is a message to create the page. open the page with the full > linkname in browser url field (widthout action=create) the page is shown > as before i deleted it. i will make the code tests to see when it stops. Hello Stephan, I made the patch on a customized version of phpwiki 1.3.12p3 (on this part, our customization shouldn't impact much). I remember I had to switch off HTML cache (USECACHE = false) during my test but I can't figure if I re-enabled it after. I will try to apply the patch on the latest RC this week-end. -- Manuel |
From: Manuel V. <man...@gm...> - 2007-01-29 09:32:09
|
2007/1/26, Manuel Vacelet <man...@gm...>: > 2007/1/26, Stefan <son...@ba...>: > > Hello Manuel, > > > > i have inserted the patch here but the result for me is the same as > > before (1.3.13 RC2) > > Entering a delteted page with the deleted page link in "recend changes" > > there is a message to create the page. open the page with the full > > linkname in browser url field (widthout action=create) the page is shown > > as before i deleted it. i will make the code tests to see when it stops. > > Hello Stephan, > > I made the patch on a customized version of phpwiki 1.3.12p3 (on this > part, our customization shouldn't impact much). > > I remember I had to switch off HTML cache (USECACHE = false) during my > test but I can't figure if I re-enabled it after. I didn't have time to test with the latest RC but I confirm I had to switch cache off and it didn't work with cache enabled. I think the good option it to reset html cache on page deletion. What do you think ? BTW, can you make the test with USECACHE = false ? -- Manuel |
From: Reini U. <ru...@x-...> - 2007-02-01 07:35:38
|
Manuel Vacelet schrieb: > 2007/1/23, Reini Urban <ru...@x-...>: >> Manuel Vacelet schrieb: >>> 2007/1/20, Stefan <son...@ba...>: >>>> Hello Manuel, >>>> >>>> how do you access the page? If you access it with the link in recent >>>> changes (?) you are right. >>>> If you access the page with the url of the deleted page put it direct in >>>> the browser url field you will see the deleted page again. >>> Unfortunatly I think it's not a cache issue (at least neither proxy >>> nor browser cache) because I tried to load page2 from a different >>> browser on a different machine. >>> >>> Moreover, I already set cache settings to NO_CACHE :/ >> No, I meant our internal pagedb ache, not the browsers cache. > > I found a solution. > > In getPackedContent method, I added a test to verify if the requested > page is not deleted: > ----------------------->8----------------------- > if (empty($data['%content']) > || (!$this->_wikidb->isWikiPage($this->_pagename) > && $this->isCurrent())) { > ----------------------->8----------------------- > > The remove a page will lead to following use case. > On page deletion: > - Page history add a mark about deletion. > - Links in other pages show the page as not existing. > - Direct access to the page give the same behaviour (Describe %s here). > - Page history show the previous states of the page. > - Access to an old revision of the page output the content of this old version. > > Is my fix right ? I don't think so. AddComment has the same weirdness displaying after adding a comment in mode=show not displaying the just created comment. I believe this has the same roots. On the good side, I believe that this is the only blocking issue so far for the new release, only someone else convinces me to fix something else also. -- Reini Urban http://phpwiki.org/ http://murbreak.at/ http://helsinki.at/ http://spacemovie.mur.at/ |
From: Sabri L. <sab...@st...> - 2007-02-01 09:46:54
|
Reini Urban wrote: >Manuel Vacelet schrieb: >> 2007/1/23, Reini Urban <ru...@x-...>: >>> Manuel Vacelet schrieb: >>>> 2007/1/20, Stefan <son...@ba...>: >>>>> Hello Manuel, >>>>> >>>>> how do you access the page? If you access it with the link in >>>>> recent changes (?) you are right. >>>>> If you access the page with the url of the deleted page put it >>>>> direct in the browser url field you will see the deleted >page again. >>>> Unfortunatly I think it's not a cache issue (at least >neither proxy >>>> nor browser cache) because I tried to load page2 from a different >>>> browser on a different machine. >>>> >>>> Moreover, I already set cache settings to NO_CACHE :/ >>> No, I meant our internal pagedb ache, not the browsers cache. >> >> I found a solution. >> >> In getPackedContent method, I added a test to verify if the >requested >> page is not deleted: >> ----------------------->8----------------------- >> if (empty($data['%content']) >> || (!$this->_wikidb->isWikiPage($this->_pagename) >> && $this->isCurrent())) { >> ----------------------->8----------------------- >> >> The remove a page will lead to following use case. >> On page deletion: >> - Page history add a mark about deletion. >> - Links in other pages show the page as not existing. >> - Direct access to the page give the same behaviour >(Describe %s here). >> - Page history show the previous states of the page. >> - Access to an old revision of the page output the content >of this old version. >> >> Is my fix right ? > >I don't think so. >AddComment has the same weirdness displaying after adding a >comment in mode=show not displaying the just created comment. >I believe this has the same roots. > >On the good side, I believe that this is the only blocking >issue so far for the new release, only someone else convinces >me to fix something else also. I installed the latest release (rc1) and there is no wysiwyg editor. Is there a pending problem with it? Do you plan to include it in the next release? Regards, -- Sabri. |
From: Reini U. <ru...@x-...> - 2007-02-01 18:11:54
|
2007/2/1, Sabri LABBENE <sab...@st...>: > Reini Urban wrote: > >Manuel Vacelet schrieb: > >> 2007/1/23, Reini Urban <ru...@x-...>: > >>> Manuel Vacelet schrieb: > >>>> 2007/1/20, Stefan <son...@ba...>: > >>>>> Hello Manuel, > >>>>> > >>>>> how do you access the page? If you access it with the link in > >>>>> recent changes (?) you are right. > >>>>> If you access the page with the url of the deleted page put it > >>>>> direct in the browser url field you will see the deleted > >page again. > >>>> Unfortunatly I think it's not a cache issue (at least > >neither proxy > >>>> nor browser cache) because I tried to load page2 from a different > >>>> browser on a different machine. > >>>> > >>>> Moreover, I already set cache settings to NO_CACHE :/ > >>> No, I meant our internal pagedb ache, not the browsers cache. > >> > >> I found a solution. > >> > >> In getPackedContent method, I added a test to verify if the > >requested > >> page is not deleted: > >> ----------------------->8----------------------- > >> if (empty($data['%content']) > >> || (!$this->_wikidb->isWikiPage($this->_pagename) > >> && $this->isCurrent())) { > >> ----------------------->8----------------------- > >> > >> The remove a page will lead to following use case. > >> On page deletion: > >> - Page history add a mark about deletion. > >> - Links in other pages show the page as not existing. > >> - Direct access to the page give the same behaviour > >(Describe %s here). > >> - Page history show the previous states of the page. > >> - Access to an old revision of the page output the content > >of this old version. > >> > >> Is my fix right ? > > > >I don't think so. > >AddComment has the same weirdness displaying after adding a > >comment in mode=show not displaying the just created comment. > >I believe this has the same roots. > > > >On the good side, I believe that this is the only blocking > >issue so far for the new release, only someone else convinces > >me to fix something else also. > > I installed the latest release (rc1) and there is no wysiwyg editor. > Is there a pending problem with it? > Do you plan to include it in the next release? It is included, but not enabled as default, because of the pending plugin args problems. config.ini: ENABLE_WYSIWYG = true -- Reini Urban http://phpwiki.org/ http://murbreak.at/ http://spacemovie.mur.at/ http://helsinki.at/ |
From: Thomas H. <tom...@gm...> - 2007-01-29 18:19:22
|
Some time back I asked for help regarding [Links with spaces] in phpwiki. phpwiki was going along just fine handling [Links with spaces]. Then, apparently without any upgrades or action on my part (yes, I know somthing must have changed), [Links with spaces] stopped working. The reason I am bringing this up again is to see if you could please visit my page and try adding * [Test page] to the bottom and seeing what happens when you try to create and follow the page/link. http://www.hawsedc.com/thomas Thanks, Tom |
From: Stefan <son...@ba...> - 2007-01-29 10:23:28
|
I've tried it with _usecache = false and it works as it should. The solution could be to purge the cache before reading a deleted page. or to disable the cache for the moment a deleted page should be read. To reset the cache on page deletion is not enough i think. A page can be deleted with button "remove page" or removing the content from the page. Both have to reset the cache. But the second is first a normal edit function. Maybe it's easier to do it while reading a deleted page. Stefan _ Manuel Vacelet schrieb: > 2007/1/26, Manuel Vacelet <man...@gm...>: > >> 2007/1/26, Stefan <son...@ba...>: >> >>> Hello Manuel, >>> >>> i have inserted the patch here but the result for me is the same as >>> before (1.3.13 RC2) >>> Entering a delteted page with the deleted page link in "recend changes" >>> there is a message to create the page. open the page with the full >>> linkname in browser url field (widthout action=create) the page is shown >>> as before i deleted it. i will make the code tests to see when it stops. >>> >> Hello Stephan, >> >> I made the patch on a customized version of phpwiki 1.3.12p3 (on this >> part, our customization shouldn't impact much). >> >> I remember I had to switch off HTML cache (USECACHE = false) during my >> test but I can't figure if I re-enabled it after. >> > > I didn't have time to test with the latest RC but I confirm I had to > switch cache off and it didn't work with cache enabled. > > I think the good option it to reset html cache on page deletion. > > What do you think ? > > BTW, can you make the test with USECACHE = false ? > > -- Manuel > > ------------------------------------------------------------------------- > Take Surveys. Earn Cash. Influence the Future of IT > Join SourceForge.net's Techsay panel and you'll get the chance to share your > opinions on IT & business topics through brief surveys - and earn cash > http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV > _______________________________________________ > Phpwiki-talk mailing list > Php...@li... > https://lists.sourceforge.net/lists/listinfo/phpwiki-talk > > > |
From: Manuel V. <man...@gm...> - 2007-01-29 13:55:49
|
2007/1/29, Stefan <son...@ba...>: > I've tried it with _usecache = false and it works as it should. > > The solution could be to purge the cache before reading a deleted page. > or to disable the cache for the moment a deleted page should be read. > > To reset the cache on page deletion is not enough i think. > A page can be deleted with button "remove page" or removing the content > from the page. > Both have to reset the cache. But the second is first a normal edit > function. > > Maybe it's easier to do it while reading a deleted page. Maybe it is (I didn't have a look at this) but from architecture point of view I think it's much more easy to do it on page deletion. - If user click on remove page, we have to purge the cache. - If user make the page blank (ie. remove contents) the cache will be automatically flushed. I don't know what Reini thinks about these options (and if the patch do not break sth important). -- Manuel > _ > Manuel Vacelet schrieb: > > 2007/1/26, Manuel Vacelet <man...@gm...>: > > > >> 2007/1/26, Stefan <son...@ba...>: > >> > >>> Hello Manuel, > >>> > >>> i have inserted the patch here but the result for me is the same as > >>> before (1.3.13 RC2) > >>> Entering a delteted page with the deleted page link in "recend changes" > >>> there is a message to create the page. open the page with the full > >>> linkname in browser url field (widthout action=create) the page is shown > >>> as before i deleted it. i will make the code tests to see when it stops. > >>> > >> Hello Stephan, > >> > >> I made the patch on a customized version of phpwiki 1.3.12p3 (on this > >> part, our customization shouldn't impact much). > >> > >> I remember I had to switch off HTML cache (USECACHE = false) during my > >> test but I can't figure if I re-enabled it after. > >> > > > > I didn't have time to test with the latest RC but I confirm I had to > > switch cache off and it didn't work with cache enabled. > > > > I think the good option it to reset html cache on page deletion. > > > > What do you think ? > > > > BTW, can you make the test with USECACHE = false ? > > > > -- Manuel > > > > ------------------------------------------------------------------------- > > Take Surveys. Earn Cash. Influence the Future of IT > > Join SourceForge.net's Techsay panel and you'll get the chance to share your > > opinions on IT & business topics through brief surveys - and earn cash > > http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV > > _______________________________________________ > > Phpwiki-talk mailing list > > Php...@li... > > https://lists.sourceforge.net/lists/listinfo/phpwiki-talk > > > > > > > > > ------------------------------------------------------------------------- > Take Surveys. Earn Cash. Influence the Future of IT > Join SourceForge.net's Techsay panel and you'll get the chance to share your > opinions on IT & business topics through brief surveys - and earn cash > http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV > _______________________________________________ > Phpwiki-talk mailing list > Php...@li... > https://lists.sourceforge.net/lists/listinfo/phpwiki-talk > |
From: Reini U. <ru...@x-...> - 2007-01-30 07:22:16
|
Manuel Vacelet schrieb: > 2007/1/29, Stefan <son...@ba...>: >> I've tried it with _usecache = false and it works as it should. >> >> The solution could be to purge the cache before reading a deleted page. >> or to disable the cache for the moment a deleted page should be read. >> >> To reset the cache on page deletion is not enough i think. >> A page can be deleted with button "remove page" or removing the content >> from the page. >> Both have to reset the cache. But the second is first a normal edit >> function. >> >> Maybe it's easier to do it while reading a deleted page. > > Maybe it is (I didn't have a look at this) but from architecture point > of view I think it's much more easy to do it on page deletion. > - If user click on remove page, we have to purge the cache. > - If user make the page blank (ie. remove contents) the cache will be > automatically flushed. > > I don't know what Reini thinks about these options (and if the patch > do not break sth important). I need some more time to test it. Purging the memory DB_Cache AND the parsed cached_html in the db should fix that. I also experience strange cache problems on MSIE in the meantime. Only on MSIE. This might be a ETags issue or some special browser cache logic. >> Manuel Vacelet schrieb: >> > 2007/1/26, Manuel Vacelet <man...@gm...>: >> > >> >> 2007/1/26, Stefan <son...@ba...>: >> >> >> >>> Hello Manuel, >> >>> >> >>> i have inserted the patch here but the result for me is the same as >> >>> before (1.3.13 RC2) >> >>> Entering a delteted page with the deleted page link in "recend >> changes" >> >>> there is a message to create the page. open the page with the full >> >>> linkname in browser url field (widthout action=create) the page is >> shown >> >>> as before i deleted it. i will make the code tests to see when it >> stops. >> >>> >> >> Hello Stephan, >> >> >> >> I made the patch on a customized version of phpwiki 1.3.12p3 (on this >> >> part, our customization shouldn't impact much). >> >> >> >> I remember I had to switch off HTML cache (USECACHE = false) during my >> >> test but I can't figure if I re-enabled it after. >> >> >> > >> > I didn't have time to test with the latest RC but I confirm I had to >> > switch cache off and it didn't work with cache enabled. >> > >> > I think the good option it to reset html cache on page deletion. >> > >> > What do you think ? >> > >> > BTW, can you make the test with USECACHE = false ? >> > >> > -- Manuel -- Reini Urban http://phpwiki.org/ http://murbreak.at/ http://helsinki.at/ http://spacemovie.mur.at/ |