phpwiki-talk

[Phpwiki-talk] fix to lib/WikiDB.php to remove deprecated call-time pass by reference

[Charles C. <ch...@ru...>]

In my apache error log I found an error message repeated many times
regarding call-time pass-by-reference.  The fix is

lib/WikiDB.php - WikiDB->renamePage() - line 499 - replace
    $oldpage->sendPageRenameNotification($to, &$meta, $emails, $userids);
with
    $oldpage->sendPageRenameNotification($to, $meta, $emails, $userids);

The definition
    function sendPageRenameNotification($to, &$meta, $emails, $userids) {
has the pass by reference marker so it looks like this is a cut and paste
error.

regards,
Charles

Re: [Phpwiki-talk] fix to lib/WikiDB.php to remove deprecated call-time pass by reference

[Arnaud F. <ar...@cr...>]

Le 3 f=E9vr. 05, =E0 04:45, Charles Corrigan a =E9crit :

> In my apache error log I found an error message repeated many times
> regarding call-time pass-by-reference.  The fix is
>
> lib/WikiDB.php - WikiDB->renamePage() - line 499 - replace
>     $oldpage->sendPageRenameNotification($to, &$meta, $emails,=20
> $userids);
> with
>     $oldpage->sendPageRenameNotification($to, $meta, $emails,=20
> $userids);
>
> The definition
>     function sendPageRenameNotification($to, &$meta, $emails,=20
> $userids) {
> has the pass by reference marker so it looks like this is a cut and=20
> paste
> error.
>

Are you using php5 ?

If so, php5 pass objects by reference, not by copy. So the &$object=20
syntax from php4 is obsolete.
--
Arnaud Fontaine
CRAO
Jabber: sh...@ra...