phpwiki-talk

[Phpwiki-talk] Deleting pages

[Marc-Etienne V. <Mar...@al...>]

Hello,

Another question.

I have implemented a "real" remove item in menu for pages by using
the purgePage function in WikiDB.php (instead of deletePage).

It works, but it is VERY slow (might be 2 minutes to delete a page).

Trying to debug the reason for this slowness we found the following.

The time is mostly spent is the following lines that seem useless:

   $this->_update_recent_table();
   $this->_update_nonempty_table();

You removed these lines here:

http://phpwiki.cvs.sourceforge.net/phpwiki/phpwiki/lib/WikiDB/backend/ADODB.php?r1=1.61&r2=1.62

in file lib/WikiDB/backend/ADODB.php

We are using "PearDB.php"

Is it safe to delete these two lines in purge_page function in
file lib/WikiDB/backend/PearDB.php ?

Thank you for your help.

Best regards,

Marc-Etienne

-- 
==================================================================    ------
| Marc-Etienne Vargenau                                          |   /      \
| Alcatel-Lucent France, Route de Villejust, 91620 NOZAY, FRANCE |  /  /|'`  \
| +33 (0)1 30 77 28 33, Mar...@al...  | |  /'| '   |
==================================================================  \   |/   /
| L'essence des Mathématiques est dans leur liberté.             |   \      /
|                                Georges Cantor                  |    ------
==================================================================

Re: [Phpwiki-talk] Deleting pages

[Reini U. <ru...@x-...>]

2008/4/11, Marc-Etienne Vargenau <Mar...@al...>:
>  Another question.
>
>  I have implemented a "real" remove item in menu for pages by using
>  the purgePage function in WikiDB.php (instead of deletePage).

I would call it action=purge, not remove.
remove should be undoable and it should be listed in RecentChanges,
purge might be visible in RecentChanges.

>  It works, but it is VERY slow (might be 2 minutes to delete a page).
>
>  Trying to debug the reason for this slowness we found the following.
>
>  The time is mostly spent is the following lines that seem useless:
>
>    $this->_update_recent_table();
>    $this->_update_nonempty_table();
>
>  You removed these lines here:
>
>  http://phpwiki.cvs.sourceforge.net/phpwiki/phpwiki/lib/WikiDB/backend/ADODB.php?r1=1.61&r2=1.62
>
>  in file lib/WikiDB/backend/ADODB.php

I didn't just remove these two functions. I've re-implemented them for ADODB
for the special case of remove, to speed it up.

A second speed improvement, removal of pending links, is only executed
with DEBUG,
and not thoroughly tested.

If the ADODB strategy works ok, we can do the same for PearDB.


>  We are using "PearDB.php"
>
>  Is it safe to delete these two lines in purge_page function in
>  file lib/WikiDB/backend/PearDB.php ?

No.
-- 
Reini Urban
http://phpwiki.org/              http://murbreak.at/