phpwiki-talk

Re: [Phpwiki-talk] [phpwiki-checkins] CVS: phpwiki/lib stdlib.php, 1.270, 1.271

[Reini U. <ru...@x-...>]

2008/3/18, Marc-Etienne Vargenau <Mar...@al...>:
> Reini Urban a écrit :
>
> > Update of /cvsroot/phpwiki/phpwiki/lib
>  > In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv30097

>  > revert &amp; links

>  > -         $args .= '&amp;start_debug=' . $request->getArg('start_debug');
>  > +         $args .= '&start_debug=' . $request->getArg('start_debug');
>
> Hello Reini,
>  You also reverted this modification. Shouldn't the '&' be escaped?

Theoretically and for strict xhtml conformity (non-quirks mode) your
code is okay.
But I fear that it is not stable enough when being read by the next
request by certain php's.

-- 
Reini Urban
http://phpwiki.org/              http://murbreak.at/

Re: [Phpwiki-talk] [phpwiki-checkins] CVS: phpwiki/lib stdlib.php, 1.270, 1.271

[Marc-Etienne V. <Mar...@al...>]

Reini Urban a écrit :
> 2008/3/18, Marc-Etienne Vargenau <Mar...@al...>:
>> Reini Urban a écrit :
>>
>>> Update of /cvsroot/phpwiki/phpwiki/lib
>>  > In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv30097
> 
>>  > revert &amp; links
> 
>>  > -         $args .= '&amp;start_debug=' . $request->getArg('start_debug');
>>  > +         $args .= '&start_debug=' . $request->getArg('start_debug');
>>
>> Hello Reini,
>>  You also reverted this modification. Shouldn't the '&' be escaped?
> 
> Theoretically and for strict xhtml conformity (non-quirks mode) your
> code is okay.
> But I fear that it is not stable enough when being read by the next
> request by certain php's.

OK, so I will leave it as it is.

Regards,

Marc-Etienne

-- 
==================================================================    ------
| Marc-Etienne Vargenau                                          |   /      \
| Alcatel-Lucent France, Route de Villejust, 91620 NOZAY, FRANCE |  /  /|'`  \
| +33 (0)1 30 77 28 33, Mar...@al...  | |  /'| '   |
==================================================================  \   |/   /
| L'essence des Mathématiques est dans leur liberté.             |   \      /
|                                Georges Cantor                  |    ------
==================================================================