phpwiki-talk

[Phpwiki-talk] RecentChanges plugin

[Marc-Etienne V. <Mar...@al...>]

Hello,

I am trying to improve the user interface of the RecentChanges plugin.

I have some questions, sorry if they are trivial.

1) What is the meaning of the "||=" syntax?
In MyRecentedits, you have "show_minor=1 show_deleted||=1"
Why not write "show_minor=1 show_deleted=1" ?

2) In all pages, you have "daylist=1,3,7,30,90,0"
except in FullRecentChanges where you have "daylist=1,3,7,30,90,-1"
Why?

Thank you in advance.

Marc-Etienne

-- 
==================================================================    ------
| Marc-Etienne Vargenau                                          |   /      \
| Alcatel-Lucent France, Route de Villejust, 91620 NOZAY, FRANCE |  /  /|'`  \
| +33 (0)1 30 77 28 33, Mar...@al...  | |  /'| '   |
==================================================================  \   |/   /
| L'essence des Mathématiques est dans leur liberté.             |   \      /
|                                Georges Cantor                  |    ------
==================================================================

Re: [Phpwiki-talk] RecentChanges plugin

[Reini U. <ru...@x-...>]

Marc-Etienne Vargenau schrieb:
> Hello,
> 
> I am trying to improve the user interface of the RecentChanges plugin.
> 
> I have some questions, sorry if they are trivial.
> 
> 1) What is the meaning of the "||=" syntax?
> In MyRecentedits, you have "show_minor=1 show_deleted||=1"
> Why not write "show_minor=1 show_deleted=1" ?

||= is a weaker assignment than =, "define if not defined."

You can override ||= values in the url, but you cannot override = 
assignments via url assignments.

> 2) In all pages, you have "daylist=1,3,7,30,90,0"
> except in FullRecentChanges where you have "daylist=1,3,7,30,90,-1"
> Why?

Don't know. Both are the same.

         elseif ($days < 1)
             $label = "..."; //alldays
         else
             $label = sprintf(_("%s days"), abs($days));

So -1 displays "..." for alldays, but takes days=0 as argument.
But days=0 also displays "..." now.

BTW: With 0 days the day filter is ignored. All changes are listed.

-- 
Reini Urban
http://phpwiki.org/  http://murbreak.at/
http://helsinki.at/  http://spacemovie.mur.at/

Re: [Phpwiki-talk] RecentChanges plugin

[Marc-Etienne V. <Mar...@al...>]

Reini Urban a écrit :
> Marc-Etienne Vargenau schrieb:
>> Hello,
>>
>> I am trying to improve the user interface of the RecentChanges plugin.
>>
>> I have some questions, sorry if they are trivial.

Hello Reini,

Thank you for the answers. My changes are not mature enough to be
published now. I will show you when it is ready.

Best regards,

Marc-Etienne

-- 
==================================================================    ------
| Marc-Etienne Vargenau                                          |   /      \
| Alcatel-Lucent France, Route de Villejust, 91620 NOZAY, FRANCE |  /  /|'`  \
| +33 (0)1 30 77 28 33, Mar...@al...  | |  /'| '   |
==================================================================  \   |/   /
| L'essence des Mathématiques est dans leur liberté.             |   \      /
|                                Georges Cantor                  |    ------
==================================================================