Thomas Harding schrieb:
> temp files are now stored in uploads directory instead of /var/tmp.
> config.ini is parsed to handle DATA_PATH.
Just to keep you informed what I'm working on and what I haven't
commmitted yet, I attached my local cvs diff.
And please, Thomas, send unifixed diff's.
diff -bu old new or cvs diff -bu
I cannot stand context diffs.
Comments:
---------
ImageTile thumbs:
I think we should put these files either into
some PLUGIN_CACHED subdir or into uploads/thumbs.
UpLoadPlugin forbids to re-upload the same filename,
so we'll get a nameclash if there are many thumbs.
EditToolbars:
AddPlugins is currently broken (with my attached diff), but the new
layout is fixed and better than before.
Undo is also broken and needs to be generalized for all toolbar button.
Just save a snapshot for each insertTags().
listsize is not needed in js, since pages.length is the listsize.
I fixed the buttons div for MSIE.
HTML-Validation:
I changed all id's from edit[content] to edit:content, since "[" is
invalid in the id tag. names are ok this way and needed for the
automatic php request => array features.
create_user:
I haven't looked at your WikiAdminUtils create_user work yet, but it's
not that simple. Better just call the WikiUserNew method (TODO), and
leave the hard work to the backend.
The location of create_user in WikiAdminUtils is okay.
But maybe we should create a UserAdministration plugin, where one can
handle more than just create_user.
modify_group ownership, email_validation, blocking
and more permissions properties.
password routines:
Where do we have this?
In passencrypt.php, 2 funcs in stdlib.php, and some parts in the auth
sections. This should be unified in some general location. Good.
locale stuff:
I handle this very carefully. It's very easy to break locale,
I often did, and it needed a lot of time to fix it again.
(Similar to auth sessions)
--
Reini Urban
http://phpwiki.org/
|
