From: <tho...@la...> - 2005-09-22 22:28:01
Attachments:
diff_2005_09_22_00_12.diff
|
Hello, I'm working for a couple of weeks on phpwiki. I principally made changes on PhotoAlbum plugin. Today, I made some changes on plugin editpages tool. Here is also an old fix on locales... -- Thomas Harding |
From: <tho...@la...> - 2005-09-23 13:58:00
Attachments:
PhotoAlbum_args
|
On Fri, Sep 23, 2005 at 12:31:26AM +0200, Thomas Harding wrote: > Today, I made some changes on plugin editpages tool. I'd forgotten to post a file: /lib/plugin/PhotoAlbum_args drop it in the /lib/plugin directory, don't forget to apply the yesterday's patch, edit a page, call plugin tool, and double-click on PhotoAlbum... -- Thomas Harding |
From: Reini U. <ru...@x-...> - 2005-09-24 14:41:15
|
Thomas Harding schrieb: > On Fri, Sep 23, 2005 at 12:31:26AM +0200, Thomas Harding wrote: >>Today, I made some changes on plugin editpages tool. I see. The explicit listsize is not so good, because it destroys the list scrollbar inside the seperate window which has no scrollbar. It's better to leave that at 20 or less. I'll fix that behaviour. _nl + _quota as magic quote strings are also not quite stable, esp. when inserting templates. > I'd forgotten to post a file: /lib/plugin/PhotoAlbum_args > > drop it in the /lib/plugin directory, don't forget to apply the > yesterday's patch, edit a page, call plugin tool, and double-click on > PhotoAlbum... If at all I believe the args file should have an explicit extension, .args And I think it better should be a plugin method than a seperate file, so that all existing plugins get the desc automatically. See PluginManager. -- Reini Urban http://xarch.tu-graz.ac.at/home/rurban/ http://phpwiki.org/ |
From: <tho...@la...> - 2005-09-24 18:06:24
|
On Sat, Sep 24, 2005 at 04:41:06PM +0200, Reini Urban wrote: > I see. The explicit listsize is not so good, because it destroys the > list scrollbar inside the seperate window which has no scrollbar. OK : i made it because I searched for 10 minutes where there the other plugins : the scrollbar is not visible cause to the window's width. > It's better to leave that at 20 or less. > I'll fix that behaviour. OK. > _nl + _quota as magic quote strings are also not quite stable, esp. when > inserting templates. I have no other idea how to cross the JavaScript with these characters. > >I'd forgotten to post a file: /lib/plugin/PhotoAlbum_args > > > >drop it in the /lib/plugin directory, don't forget to apply the > >yesterday's patch, edit a page, call plugin tool, and double-click on > >PhotoAlbum... > > If at all I believe the args file should have an explicit extension, .args OK. > And I think it better should be a plugin method than a seperate file, > so that all existing plugins get the desc automatically. > See PluginManager. I see: defaults args are loaded. Will use it, but add another method to load possible args, and return to this method if not found. -- Thomas Harding |
From: <tho...@la...> - 2005-09-24 20:12:17
Attachments:
EditToolbar.php
toolbar.js
|
On Sat, Sep 24, 2005 at 04:41:06PM +0200, Reini Urban wrote: New version, files EditToolbar toolbar.js joined. > I see. The explicit listsize is not so good, because it destroys the > list scrollbar inside the seperate window which has no scrollbar. > It's better to leave that at 20 or less. OK : I just changed window width to have no window scrollbar (they appears in both Mozilla and Firefox, don't know why). > _nl + _quota as magic quote strings are also not quite stable, esp. when > inserting templates. Used %n url encoding instead. > And I think it better should be a plugin method than a seperate file, > so that all existing plugins get the desc automatically. > See PluginManager. Done too : loads new plugin function " getArgumentsDesc() " and fall down on "getDefaultArguments() " Regards, -- Thomas Harding |
From: <tho...@la...> - 2005-09-24 22:16:03
Attachments:
PhotoAlbum2.php
|
Hello, This version of PhotoAlbum re-enables column and row modes, corrects a security hole (beware : csv file have now to be named "somename.csv"), and permits to loads a single photo from the net. That's all for today :) -- Thomas Harding |