phpwiki-talk

[Phpwiki-talk] Re: [phpwiki - Help] RE: Wiki is getting spammed pretty bad

[Dan F. <dfr...@cs...>]

SourceForge.net wrote:

>Read and respond to this message at: 
>https://sourceforge.net/forum/message.php?msg_id=3017412
>By: rurban
>
>Disable
>ALLOW_ANON_EDIT and/or ALLOW_BOGO_LOGIN 
>in config/config.ini (since 1.3.10) or index.php (before)
>
>Current CVS, which will be released this weekend (hopefully), has more spam
>prevention methods.
>
>Running current CVS is recommended, since it's considered stable.
>  
>

"current CVS" == stable is a contradiction in terms, because it's always 
changing. If it's stable, stick a fork in it and release it! :)

Dan

Re: Releasing (WAS: Re: [Phpwiki-talk] Re: [phpwiki - Help] RE: Wiki is getting spammed pretty bad)

[Arnaud F. <ar...@cr...>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Reini Urban wrote:
| Remaining issues are locale problems (could not reproduce them so far),

As far as we've investigated, it seems that the locale problem comes
from badly or no installed locale on the server and the $LANG global
that doesnt setup properly.

If you set $LANG to your locale, it works but you can't change it
anymore in your user prefs.

Still investigating :)

Arnaud
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.0 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org

iD8DBQFCRAXPyAf3wgFyy1ARAjgiAJ0dWCOdpFAQ+JaXXHckFCpXQVZOyACfaanq
9hwckAVNVfwII0K8q3MxuBc=
=9igL
-----END PGP SIGNATURE-----

Re: Releasing (WAS: Re: [Phpwiki-talk] Re: [phpwiki - Help] RE: Wiki is getting spammed pretty bad)

[Reini U. <ru...@x-...>]

> Reini Urban wrote:
> | Remaining issues are locale problems (could not reproduce them so
> far),
>
> As far as we've investigated, it seems that the locale problem comes
> from badly or no installed locale on the server and the $LANG global
> that doesnt setup properly.
>
> If you set $LANG to your locale, it works but you can't change it
> anymore in your user prefs.
>
> Still investigating :)

Is it fixed with rc1?


-- 
Reini Urban
http://phpwiki.org/   http://xarch.tu-graz.ac.at/home/rurban/

Re: [Phpwiki-talk] Re: [phpwiki - Help] RE: Wiki is getting spammed pretty bad

[Reini U. <ru...@x-...>]

Dan Frankowski schrieb:
> SourceForge.net wrote:
> 
>> Read and respond to this message at: 
>> https://sourceforge.net/forum/message.php?msg_id=3017412
>> By: rurban
>>
>> Disable
>> ALLOW_ANON_EDIT and/or ALLOW_BOGO_LOGIN in config/config.ini (since 
>> 1.3.10) or index.php (before)
>>
>> Current CVS, which will be released this weekend (hopefully), has more 
>> spam
>> prevention methods.
>>
>> Running current CVS is recommended, since it's considered stable.
> 
> "current CVS" == stable is a contradiction in terms, because it's always 
> changing. If it's stable, stick a fork in it and release it! :)

I cannot release it at this state because certain unneeded features are 
not fully implemented, and some optional extensions are buggy.

The basic features are more stable than the ones in 1.3.10
-- 
Reini Urban
http://xarch.tu-graz.ac.at/home/rurban
http://phpwiki.org

Releasing (WAS: Re: [Phpwiki-talk] Re: [phpwiki - Help] RE: Wiki is getting spammed pretty bad)

[Dan F. <dfr...@cs...>]

Reini Urban wrote:

> Dan Frankowski schrieb:
>
>> SourceForge.net wrote:
>>
...

>>> Running current CVS is recommended, since it's considered stable.
>>
>>
>> "current CVS" == stable is a contradiction in terms, because it's 
>> always changing. If it's stable, stick a fork in it and release it! :)
>
>
> I cannot release it at this state because certain unneeded features 
> are not fully implemented, and some optional extensions are buggy.


I understand. That's a tough situation. Releases always end up in that 
situation.

Could you perhaps disable the unneeded features and optional extensions 
(make it so people can't trigger the bugs), release, then try to fix the 
unneeded features and optional extensions, and release again?

"Release early, release often": 
http://www.catb.org/~esr/writings/cathedral-bazaar/cathedral-bazaar/ar01s04.html

Dan

Re: Releasing (WAS: Re: [Phpwiki-talk] Re: [phpwiki - Help] RE: Wiki is getting spammed pretty bad)

[Reini U. <ru...@x-...>]

Dan Frankowski schrieb:
> Reini Urban wrote:
>> I cannot release it at this state because certain unneeded features 
>> are not fully implemented, and some optional extensions are buggy.
> 
> I understand. That's a tough situation. Releases always end up in that 
> situation.
> 
> Could you perhaps disable the unneeded features and optional extensions 
> (make it so people can't trigger the bugs), release, then try to fix the 
> unneeded features and optional extensions, and release again?
> 
> "Release early, release often": 
> http://www.catb.org/~esr/writings/cathedral-bazaar/cathedral-bazaar/ar01s04.html 

I know. But it's already almost a year, and this should be more stable 
than 1.3.10.
There are still several issues known to me.
-- 
Reini Urban
http://xarch.tu-graz.ac.at/home/rurban/
http://phpwiki.org/

Re: Releasing (WAS: Re: [Phpwiki-talk] Re: [phpwiki - Help] RE: Wiki is getting spammed pretty bad)

[Dan F. <dfr...@cs...>]

Any word on what issues remain before release, and an estimated time? As 
I have not been pitching in, I can't complain. Just wondering.

Dan

P.S. By the way, I took the spam code for more-than-20-links for our 
next release of StormZebra. Thanks. We got massively spammed, so we 
needed something, since we don't yet have an active community. I turned 
the "20" into a config param (SPAM_MAX_EXTERNAL_LINKS). I also changed 
the error message that occurs when the spam happened. It used to say 
"Conflicting edits", which seemed wrong. Of course I didn't take all of 
the code in phpwiki CVS current, so maybe I missed something.

Anyway, I tried to attach our copy of editpage.php, but it got bounced 
as spam by SourceForge. It has all sorts of other mods too (e.g., 
structured data), but feel free to take whatever is useful. For example:

@@ -335,19 +411,21 @@
        $oldtext = $current->getPackedContent();
        $newtext =& $this->_content;
        // 1. Not more then 20 new external links
-        if ($this->numLinks($newtext) - $this->numLinks($oldtext) >= 20) {
+        if (!defined('SPAM_MAX_EXTERNAL_LINKS')) 
define('SPAM_MAX_EXTERNAL_LINK
S', 20);
+        if ($this->numLinks($newtext) - $this->numLinks($oldtext) >= 
SPAM_MAX_E
XTERNAL_LINKS) {
            // mail the admin?
            $this->tokens['PAGE_LOCKED_MESSAGE'] =
                HTML($this->getSpamMessage(),
-                     HTML::p(HTML::em(_("Too many external links."))));
+                     HTML::p(HTML::em(sprintf(_("Too many external 
links (more
than %d)."), SPAM_MAX_EXTERNAL_LINKS))));
            return true;
        }
...

======

@@ -117,35 +134,95 @@
            // output, and update the version
            $this->_content = implode ("\n", $output);
            $this->_currentVersion = $this->current->getVersion();
-            $this->version = $this->_currentVersion;
            $unresolved = $diff->ConflictingBlocks;
+            if ($this->version != $this->_currentVersion) {
+                // saveFailed because of conflicting edits
+                $this->version = $this->_currentVersion;
            $tokens['CONCURRENT_UPDATE_MESSAGE'] = 
$this->getConflictMessage($unresolved);
...


Reini Urban wrote:

> Dan Frankowski schrieb:
>
>> Reini Urban wrote:
>>
>>> I cannot release it at this state because certain unneeded features 
>>> are not fully implemented, and some optional extensions are buggy.
>>
>>
>>
>> I understand. That's a tough situation. Releases always end up in 
>> that situation.
>>
>> Could you perhaps disable the unneeded features and optional 
>> extensions (make it so people can't trigger the bugs), release, then 
>> try to fix the unneeded features and optional extensions, and release 
>> again?
>>
>> "Release early, release often": 
>> http://www.catb.org/~esr/writings/cathedral-bazaar/cathedral-bazaar/ar01s04.html 
>
>
>
>
>
> I know. But it's already almost a year, and this should be more stable 
> than 1.3.10.
> There are still several issues known to me.

Re: Releasing (WAS: Re: [Phpwiki-talk] Re: [phpwiki - Help] RE: Wiki is getting spammed pretty bad)

[Reini U. <ru...@x-...>]

> Any word on what issues remain before release, and an estimated time? As
>  I have not been pitching in, I can't complain. Just wondering.

I had no time at all during the last two weeks because of our local
austrian filmfestival here, which I'm covering (in radio).

Remaining issues are locale problems (could not reproduce them so far),
remove blog and ModeratedPage
and the WikiAdmin problems with subpages.
maybe there's some more in the bugpages also.

> P.S. By the way, I took the spam code for more-than-20-links for our
> next release of StormZebra. Thanks. We got massively spammed, so we
> needed something, since we don't yet have an active community. I turned
> the "20" into a config param (SPAM_MAX_EXTERNAL_LINKS). I also changed
> the error message that occurs when the spam happened. It used to say
> "Conflicting edits", which seemed wrong. Of course I didn't take all of
> the code in phpwiki CVS current, so maybe I missed something.
>
> Anyway, I tried to attach our copy of editpage.php, but it got bounced
> as spam by SourceForge. It has all sorts of other mods too (e.g.,
> structured data), but feel free to take whatever is useful. For example:
>
> @@ -335,19 +411,21 @@
>         $oldtext = $current->getPackedContent();
>         $newtext =& $this->_content;
>         // 1. Not more then 20 new external links
> -        if ($this->numLinks($newtext) - $this->numLinks($oldtext) >=
> 20) { +        if (!defined('SPAM_MAX_EXTERNAL_LINKS'))
> define('SPAM_MAX_EXTERNAL_LINK
> S', 20);
> +        if ($this->numLinks($newtext) - $this->numLinks($oldtext) >=
> SPAM_MAX_E
> XTERNAL_LINKS) {
>             // mail the admin?
>             $this->tokens['PAGE_LOCKED_MESSAGE'] =
>                 HTML($this->getSpamMessage(),
> -                     HTML::p(HTML::em(_("Too many external links."))));
> +                     HTML::p(HTML::em(sprintf(_("Too many external
> links (more
> than %d)."), SPAM_MAX_EXTERNAL_LINKS))));
>             return true;
>         }
> ...
>
> ======
>
> @@ -117,35 +134,95 @@
>             // output, and update the version
>             $this->_content = implode ("\n", $output);
>             $this->_currentVersion = $this->current->getVersion();
> -            $this->version = $this->_currentVersion;
>             $unresolved = $diff->ConflictingBlocks;
> +            if ($this->version != $this->_currentVersion) {
> +                // saveFailed because of conflicting edits
> +                $this->version = $this->_currentVersion;
>             $tokens['CONCURRENT_UPDATE_MESSAGE'] =
> $this->getConflictMessage($unresolved);
> ...
>
>
> Reini Urban wrote:
>
>> Dan Frankowski schrieb:
>>
>>> Reini Urban wrote:
>>>
>>>> I cannot release it at this state because certain unneeded features
>>>> are not fully implemented, and some optional extensions are buggy.
>>>
>>>
>>>
>>> I understand. That's a tough situation. Releases always end up in
>>> that situation.
>>>
>>> Could you perhaps disable the unneeded features and optional
>>> extensions (make it so people can't trigger the bugs), release, then
>>> try to fix the unneeded features and optional extensions, and release
>>>  again?
>>>
>>> "Release early, release often":
>>> http://www.catb.org/~esr/writings/cathedral-bazaar/cathedral-bazaar/ar01s04.html
>>>
>>
>>
>>
>>
>>
>> I know. But it's already almost a year, and this should be more stable
>>  than 1.3.10.
>> There are still several issues known to me.
>
>
>
>
> -------------------------------------------------------
> This SF.net email is sponsored by Microsoft Mobile & Embedded DevCon
> 2005 Attend MEDC 2005 May 9-12 in Vegas. Learn more about the latest
> Windows Embedded(r) & Windows Mobile(tm) platforms, applications &
> content.  Register by 3/29 & save $300
> http://ads.osdn.com/?ad_id=6883&alloc_id=15149&op=click
> _______________________________________________
> Phpwiki-talk mailing list
> Php...@li...
> https://lists.sourceforge.net/lists/listinfo/phpwiki-talk


-- 
Reini Urban
http://phpwiki.org/   http://xarch.tu-graz.ac.at/home/rurban/