phpwiki-talk

[Phpwiki-talk] /phpwiki/phpwiki/themes/default/templates/navbar.tmpl v1.35 is broken

[Charles C. <ch...@ru...>]

The change to navbar.tmpl to "add Discussion link" broke PhpWiki for me. 
Error meessage in the apache error log is
[Thu Feb 03 12:06:40 2005] [error] PHP Fatal error:  Call to a member
function on a non-object in d:\\my
documents\\eclipse\\workspace\\phpwiki\\phpwiki\\lib\\Template.php(139) :
eval()'d code on line 12

Sorry I have not been able to work out the fix, I just reverted to the
previous version and then it worked for me.

regards,
Charles

Re: [Phpwiki-talk] /phpwiki/phpwiki/themes/default/templates/navbar.tmpl v1.35 is broken

[Arnaud F. <ar...@cr...>]

Le 3 f=E9vr. 05, =E0 05:19, Charles Corrigan a =E9crit :

> The change to navbar.tmpl to "add Discussion link" broke PhpWiki for =20=

> me.
> Error meessage in the apache error log is
> [Thu Feb 03 12:06:40 2005] [error] PHP Fatal error:  Call to a member
> function on a non-object in d:\\my
> =
documents\\eclipse\\workspace\\phpwiki\\phpwiki\\lib\\Template.php(139)=20=

>  :
> eval()'d code on line 12
>

Hmm ... it seems it has something to do with a call to a $revision =20
method.

In many cases, $revision doesn't exist so you have to test it =20
(something like if(!empt($revision)) before calling its methods.
navbar.tmpl contains many calls to $revision methods.

The test is supposed to be done with HIDE-TOOLBARS but it's actually =20
broken.
--
Arnaud Fontaine
CRAO
Jabber: sh...@ra...

Re: [Phpwiki-talk] /phpwiki/phpwiki/themes/default/templates/navbar.tmpl v1.35 is broken

[Arnaud F. <ar...@cr...>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Arnaud Fontaine wrote:
|
| Le 3 f=E9vr. 05, =E0 05:19, Charles Corrigan a =E9crit :
|
|> The change to navbar.tmpl to "add Discussion link" broke PhpWiki for  =
me.
|> Error meessage in the apache error log is
|> [Thu Feb 03 12:06:40 2005] [error] PHP Fatal error:  Call to a member
|> function on a non-object in d:\\my
|> documents\\eclipse\\workspace\\phpwiki\\phpwiki\\lib\\Template.php(139=
)
|>  :
|> eval()'d code on line 12
|>
|
| Hmm ... it seems it has something to do with a call to a $revision
method.
|
| In many cases, $revision doesn't exist so you have to test it
| (something like if(!empt($revision)) before calling its methods.
| navbar.tmpl contains many calls to $revision methods.
|
| The test is supposed to be done with HIDE-TOOLBARS but it's actually
| broken.

Ok ...

In default/template/navbar.tmpl

Index: navbar.tmpl
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
RCS file: /cvsroot/phpwiki/phpwiki/themes/default/templates/navbar.tmpl,v
retrieving revision 1.35
diff -r1.35 navbar.tmpl
3c3
<
- ---
| if(!$page->getName()) {
59c59,61
< } ?>
- ---
| }
| }
| ?>
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.5 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org

iD8DBQFCAg09yAf3wgFyy1ARAoRqAJ4ndPMIovqdEl2hcIQ0iny+wu7CagCeP+fW
BvZKeLOrQKUZstiopdYJ3Mg=3D
=3DVe5Z
-----END PGP SIGNATURE-----

Re: [Phpwiki-talk] /phpwiki/phpwiki/themes/default/templates/navbar.tmpl v1.35 is broken

[Arnaud F. <ar...@cr...>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Arnaud Fontaine wrote:

| | if(!$page->getName()) {

Forget this patch ... first the test was false (better to test if it's
set ...) and second, the theme fault not because of an unknown method on
$page ...

Still investigating ...


Arnaud
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.5 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org

iD8DBQFCAlseyAf3wgFyy1ARAupKAKDTKyUvK+5b2ekI4NqOJCmkpY6a8gCg5U9O
cns+KyzMaw+4GLrqjg18qJ4=
=xmqJ
-----END PGP SIGNATURE-----

Re: [Phpwiki-talk] /phpwiki/phpwiki/themes/default/templates/navbar.tmpl v1.35 is broken

[Arnaud F. <ar...@cr...>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Arnaud Fontaine wrote:
| Arnaud Fontaine wrote:
|
| | | if(!$page->getName()) {
|
| Forget this patch ... first the test was false (better to test if it's
| set ...) and second, the theme fault not because of an unknown method on
| $page ...
|
| Still investigating ...
|
|
| Arnaud


Just replace
'action'=>$dbh->isWikiPage

with

'action'=>$request->_dbi->isWikiPage


Pfff ... finally ;)

Arnaud
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.5 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org

iD8DBQFCAmKqyAf3wgFyy1ARAshUAJ4rvqlY1R1j+xJluYbXrd+fVX30kQCgofik
rbT6MVCK1QmqJQpixPQOWuY=
=S2KC
-----END PGP SIGNATURE-----