phpwiki-talk

[Phpwiki-talk] browse page and plugin/WikiAdminSelect.php show different owners for a page - and sometimes neither is what I expect

[Charles C. <ch...@ru...>]

I am running CVS phpwiki of a few days ago and I'm confused... :-(

I am using PhpWikiAdministration/Chown to change the owner of a page to a
group (I am using WikiPage for groups). It initially shows the owner of
almost all of the pages is the administrator id (as defined in config.ini).
I select a small number of pages to change and click yes - and phpwiki
re-displays the shorter list of pages and asks me to confirm.  I click yes
again. Sometimes I get a message telling me that no pages were changed - but
when I restart the process it still shows the administrator is the owner,
not the requested new group.  I have tried purging the html cache and it
makes no difference.

When I go to the actual page, sometimes it does show the page being owned by
the group. Sometimes it shows the page being owned by the administrator and
sometimes it shows the page being owned by another user id that initially
created the page.  I have spent sometime looking at the code but have not
yet got anywhere.  Does anyone have any ideas?

Regards,
Charles

Re: [Phpwiki-talk] browse page and plugin/WikiAdminSelect.php show different owners for a page - and sometimes neither is what I expect

[Manuel V. <man...@st...>]

Charles Corrigan wrote:
> I am running CVS phpwiki of a few days ago and I'm confused... :-(
> .. snip ..
> When I go to the actual page, sometimes it does show the page being owned by
> the group. Sometimes it shows the page being owned by the administrator and
> sometimes it shows the page being owned by another user id that initially
> created the page.  I have spent sometime looking at the code but have not
> yet got anywhere.  Does anyone have any ideas?
No ideas :(
But your problem seems to be really close to mine:
look at "Strange ACL behaviour" and "Group management status" messages. 
I didn't test that this week again but I think our problems are very close.

Regards
Manuel

Re: [Phpwiki-talk] browse page and plugin/WikiAdminSelect.php show different owners for a page - and sometimes neither is what I expect

[Reini U. <ru...@x-...>]

Charles Corrigan schrieb:
> I am running CVS phpwiki of a few days ago and I'm confused... :-(
> 
> I am using PhpWikiAdministration/Chown to change the owner of a page to a
> group (I am using WikiPage for groups). It initially shows the owner of
> almost all of the pages is the administrator id (as defined in config.ini).
> I select a small number of pages to change and click yes - and phpwiki
> re-displays the shorter list of pages and asks me to confirm.  I click yes
> again. Sometimes I get a message telling me that no pages were changed - but
> when I restart the process it still shows the administrator is the owner,
> not the requested new group.  I have tried purging the html cache and it
> makes no difference.

It's not the html cache. It's something different.

> When I go to the actual page, sometimes it does show the page being owned by
> the group. Sometimes it shows the page being owned by the administrator and
> sometimes it shows the page being owned by another user id that initially
> created the page.  I have spent sometime looking at the code but have not
> yet got anywhere.  Does anyone have any ideas?

This weeks cvs changes altered the pagedata cache settings (and more 
wikidb stuff), so it will need some time (a week?) to get that 
stabilized again.

I haven't yet tested all of the features and there're still some
bits which need fixes.
-- 
Reini Urban
http://xarch.tu-graz.ac.at/home/rurban/

Re: [Phpwiki-talk] browse page and plugin/WikiAdminSelect.php show different owners for a page - and sometimes neither is what I expect

[Charles C. <ch...@ru...>]

On Thu, December 2, 2004 2:48, Reini Urban said:

> This weeks cvs changes altered the pagedata cache settings (and more
> wikidb stuff), so it will need some time (a week?) to get that
> stabilized again.
>
> I haven't yet tested all of the features and there're still some
> bits which need fixes.

Just to clarify, I had problems with page ownership since I started
playing with 1.3.11pre - my previous patches were chipping away at bits of
the problem. What I am testing is from CVS as on Saturday - I will upgrade
to latest over the weekend.

regards,
Charles

Re: [Phpwiki-talk] browse page and plugin/WikiAdminSelect.php show different owners for a page - and sometimes neither is what I expect

[Reini U. <ru...@x-...>]

Charles Corrigan schrieb:
> On Thu, December 2, 2004 2:48, Reini Urban said:
>>This weeks cvs changes altered the pagedata cache settings (and more
>>wikidb stuff), so it will need some time (a week?) to get that
>>stabilized again.
>>
>>I haven't yet tested all of the features and there're still some
>>bits which need fixes.
> 
> 
> Just to clarify, I had problems with page ownership since I started
> playing with 1.3.11pre - my previous patches were chipping away at bits of
> the problem. 

oh. Sounded like the cache problem I was working at.

> What I am testing is from CVS as on Saturday - I will upgrade
> to latest over the weekend.

You have been warned. The pagedata and versiondata cache revamp is not 
finished, it's dirty, and I want to clean it up without using too much 
memory.
-- 
Reini Urban
http://xarch.tu-graz.ac.at/home/rurban/

RE: [Phpwiki-talk] browse page and plugin/WikiAdminSelect.php show different owners for a page - and sometimes neither is what I expect

[Charles C. <ch...@ru...>]

On Thu, December 2, 2004 10:38, Reini Urban said:
> Charles Corrigan schrieb:
> > Just to clarify, I had problems with page ownership since I started
> > playing with 1.3.11pre - my previous patches were chipping away at bits
> > of the problem. 
>
> oh. Sounded like the cache problem I was working at.
>
> > What I am testing is from CVS as on Saturday - I will upgrade
> > to latest over the weekend.

> You have been warned. The pagedata and versiondata cache revamp is not 
> finished, it's dirty, and I want to clean it up without using too much 
> memory.

With a clean install, the steps to reproduce this problem are:
1 - change the owner of the page PageGroupTest/Four from CarstenKlapp to
another user
2 - view the page - will correctly show the new owner
3 - view PhpWikiAdministration/Chown - it will still show Carsten as the
owner.

I have traced this problem through the call stack to WikiDB_Page->getOwner()
and WikiDB_Page->get() -  get() does not find a value for 'owner' in the
metadata of the page and it falls back to 'author_id', staring from the
first available version of the page.

As Reini suggested, it does appear that this is related to caching - when
the page is actually being displayed, all of the data is correct. However,
when the page is referred to indirectly (via lib/plugin/WikiAdminChown.php,
lib/plugin/WikiAdminSelect.php and lib/PageList.php in this case), the
cached data is incorrect or incomplete.

So far, I have been working around the periphery. I do not really know how
all of this works, so it may take me a while before I find anything. Given
that Reini are working on the caching, is it worth me investigating further?

Regards
Charles

RE: [Phpwiki-talk] browse page and plugin/WikiAdminSelect.php show different owners for a page - and sometimes neither is what I expect

[Charles C. <ch...@ru...>]

On 02 December 2004 10:38, Reini Urban wrote:
> You have been warned. The pagedata and versiondata cache
> revamp is not finished, it's dirty, and I want to clean
> it up without using too much memory.

How close to complete/reasonably stable is this rewrite?  I have been
working on other things (real life and migrating an existing Wiki to a new
site, including a large content cleanup).  I am now close to being able to
look at code (or at least developing test cases) again.

Regards,
Charles

Re: [Phpwiki-talk] browse page and plugin/WikiAdminSelect.php show different owners for a page - and sometimes neither is what I expect

[Reini U. <ru...@x-...>]

Charles Corrigan schrieb:
> On 02 December 2004 10:38, Reini Urban wrote:
>>You have been warned. The pagedata and versiondata cache
>>revamp is not finished, it's dirty, and I want to clean
>>it up without using too much memory.
> 
> How close to complete/reasonably stable is this rewrite?  I have been
> working on other things (real life and migrating an existing Wiki to a new
> site, including a large content cleanup).  I am now close to being able to
> look at code (or at least developing test cases) again.

db-side it is stable, just for the presentation I'm not sure.

We have now the unoptimized version in CVS, which ignores the fact that 
on an early stage (keyword extraction does a partial page iteration) 
some later needed pagedata can be stored in the pagedata cache.
When I enable that again it will save us about 10-20 sql queries.

Personally I haven't seen any problem so far with the current cache 
code. Other than your posted cornercases, which were very helpful.

I'm now adding some other bits and pieces to the WikiDB and work on the 
cache-optimization after that is finished.
I just refactored _cached_html yesterday, which saves as much more 
memory on SQL.
I want to add some better migration hints. Currenty it SQL-fails until 
you run ?action=upgrade.

Then I want to debug pagedata and versiondata cache again and optimize 
it, both for memory and run-time efficiency. About two days.

But some postgresql-cygwin and perl-libwin32 problems in other projects 
are also pending, so it could be more than two days.
-- 
Reini Urban
http://phpwiki.org/