phpwiki-talk

[Phpwiki-talk] ADOdb backend -- the return

[Philippe V. <Phi...@to...>]

Me again :-\

Reini,

The main driver to use FETCH_NUM is performance, but we revert to 
FETCH_ASSOC for the iterators, since they are using hashes.

I was thinking the following: if we build the column list when we build 
the query and pass it to the iterator (via the backend class or via the 
new() constructor), then we wouldn't need to FETCH_ASSOC at all!

I can code it and submit a patch if you think it is a good idea...

--
Philippe

Re: [Phpwiki-talk] ADOdb backend -- the return

[Reini U. <ru...@x-...>]

Philippe Vanhaesendonck wrote:
> The main driver to use FETCH_NUM is performance, but we revert to 
> FETCH_ASSOC for the iterators, since they are using hashes.
> 
> I was thinking the following: if we build the column list when we build 
> the query and pass it to the iterator (via the backend class or via the 
> new() constructor), then we wouldn't need to FETCH_ASSOC at all!
> 
> I can code it and submit a patch if you think it is a good idea...

Good idea. So I have time to catch our remaining preg_match crashes.

And it's only needed for special border cases (plugins).
All our internal core functions should use FETCH_NUM.
-- 
Reini Urban
http://phpwiki.sf.net/