phpwiki-talk

[Phpwiki-talk] CVS ErrorManager.php patch

[Dan F. <dfr...@cs...>]

diff -b -u -r1.26 ErrorManager.php
--- ErrorManager.php    2 Jun 2004 18:01:45 -0000       1.26
+++ ErrorManager.php    10 Jun 2004 19:23:19 -0000
@@ -227,7 +227,7 @@
         }
         else if (($error->errno & error_reporting()) != 0) {
             if  (($error->errno & $this->_postpone_mask) != 0) {
-                if (isa($error,'PhpErrorOnce')) {
+                if (is_a($error,'PhpErrorOnce')) {
                     $error->removeDoublettes($this->_postponed_errors);
                     if ( $error->_count < 2 )
                         $this->_postponed_errors[] = $error;

isa vs. is_a (WAS: Re: [Phpwiki-talk] CVS ErrorManager.php patch)

[Dan F. <dfr...@cs...>]

Okay, please inform me more about isa(). It seems to throw an error for 
me (PHP 4.3.2), and php.net documents is_a() but not isa().

However, when I "grep -r 'isa(' * | wc -l" I get 122 lines. Is that 122 
bugs? Is there some way that isa() is supposed to work?

Dan

Dan Frankowski wrote:

> diff -b -u -r1.26 ErrorManager.php
> --- ErrorManager.php    2 Jun 2004 18:01:45 -0000       1.26
> +++ ErrorManager.php    10 Jun 2004 19:23:19 -0000
> @@ -227,7 +227,7 @@
>         }
>         else if (($error->errno & error_reporting()) != 0) {
>             if  (($error->errno & $this->_postpone_mask) != 0) {
> -                if (isa($error,'PhpErrorOnce')) {
> +                if (is_a($error,'PhpErrorOnce')) {
>                     $error->removeDoublettes($this->_postponed_errors);
>                     if ( $error->_count < 2 )
>                         $this->_postponed_errors[] = $error;
>
>
>
> -------------------------------------------------------
> This SF.Net email is sponsored by the new InstallShield X.
>
>> From Windows to Linux, servers to mobile, InstallShield X is the
>
> one installation-authoring solution that does it all. Learn more and
> evaluate today! http://www.installshield.com/Dev2Dev/0504
> _______________________________________________
> Phpwiki-talk mailing list
> Php...@li...
> https://lists.sourceforge.net/lists/listinfo/phpwiki-talk

Re: isa vs. is_a (WAS: Re: [Phpwiki-talk] CVS ErrorManager.php patch)

[Reini U. <ru...@x-...>]

Dan Frankowski schrieb:
> Okay, please inform me more about isa(). It seems to throw an error for 
> me (PHP 4.3.2), and php.net documents is_a() but not isa().
> 
> However, when I "grep -r 'isa(' * | wc -l" I get 122 lines. Is that 122 
> bugs? Is there some way that isa() is supposed to work?

is_a is the php built in since, isa is our workaround (stdlib.php:1285), 
for older php's.

I added now a workaround which works if stdlib wasn't loaded also.

> Dan Frankowski wrote:
>> diff -b -u -r1.26 ErrorManager.php
>> --- ErrorManager.php    2 Jun 2004 18:01:45 -0000       1.26
>> +++ ErrorManager.php    10 Jun 2004 19:23:19 -0000
>> @@ -227,7 +227,7 @@
>>         }
>>         else if (($error->errno & error_reporting()) != 0) {
>>             if  (($error->errno & $this->_postpone_mask) != 0) {
>> -                if (isa($error,'PhpErrorOnce')) {
>> +                if (is_a($error,'PhpErrorOnce')) {
>>                     $error->removeDoublettes($this->_postponed_errors);
>>                     if ( $error->_count < 2 )
>>                         $this->_postponed_errors[] = $error;
>>
-- 
Reini Urban
http://xarch.tu-graz.ac.at/home/rurban/

Re: isa vs. is_a (WAS: Re: [Phpwiki-talk] CVS ErrorManager.php patch)

[Matthew P. <mp...@he...>]

On Sun, Jun 13, 2004 at 10:34:53AM +0200, Reini Urban wrote:
> Dan Frankowski schrieb:
> >Okay, please inform me more about isa(). It seems to throw an error for 
> >me (PHP 4.3.2), and php.net documents is_a() but not isa().
> >
> >However, when I "grep -r 'isa(' * | wc -l" I get 122 lines. Is that 122 
> >bugs? Is there some way that isa() is supposed to work?
> 
> is_a is the php built in since, isa is our workaround (stdlib.php:1285), 
> for older php's.

Why give them different names?  Just do something like this:

if (!function_exists('is_a'))
{
	function is_a()
	{
		// Insert own implementation here
	}
}

Works for all of my compat functions.  You get the inbuilt if it's
available, or the local re-implementation otherwise.

- Matt

Re: isa vs. is_a (WAS: Re: [Phpwiki-talk] CVS ErrorManager.php patch)

[Reini U. <ru...@x-...>]

Matthew Palmer schrieb:
> On Sun, Jun 13, 2004 at 10:34:53AM +0200, Reini Urban wrote:
>>Dan Frankowski schrieb:
>>>Okay, please inform me more about isa(). It seems to throw an error for 
>>>me (PHP 4.3.2), and php.net documents is_a() but not isa().
>>>
>>>However, when I "grep -r 'isa(' * | wc -l" I get 122 lines. Is that 122 
>>>bugs? Is there some way that isa() is supposed to work?
>>
>>is_a is the php built in since, isa is our workaround (stdlib.php:1285), 
>>for older php's.
> 
> 
> Why give them different names?  Just do something like this:
> 
> if (!function_exists('is_a'))
> {
> 	function is_a()
> 	{
> 		// Insert own implementation here
> 	}
> }
> 
> Works for all of my compat functions.  You get the inbuilt if it's
> available, or the local re-implementation otherwise.

I know. It was not my decision. And now I leave it as it is.

I guess we invented isa() before php did.
-- 
Reini Urban
http://xarch.tu-graz.ac.at/home/rurban/