From: Reini U. <ru...@x-...> - 2002-08-16 10:01:58
Attachments:
ImageLinks.patch
|
I ported my old implementation of Imagelinks now the latest phpwiki version. Keeping the metaphor [ linkname | url ] the linkname is what gets displayed. here the inlined image. the url is the target, here the pagenamed linked to. [ img | link ] like [images/prev.gif|PrevLink][images/next.gif|NextLink] as described in http://phpwiki.sourceforge.net/phpwiki/ImageLinks The images path is relative to the current theme, so we don't need the http: part in front. Included in the patch is also the SubPage patch, because I had to fix the SubPage patch to support ImageLinks. Discussable would be to put those links without http: into the buttons subdir, and provide a "^button:" prefix, like [button:next.gif|NextLink]. A live sample is at http://xarch.tu-graz.ac.at/autocad/wiki/WhatChangedWithAutoCAD2000 (page unaltered from the old version using my hacked 1.2 phpwiki lib.) The patch at http://phpwiki.sourceforge.net/phpwiki/ImageLinks is defunct. The Alt text (cartens' complaint) is the name of the link, here $URL. -- Reini Urban http://xarch.tu-graz.ac.at/home/rurban/ |
From: Reini U. <ru...@x-...> - 2002-08-16 12:06:10
Attachments:
ImageLinks.patch
|
I forgot to add support for relative style "/SubPage" links, which I do hereby. Attached is the combined patch for improved SubPages and ImageLinks. Reini Urban schrieb: > I ported my old implementation of Imagelinks now the latest phpwiki > version. Keeping the metaphor [ linkname | url ] the linkname is what > gets displayed. here the inlined image. the url is the target, here the > pagenamed linked to. > > [ img | link ] > like [images/prev.gif|PrevLink][images/next.gif|NextLink] > as described in http://phpwiki.sourceforge.net/phpwiki/ImageLinks > > The images path is relative to the current theme, so we don't need the > http: part in front. > Included in the patch is also the SubPage patch, because I had to fix > the SubPage patch to support ImageLinks. > > Discussable would be to put those links without http: into the buttons > subdir, and provide a "^button:" prefix, like [button:next.gif|NextLink]. > > A live sample is at > http://xarch.tu-graz.ac.at/autocad/wiki/WhatChangedWithAutoCAD2000 > (page unaltered from the old version using my hacked 1.2 phpwiki lib.) > > The patch at http://phpwiki.sourceforge.net/phpwiki/ImageLinks is > defunct. The Alt text (cartens' complaint) is the name of the link, > here $URL. -- Reini Urban http://xarch.tu-graz.ac.at/home/rurban/ |
From: Johannes G. <jg...@qf...> - 2002-08-17 11:31:27
|
On Fri, 16 Aug 2002, Reini Urban wrote: > I ported my old implementation of Imagelinks now the latest phpwiki > version. Keeping the metaphor [ linkname | url ] the linkname is what > gets displayed. here the inlined image. the url is the target, here the > pagenamed linked to. > > [ img | link ] > like [images/prev.gif|PrevLink][images/next.gif|NextLink] > as described in http://phpwiki.sourceforge.net/phpwiki/ImageLinks > What about real urls in the 'link' part of [img|link]? Is it already possible or do you only allow WikiPage links? This feature would allow us to add thumbnails of the form [ http://www.myhome.com/thumb.jpg | http://www.myhome.com/picture.jpg ] Perhaps, this is premature, since we have no real uploading scheme, so you always have to link to a homepage, but I think there are situation (look at the VisualWiki page), where this might be useful. BTW Is there any work on an upload/attachment mechanism? I think the subpage syntax would be nice (WikiPage/AttachMent1.jpg) regs Jo |
From: Reini U. <ru...@x-...> - 2002-08-17 11:53:36
|
Johannes Grosse schrieb: > On Fri, 16 Aug 2002, Reini Urban wrote: >>I ported my old implementation of Imagelinks now the latest phpwiki >>version. Keeping the metaphor [ linkname | url ] the linkname is what >>gets displayed. here the inlined image. the url is the target, here the >>pagenamed linked to. >> >> [ img | link ] >>like [images/prev.gif|PrevLink][images/next.gif|NextLink] >>as described in http://phpwiki.sourceforge.net/phpwiki/ImageLinks > > What about real urls in the 'link' part of [img|link]? > Is it already possible or do you only allow WikiPage links? > This feature would allow us to add thumbnails of the form > [ http://www.myhome.com/thumb.jpg | http://www.myhome.com/picture.jpg ] Yes, internal pages (resp. $Theme subdir data) and external urls are supported. In my last 1.2.x implementation I had border=1 on external links because it might be a security risk on including external cgi's ending with gif, but with 1.3.3 not anymore. hmm... when you see the border it was already to late... > Perhaps, this is premature, since we have no real uploading scheme, > so you always have to link to a homepage, but I think there are > situation (look at the VisualWiki page), where this might be useful. > > BTW Is there any work on an upload/attachment mechanism? > I think the subpage syntax would be nice > (WikiPage/AttachMent1.jpg) not yet. BTW: I changed my local VisualWiki somewhat. The default cache_dir param on windows was broken. I'll send you a patch sooner or later. I also improved the help page and simplified the valid image extensions. Something like this for the start: --- ./lib/plugincache-config.php~ 2002-03-10 09:54:16.000000000 +0000 +++ ./lib/plugincache-config.php 2002-08-03 14:40:09.000000000 +0000 @@ -80,7 +80,9 @@ $CacheParams = array( // db settings (database='file' is the fastest) 'database' => 'file', - 'cache_dir' => '/tmp/cache/', + 'cache_dir' => (substr(PHP_OS,0,3) == 'WIN') + ? ($GLOBALS['HTTP_ENV_VARS']['TEMP'] . "\\cache\\") + : '/tmp/cache/', 'filename_prefix' => 'phpwiki', -- Reini Urban http://xarch.tu-graz.ac.at/home/rurban/ |
From: Willie D. L. <wd...@ic...> - 2002-08-19 02:28:05
|
On Sat, 17 Aug 2002, Reini Urban wrote: > BTW: I changed my local VisualWiki somewhat. The default cache_dir param > on windows was broken. I'll send you a patch sooner or later. > I also improved the help page and simplified the valid image extensions. > > Something like this for the start: > > --- ./lib/plugincache-config.php~ 2002-03-10 09:54:16.000000000 +0000 I didn't find this file on my PhpWiki installation. Is the filename correct? Thanks in advance, Willie D. Leiva |
From: Reini U. <ru...@x-...> - 2002-08-19 07:18:27
|
Willie Dresler Leiva schrieb: > On Sat, 17 Aug 2002, Reini Urban wrote: >>BTW: I changed my local VisualWiki somewhat. The default cache_dir param >>on windows was broken. I'll send you a patch sooner or later. >>I also improved the help page and simplified the valid image extensions. >> >>Something like this for the start: >> >>--- ./lib/plugincache-config.php~ 2002-03-10 09:54:16.000000000 +0000 > > I didn't find this file on my PhpWiki installation. Is the filename correct? It's a patch on http://phpwiki.sourceforge.net/phpwiki/VisualWiki and in the nightly phpwiki snapshot. http://phpwiki.sf.net/nightly/phpwiki.nightly.tar.gz In the alpha demo not yet (pear cache issues), but it's in the works. http://phpwiki.sourceforge.net/demo/en/VisualWiki -- Reini Urban http://xarch.tu-graz.ac.at/home/rurban/ |