From: Reini U. <ru...@x-...> - 2002-01-10 20:28:29
|
Just want to post this note to the list before I can reason what the cause is. I cannot save an edited page with netscape 4.73. current CVS. I thought it was my server or mysql for a couple of days, but with internet explorer it works fine. So I think it's a javascript error on the editpage template. probably after the redirection of the successful update. IE reports just an error on the page. no more time to study it more carefully. -- Reini Urban http://atelier.akbild.ac.at/ (soon) http://xarch.tu-graz.ac.at/home/rurban/ (big) http://tv.mur.at/ (kulturelles) |
From: Carsten K. <car...@ma...> - 2002-01-10 20:40:39
|
There was a missing ) near the end of savepage.php which broke page saves a few days ago but I checked in the fix the next day (revision 1.2.2). Is this the error you get or something else? Parse error: parse error in /home/groups/p/ph/phpwiki/htdocs/alpha/lib/savepage.php on line 180 diff -u -r1.21 -r1.22 --- phpwiki/phpwiki/lib/savepage.php 2002/01/05 13:39:54 1.21 +++ phpwiki/phpwiki/lib/savepage.php 2002/01/07 21:09:11 1.22 @@ -177,7 +177,7 @@ } - $html .= QElement('hr', array('noshade' => 'noshade'); + $html .= QElement('hr', array('noshade' => 'noshade')); $html .= do_transform($newrevision->getContent()); echo GeneratePage('BROWSE', $html, $pagename, $newrevision); } Carsten On Thursday, January 10, 2002, at 03:28 pm, Reini Urban wrote: > Just want to post this note to the list before I can reason what the > cause is. > > I cannot save an edited page with netscape 4.73. current CVS. > I thought it was my server or mysql for a couple of days, but with > internet > explorer it works fine. So I think it's a javascript error on the editpage > template. probably after the redirection of the successful update. > IE reports just an error on the page. > no more time to study it more carefully. > -- > Reini Urban |
From: Reini U. <ru...@x-...> - 2002-01-10 20:55:09
|
No. No php error. it just hangs and then times out. the db is updated, so I think it's just an html error, in which netscape is very sensible. IE usually displays broken html code, but netscape not that often. I cannot debug it on the jscript console, so I think it's after the redirect. I also tried: rurban@REINI /cygdrive/r/php/phpwiki-dev/phpwiki/templates/ $ diff -u editpage.html~ editpage.html --- editpage.html~ Thu Jan 10 20:04:20 2002 +++ editpage.html Thu Jan 10 21:34:39 2002 @@ -30,7 +30,7 @@ * a redirect from a page to itself.) */ ?> -<form method="post" action="${BROWSE}EditPage" accept-charset="${CHARSET}"> +<form method="post" action="${ACTION}edit" accept-charset="${CHARSET}"> <textarea class="wikiedit" name="content" rows="${EDIT_AREA_HEIGHT}" but this doesn't fix it. Carsten Klapp schrieb: > There was a missing ) near the end of savepage.php which broke page saves > a few days ago but I checked in the fix the next day (revision 1.2.2). > > Is this the error you get or something else? > > Parse error: parse error in > /home/groups/p/ph/phpwiki/htdocs/alpha/lib/savepage.php on line 180 > > diff -u -r1.21 -r1.22 > --- phpwiki/phpwiki/lib/savepage.php 2002/01/05 13:39:54 1.21 > +++ phpwiki/phpwiki/lib/savepage.php 2002/01/07 21:09:11 1.22 > @@ -177,7 +177,7 @@ > } > > - $html .= QElement('hr', array('noshade' => 'noshade'); > + $html .= QElement('hr', array('noshade' => 'noshade')); > $html .= do_transform($newrevision->getContent()); > echo GeneratePage('BROWSE', $html, $pagename, $newrevision); > } > > Carsten > > On Thursday, January 10, 2002, at 03:28 pm, Reini Urban wrote: > > > Just want to post this note to the list before I can reason what the > > cause is. > > > > I cannot save an edited page with netscape 4.73. current CVS. > > I thought it was my server or mysql for a couple of days, but with > > internet > > explorer it works fine. So I think it's a javascript error on the editpage > > template. probably after the redirection of the successful update. > > IE reports just an error on the page. > > no more time to study it more carefully. > > -- > > Reini Urban > > _______________________________________________ > Phpwiki-talk mailing list > Php...@li... > https://lists.sourceforge.net/lists/listinfo/phpwiki-talk -- Reini Urban http://atelier.akbild.ac.at/ (soon) http://xarch.tu-graz.ac.at/home/rurban/ (big) http://tv.mur.at/ (kulturelles) |
From: Carsten K. <car...@ma...> - 2002-01-10 22:10:00
|
The accept-charset="${CHARSET}" is somewhat new too. Did you try removing that? -<form method="post" action="${BROWSE}EditPage" accept-charset="${CHARSET} "> +<form method="post" action="${BROWSE}edit"> Carsten On Thursday, January 10, 2002, at 03:55 pm, Reini Urban wrote: > No. No php error. it just hangs and then times out. the db is updated, so > I think it's just an html error, in which netscape is very sensible. > IE usually displays broken html code, but netscape not that often. > > I cannot debug it on the jscript console, so I think it's after the > redirect. > I also tried: > > rurban@REINI /cygdrive/r/php/phpwiki-dev/phpwiki/templates/ > $ diff -u editpage.html~ editpage.html > --- editpage.html~ Thu Jan 10 20:04:20 2002 > +++ editpage.html Thu Jan 10 21:34:39 2002 > @@ -30,7 +30,7 @@ > * a redirect from a page to itself.) > */ ?> > > -<form method="post" action="${BROWSE}EditPage" accept-charset="${CHARSET} > "> > +<form method="post" action="${ACTION}edit" accept-charset="${CHARSET}"> > <textarea class="wikiedit" > name="content" > rows="${EDIT_AREA_HEIGHT}" > > but this doesn't fix it. > |
From: Carsten K. <car...@ma...> - 2002-01-10 22:55:07
|
I found 3 missing quotes in the javascript code but it was in "browse.html" . There were a couple xhtml errors on "editpage.html" but this is probably not the cause of the problem either. Anyway I just checked in new "browse.html", "editpage.html" and "lib/Toolbar.php" to fix these errors. Carsten On Thursday, January 10, 2002, at 03:55 pm, Reini Urban wrote: > No. No php error. it just hangs and then times out. the db is updated, so > I think it's just an html error, in which netscape is very sensible. > IE usually displays broken html code, but netscape not that often. > > I cannot debug it on the jscript console, so I think it's after the > redirect. > I also tried: > > rurban@REINI /cygdrive/r/php/phpwiki-dev/phpwiki/templates/ > $ diff -u editpage.html~ editpage.html > --- editpage.html~ Thu Jan 10 20:04:20 2002 > +++ editpage.html Thu Jan 10 21:34:39 2002 > @@ -30,7 +30,7 @@ > * a redirect from a page to itself.) > */ ?> > > -<form method="post" action="${BROWSE}EditPage" accept-charset="${CHARSET} > "> > +<form method="post" action="${ACTION}edit" accept-charset="${CHARSET}"> > <textarea class="wikiedit" > name="content" > rows="${EDIT_AREA_HEIGHT}" > > but this doesn't fix it. > |
From: Reini U. <ru...@x-...> - 2002-07-06 11:45:59
|
Carsten Klapp schrieb: > I found 3 missing quotes in the javascript code but it was in "browse.html" > . There were a couple xhtml errors on "editpage.html" but this is probably > not the cause of the problem either. > Anyway I just checked in new "browse.html", "editpage.html" and > "lib/Toolbar.php" to fix these errors. > Carsten > > On Thursday, January 10, 2002, at 03:55 pm, Reini Urban wrote: > > > No. No php error. it just hangs and then times out. the db is updated, so > > I think it's just an html error, in which netscape is very sensible. > > IE usually displays broken html code, but netscape not that often. > > > > I cannot debug it on the jscript console, so I think it's after the > > redirect. > > I also tried: > > > > rurban@REINI /cygdrive/r/php/phpwiki-dev/phpwiki/templates/ > > $ diff -u editpage.html~ editpage.html > > --- editpage.html~ Thu Jan 10 20:04:20 2002 > > +++ editpage.html Thu Jan 10 21:34:39 2002 > > @@ -30,7 +30,7 @@ > > * a redirect from a page to itself.) > > */ ?> > > > > -<form method="post" action="${BROWSE}EditPage" accept-charset="${CHARSET} > > "> > > +<form method="post" action="${ACTION}edit" accept-charset="${CHARSET}"> > > <textarea class="wikiedit" > > name="content" > > rows="${EDIT_AREA_HEIGHT}" > > but this doesn't fix it. not this but probably some other minor fix. now it works. much slower than on IE and on previous phpwiki's with netscape, but it works. I commited my german translation fixes, but we did it the same time. Can you do a cvs up and rebuild it again, please? -- Reini Urban http://atelier.akbild.ac.at/ (soon) http://xarch.tu-graz.ac.at/home/rurban/ (big) http://tv.mur.at/ (kulturelles) |