I switched my test wiki over to flat file last night while I was trying to
help the guy who lost his data, and noticed that the flat file backend
doesn't issue a warning on every page about storing your data in /tmp
like the DBA backend does---or rather, used to.
A grep over the source tree reveals that the function in WikiDB_dba where the
/tmp warning occurs, genericWarnings(), is never called (unless it's being
called in some non-obvious way, and not explicitly by name). That leads me
to think that this function is cruft, since all other warnings and notices
seem to be issued with trigger_error. Am I right about that? (If so, I'll
fix the error in WikiDB_dba and add one to WikiDB_file.)
I think I understand why we didn't have that warning in the file backend---
anyone who changed the wiki to use flat files would necessarily have had the
/tmp warning in the config file appear on their screen---but it seems like an
easy way to protect from themselves those who neglect to read the instructions.
|
