phpwiki-talk

[Phpwiki-talk] PhpWeather plugin fixes

[Matti A. <ma...@ik...>]

The PhpWeather plugin was a bit outdated. I made it work with the
current CVS version and added some new features.

The patches are attached. The first makes it work with the current CVS
version (and removes support for old versions). The second adds some new
options and features.

The documentation can be pulled out from 

http://mairas.net/wiki/PhpWeatherPlugin

As usual, I only have tested it with my setup and current PHP Weather
nightly.

Cheers,

m.

Re: [Phpwiki-talk] PhpWeather plugin fixes

[Jeff D. <da...@da...>]

On 01 Nov 2002 23:48:01 +0200
Matti Airas <ma...@ik...> wrote:

> The PhpWeather plugin was a bit outdated. I made it work with the
> current CVS version and added some new features.

Reini,

You seem to be the one who wrote the plugin.  Do you have time to
look at Matti's patches anytime soon?  (If not, I can merge them
into the CVS code.)

Do we really want to drop support for older versions of PhpWeather?
(My vote is "yes", but my vote shouldn't count for much since I don't
use PhpWeather...)

Re: [Phpwiki-talk] PhpWeather plugin fixes

[Reini U. <ru...@x-...>]

Jeff Dairiki schrieb:
> On 01 Nov 2002 23:48:01 +0200
> Matti Airas <ma...@ik...> wrote:
> 
> 
>>The PhpWeather plugin was a bit outdated. I made it work with the
>>current CVS version and added some new features.
> 
> Reini,
> 
> You seem to be the one who wrote the plugin.  Do you have time to
> look at Matti's patches anytime soon?  (If not, I can merge them
> into the CVS code.)

I'll do, but give me some time. A week or so.

> Do we really want to drop support for older versions of PhpWeather?
> (My vote is "yes", but my vote shouldn't count for much since I don't
> use PhpWeather...)

Ok. I'll test. When I added support for the old version, the new one 
didn't work good enough for me.
-- 
Reini Urban
http://xarch.tu-graz.ac.at/home/rurban/

Re: [Phpwiki-talk] PhpWeather plugin fixes

[Jeff D. <da...@da...>]

On Sun, 03 Nov 2002 22:53:19 +0100
Martin Geisler <gim...@gi...> wrote:

> >> The PhpWeather plugin was a bit outdated. I made it work with the
> >> current CVS version and added some new features.

I've just checked your changes (and new PhpWeatherPlugin pgsrc) into CVS.

I had to make two small changes (calling conventions of get_languages()
and get_languages_select()) to get it to work with phpweather-2.0.0.

Re: [Phpwiki-talk] PhpWeather plugin fixes

[Martin G. <gim...@gi...>]

Jeff Dairiki <da...@da...> writes:

> On Sun, 03 Nov 2002 22:53:19 +0100
> Martin Geisler <gim...@gi...> wrote:
>
>> >> The PhpWeather plugin was a bit outdated. I made it work with
>> >> the current CVS version and added some new features.
>
> I've just checked your changes (and new PhpWeatherPlugin pgsrc) into
> CVS.

Great, thanks!

> I had to make two small changes (calling conventions of
> get_languages() and get_languages_select()) to get it to work with
> phpweather-2.0.0.

Good catch - those two functions have changed slightly in CVS, but
it's only calling conventions as you note. Oh well, I guess it's time
for another release of PhpWeather...

-- 
Martin Geisler                       My GnuPG Key: 0xF7F6B57B

See http://gimpster.com/ and http://phpweather.net/ for:
PHP Weather => Shows the current weather on your webpage and
PHP Shell   => A telnet-connection (almost :-) in a PHP page.