phpwiki-talk

[Phpwiki-talk] Re: wiki1.1.6 php4 add page fix

[Steve W. <sw...@wc...>]

Thanks Jerry, I'll forward this to Arno, who handles the MySQL support.

sw


On Tue, 27 Jun 2000, Jerry Allen wrote:

> wiki_mysql.php3
> lines 89-92 need enclosing ''
>      $VALUES =  "'$pagehash[author]', '$pagehash[content]', " .
>                  "'$pagehash[created]', '$pagehash[flags]', " .
>                  "'$pagehash[lastmodified]', '$pagehash[pagename]', " .
>                  "'$pagehash[refs]', '$pagehash[version]'";
> 
> 
> -- 
> -- Jerry
> 
> 

...............................ooo0000ooo.................................
   Hear FM quality freeform radio through the Internet: http://wcsb.org/
                     home page: www.wcsb.org/~swain 

Re: [Phpwiki-talk] Re: wiki1.1.6 php4 add page fix

[Arno H. <aho...@in...>]

Hi Jerry,

 > > wiki_mysql.php3
 > > lines 89-92 need enclosing ''
 > >      $VALUES =  "'$pagehash[author]', '$pagehash[content]', " .
 > >                  "'$pagehash[created]', '$pagehash[flags]', " .
 > >                  "'$pagehash[lastmodified]', '$pagehash[pagename]', " .
 > >                  "'$pagehash[refs]', '$pagehash[version]'";

I'm happy to inlcude your fix, although I find it strange that php4
requires this. In php3 everything works fine. I didn't quote
[created], [flags], [lastmodified], and [version] because those are
integer values which need not be quoted.

As I don't have php4 installed yet, could you please add the following
after line 92 to wiki_mysql.php3 and send me the output?

	echo "-- $VALUES --\n";

The output from a fresh install would be most useful.

Thanks
/Arno

Re: [Phpwiki-talk] Re: wiki1.1.6 php4 add page fix

[Steve W. <sw...@wc...>]

Doesn't look like it could have anything to do with magic_quotes_gpc:
http://php.net/manual/configuration.php#ini.magic-quotes-gpc

sw


On Tue, 27 Jun 2000, Arno Hollosi wrote:

> 
> Hi Jerry,
> 
>  > > wiki_mysql.php3
>  > > lines 89-92 need enclosing ''
>  > >      $VALUES =  "'$pagehash[author]', '$pagehash[content]', " .
>  > >                  "'$pagehash[created]', '$pagehash[flags]', " .
>  > >                  "'$pagehash[lastmodified]', '$pagehash[pagename]', " .
>  > >                  "'$pagehash[refs]', '$pagehash[version]'";
> 
> I'm happy to inlcude your fix, although I find it strange that php4
> requires this. In php3 everything works fine. I didn't quote
> [created], [flags], [lastmodified], and [version] because those are
> integer values which need not be quoted.
> 
> As I don't have php4 installed yet, could you please add the following
> after line 92 to wiki_mysql.php3 and send me the output?
> 
> 	echo "-- $VALUES --\n";
> 
> The output from a fresh install would be most useful.
> 
> Thanks
> /Arno
> 
> _______________________________________________
> Phpwiki-talk mailing list
> Php...@li...
> http://lists.sourceforge.net/mailman/listinfo/phpwiki-talk
> 

...............................ooo0000ooo.................................
   Hear FM quality freeform radio through the Internet: http://wcsb.org/
                     home page: www.wcsb.org/~swain 

Re: [Phpwiki-talk] wiki1.1.6b

[Arno H. <aho...@in...>]

Hi,

I fixed Jerry's bug and found an even more embarrasing bug as well.
(I suggest you make this change on sourceforge's wiki):

There's a typo in wiki_stdlib.php3 which prevents switching to a
new date in RecentChanges. Change line 259 
   from       global $dateformst;
   to         global $dateformat;

I guess we should test our next release a little bit better.

I shall punish myself now.

/Arno

Re: [Phpwiki-talk] wiki1.1.6b

[Steve W. <sw...@wc...>]

Nah, nothing is going to top my releasing a new version with my personal
config file. Whenever you feel really bad just point at me and laugh. :-)

sw

On Tue, 27 Jun 2000, Arno Hollosi wrote:

> 
> Hi,
> 
> I fixed Jerry's bug and found an even more embarrasing bug as well.
> (I suggest you make this change on sourceforge's wiki):
> 
> There's a typo in wiki_stdlib.php3 which prevents switching to a
> new date in RecentChanges. Change line 259 
>    from       global $dateformst;
>    to         global $dateformat;
> 
> I guess we should test our next release a little bit better.
> 
> I shall punish myself now.
> 
> /Arno
> 
> _______________________________________________
> Phpwiki-talk mailing list
> Php...@li...
> http://lists.sourceforge.net/mailman/listinfo/phpwiki-talk
> 

...............................ooo0000ooo.................................
   Hear FM quality freeform radio through the Internet: http://wcsb.org/
                     home page: www.wcsb.org/~swain