phpwiki-talk

[Phpwiki-talk] 1.1.6 up

[Steve W. <sw...@wc...>]

Well, 1.1.6 was released last night; today it got posted on freshmeat.net
as well, so for the day I have to babysit FrontPage on
phpwiki.sourceforge.net because people occasionally edit it.

I had to disable part of the [more info] page so it would not render the
source of the page; it turns out this would allow people to render HTML
since it goes through unchecked. A simple patch would be to do a s/// for
<, > and &.

You can see a DBM-based copy at http://phpwiki.sourceforge.net/1.1.6/. I
haven't looked at the bug in RecentChanges yet, speaking of which:

I know some time ago, very early in the development of 1.1, I rewrote
UpdateRecentChanges so it listed the pages newest-first instead of putting
the newest at the bottom. I wonder what happened to this change? I don't
know if I have a copy of it still.

The mSQL support: I started on this because the web server I co-admin,
wcsb.org, has mSQL running on it. It turns out to be much harder to port
to mSQL than Postgresql (which was quite easy) because the TEXT data type,
which can take any amount of text but cannot be used in LIKE clauses. This
gave me endless headaches all weekend.

I don't want to limit pages to lengths of 1,000 or 10,000 chars, so after
trying two approaches that were dead ends, I decided on putting the pages
in a separate table. The page content would be divided up into lines of 80
chars in length, and the white space would be preserved. This was tricky
to code but last night I finally got it almost right (two bugs to address
still). This approach will be very space efficient (for mSQL at least ;-)

I think the next thing to work on is the HitCount. It should be
straightforward to add to PhpWiki. Do we want to include it at the bottom
of each page? Also, "version" provides a way to count how many times a
page was edited. Do we want to add this info to the bottom of the page
too, or leave it in [more info] ?

sw

...............................ooo0000ooo.................................
   Hear FM quality freeform radio through the Internet: http://wcsb.org/
                     home page: www.wcsb.org/~swain 

Re: [Phpwiki-talk] 1.1.6 up

[Arno H. <aho...@in...>]

Steve,

just checking out 1.1.6.

Two things:

- why is test2.php3 in 1.1.6?

- phpwiki no longer runs out of the box, due to a config error.
  offending lines:

  $ServerAddress = "http://127.0.0.1:8080/phpwiki/";
  and
  /*
   if (preg_match("#(.*?)([^/]*$)#", $REQUEST_URI, $matches)) {
      $ServerAddress = "http://$SERVER_NAME:$SERVER_PORT" . $matches[1];
   } else {
      $ServerAddress = "http://$SERVER_NAME:$SERVER_PORT$REQUEST_URI";
   }
  */

  the first should be commented out, the second should be default.
  (no not everyone has a webserver running localhost:8080 ;o)

  Also, the comment doesn't make sense:
  // You should set the $ServerAddress as below, and comment out
  // the if/else below.
  "and" should be "or"

 > A simple patch would be to do a s/// for
 > <, > and &.

 Or htmlspecialchars() the whole thing

 > I know some time ago, very early in the development of 1.1, I rewrote
 > UpdateRecentChanges so it listed the pages newest-first instead of putting
 > the newest at the bottom. I wonder what happened to this change? I don't
 > know if I have a copy of it still.

I never touched it - apart from fixing some bugs.
I'll try to find out what's wrong.

 > I think the next thing to work on is the HitCount. It should be
 > straightforward to add to PhpWiki. Do we want to include it at the bottom
 > of each page? Also, "version" provides a way to count how many times a
 > page was edited. Do we want to add this info to the bottom of the page
 > too, or leave it in [more info] ?

We can use placeholders, so wiki-admins can decide themselves.
There's already a ###VERSION### placeholder if memory serves right.

/Arno

Re: [Phpwiki-talk] 1.1.6 up

[Arno H. <aho...@in...>]

Replying to myself:

 >  > I know some time ago, very early in the development of 1.1, I rewrote
 >  > UpdateRecentChanges so it listed the pages newest-first

the error is in the way UpdateRecentChanges checks for the current
date: it looks for a date string!

But as of 1.1.6 there's no date in RecentChanges - it now reads
"Day one (Wiki's birthday)"

I fixed it for the installed version on sourceforge by simply adding a 
date to RecentChanges.

Maybe we should put up a "KnownBugs" in one of the wikis at
sourceforge and link from it form the Homepage?

The check in RecentChanges is broken anyway.
Users can now choose their own dateformat. Then the preg_match will
fail anyway.

Instead I suggest to use some kind of markup, like bold.
Actually, I'm going to do this right now.

/Arno

Re: [Phpwiki-talk] 1.1.6 up

[Steve W. <sw...@wc...>]

What would I do without you? :-)

sw

On Mon, 26 Jun 2000, Arno Hollosi wrote:

> 
> Replying to myself:
> 
>  >  > I know some time ago, very early in the development of 1.1, I rewrote
>  >  > UpdateRecentChanges so it listed the pages newest-first
> 
> the error is in the way UpdateRecentChanges checks for the current
> date: it looks for a date string!
> 
> But as of 1.1.6 there's no date in RecentChanges - it now reads
> "Day one (Wiki's birthday)"
> 
> I fixed it for the installed version on sourceforge by simply adding a 
> date to RecentChanges.
> 
> Maybe we should put up a "KnownBugs" in one of the wikis at
> sourceforge and link from it form the Homepage?
> 
> The check in RecentChanges is broken anyway.
> Users can now choose their own dateformat. Then the preg_match will
> fail anyway.
> 
> Instead I suggest to use some kind of markup, like bold.
> Actually, I'm going to do this right now.
> 
> /Arno
> 
> _______________________________________________
> Phpwiki-talk mailing list
> Php...@li...
> http://lists.sourceforge.net/mailman/listinfo/phpwiki-talk
> 

...............................ooo0000ooo.................................
   Hear FM quality freeform radio through the Internet: http://wcsb.org/
                     home page: www.wcsb.org/~swain 

[Phpwiki-talk] hitcount & other changes

[Arno H. <aho...@in...>]

Hi again,

last email for today :o)

changes I just uploaded:

- RecentChanges fix - dates are prefixed with "____"

- renamed [Search] and [Fullsearch] markup to %%Search%% and %%Fullsearch%%

- quick hack for hitcount support:

	- added ###HITS### placeholder
	- added %%Mostpopular%% markup
	- added following functions to mySQL
		GetHitCount($dbi, $pagename)
		IncreaseHitCount($dbi, $pagename)
		InitMostPopular($dbi, $limit) ... init search
		MostPopularNextMatch($dbi, $res) ... do search

This *breaks* dbm, pgsql, msql as those functions are not defined there yet.
Also, I've completely omitted the pesky issue of how to address the
hitcount table. In the current scheme, we would need to do a
OpenDateBase() etc. Also, there should be a define for the number of
pages returned for %%Mostpopular%% - actually I'd like to see a markup 
like %%100Mostpopular%% where 100 may be substituted by any number.
A regexp could pick the number and use it as limit. But I'm too lazy
right now.

The db interface for hitcount is of course open to discussion.
This is just a quick hack.


Steve,

if you uploaded a fixed version of 1.1.6, then don't use the latest
CVS. Reason above. Also, you could remove those CVS/ directories from
the tarball as well - must have been very late that night, no? ;o)

/Arno

Re: [Phpwiki-talk] 1.1.6 up

[Steve W. <sw...@wc...>]

On Mon, 26 Jun 2000, Arno Hollosi wrote:

> - why is test2.php3 in 1.1.6?

I should have left that out, but I was tired and it was late. I don't
think it will hurt anything.
 
> - phpwiki no longer runs out of the box, due to a config error.
>   offending lines:
> 
>   the first should be commented out, the second should be default.
>   (no not everyone has a webserver running localhost:8080 ;o)

DOH! 

I haven't found a way around this without hand-editing the file each
time. :-/

I'll upload a new copy of 1.1.6 (or 1.1.7?) when I get home, to correct
this.

>   Also, the comment doesn't make sense:
>   // You should set the $ServerAddress as below, and comment out
>   // the if/else below.
>   "and" should be "or"

No, it's just poorly worded... it should read: You should set
$ServerAddress and comment out the following if/else statement.




...............................ooo0000ooo.................................
   Hear FM quality freeform radio through the Internet: http://wcsb.org/
                     home page: www.wcsb.org/~swain