phpwiki-talk

[Phpwiki-talk] non breaking spaces added at the top of the pages ...

[Arnaud F. <ar...@cr...>]

Hi all,

On a wiki running PhpWiki 1.3.6, I've a nice little bug :

On some nodes (not all) the diff action adds some nbsp at the very
beginning of the generated html page.

I first thought it was a problem with the theme I write but it's the
same with "default".

More : the number of nbsp is not always the same depending of the page.

Have a look at http://innovation.crao.net/index.php/Accueil?action=diff


Any clue ?

-- 
Arnaud Fontaine
Jabber: sh...@ra...
ICQ: 3504789

Re: [Phpwiki-talk] non breaking spaces added at the top of the pages ...

[Arnaud F. <ar...@cr...>]

Le lun 08/12/2003 =E0 10:57, Arnaud Fontaine a =E9crit :
> On a wiki running PhpWiki 1.3.6, I've a nice little bug :
>=20
> On some nodes (not all) the diff action adds some nbsp at the very
> beginning of the generated html page.
>=20
> I first thought it was a problem with the theme I write but it's the
> same with "default".
>=20
> More : the number of nbsp is not always the same depending of the page.
>=20
> Have a look at http://innovation.crao.net/index.php/Accueil?action=3Ddiff

It seems no one is interested in this bug ... bug when I check the
source code of this page, it starts by :

            &nb=
sp;&nbsp;<?xml version=3D"1.0" encoding=3D"iso-8859-1"?>

This makes the page not a valid xml page ... and breaks some browsers.
--=20
Arnaud Fontaine
Jabber: sh...@ra...
ICQ: 3504789

Re: [Phpwiki-talk] non breaking spaces added at the top of the pages ...

[Carsten K. <car...@us...>]

On Thursday, December 11, 2003, at 03:15  pm, Arnaud Fontaine wrote:

> Le lun 08/12/2003 =E0 10:57, Arnaud Fontaine a =E9crit :
>> On a wiki running PhpWiki 1.3.6, I've a nice little bug :
>>
>> On some nodes (not all) the diff action adds some nbsp at the very
>> beginning of the generated html page.
>>
>> I first thought it was a problem with the theme I write but it's the
>> same with "default".
>>
>> More : the number of nbsp is not always the same depending of the =20
>> page.
>>
>> Have a look at =20
>> http://innovation.crao.net/index.php/Accueil?action=3Ddiff
>
> It seems no one is interested in this bug ... bug when I check the
> source code of this page, it starts by :
>
> =
           &nbsp=20=

> ;&nbsp;&nbsp;<?xml version=3D"1.0" encoding=3D"iso-8859-1"?>
>
> This makes the page not a valid xml page ... and breaks some browsers.
> --=20
> Arnaud Fontaine
> Jabber: sh...@ra...
> ICQ: 3504789

Hi,
I already found the bug in lib/diff.php but there are a few other =20
changes I would like make in there before I commit a proper repair to =20=

CVS. Here's a patch as a temporary workaround:

Index: diff.php
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
RCS file: /cvsroot/phpwiki/phpwiki/lib/diff.php,v
retrieving revision 1.44
diff -U2 -r1.44 diff.php
--- diff.php    17 Feb 2003 02:17:31 -0000      1.44
+++ diff.php    11 Dec 2003 20:46:39 -0000
@@ -49,5 +49,5 @@
                  continue;
              if ($word[0] =3D=3D "\n") {
-                $this->_group .=3D PrintXML(HTML::raw('&nbsp;'));
+                $this->_group .=3D " "; //new RawXml('&nbsp;'); =
//FIXME: =20
asXML(HTML::raw('&nbsp;')) ???
                  $this->_flushLine($tag);
                  $word =3D substr($word, 1);

Re: [Phpwiki-talk] non breaking spaces added at the top of the pages ...

[Arnaud F. <ar...@cr...>]

Le jeu 11/12/2003 =E0 21:51, Carsten Klapp a =E9crit :
> I already found the bug in lib/diff.php but there are a few other =20
> changes I would like make in there before I commit a proper repair to =20
> CVS. Here's a patch as a temporary workaround:
>=20
> Index: diff.php
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> RCS file: /cvsroot/phpwiki/phpwiki/lib/diff.php,v
> retrieving revision 1.44
> diff -U2 -r1.44 diff.php
> --- diff.php    17 Feb 2003 02:17:31 -0000      1.44
> +++ diff.php    11 Dec 2003 20:46:39 -0000
> @@ -49,5 +49,5 @@
>                   continue;
>               if ($word[0] =3D=3D "\n") {
> -                $this->_group .=3D PrintXML(HTML::raw(' '));
> +                $this->_group .=3D " "; //new RawXml(' '); //FIXME:=
 =20
> asXML(HTML::raw(' ')) ???
>                   $this->_flushLine($tag);
>                   $word =3D substr($word, 1);

It seems to work.
I just didn't understand why this happened there in the code ... ;)

And maybe you're aware of the second big bug of all versions post 1.3.4:
RSS is working strangely.
If I try to open the RecentChanges rss feed, I got an empty doc in
mozilla (or any geko based browser).
Straw got also an empty document when fetching the rss.
But wget got a valid rss document ...
(oh ... it doesn't come from the theme. And I have the Fr_fr locale set.
I tried with a dba based wiki and a mysql based wiki)

I wrote a rss reader plugin for phpwiki. When I check the rss feed, it
works but the modified date seems buggy ...
The rss also works in Evolution.

The first time I talked about this bug on the list, someone sent me to
his own wiki running the same version as me : the rss was working fine.

Strange behaviour.

--=20
Arnaud Fontaine
Jabber: sh...@ra...
ICQ: 3504789