phpwiki-talk

[Phpwiki-talk] Modularization of transform.php

[Arno H. <aho...@xm...>]

I had an afternoon at my hands, so I redid transform.php.

Transform functions are now modularized and registered to a central
WikiTransform object.

I think the current design is straight forward, easy to comprehend, and=20
thus easy to extend.

Things to be done:
- re-add html mode "|"
- provide functionality for multi-line markup (i.e. markup spanning sever=
al
  lines)
- redo %%ADMIN-%% tokens -- see my previous email "system page" (Jan 25)

I'd like to hear some feedback -- is the current form ok?

Note that recursive calls (nesting markup) are not possible. It would=20
unnecessarily complicate the issue. Instead, I suggest that if you'd like=
=20
to do markup-transformation inside another markup you just register anoth=
er=20
WikiTransform object and call that one with your markup data.

/Arno

Re: [Phpwiki-talk] Modularization of transform.php

[Steve W. <sw...@wc...>]

On Sun, 4 Feb 2001, Arno Hollosi wrote:

> I had an afternoon at my hands, so I redid transform.php.
> 
> Transform functions are now modularized and registered to a central
> WikiTransform object.
> 
> I think the current design is straight forward, easy to comprehend, and 
> thus easy to extend.
> 
> Things to be done:
> - re-add html mode "|"
> - provide functionality for multi-line markup (i.e. markup spanning several
>   lines)
> - redo %%ADMIN-%% tokens -- see my previous email "system page" (Jan 25)
> 
> I'd like to hear some feedback -- is the current form ok?

I spent some time reading this, and all I can say is wow! Great work! It
was immediately understandable, incredibly clearly written, and very
clean.

> Note that recursive calls (nesting markup) are not possible. It would 
> unnecessarily complicate the issue. Instead, I suggest that if you'd like 
> to do markup-transformation inside another markup you just register another 
> WikiTransform object and call that one with your markup data.

Hmm. I don't quite understand. Can you give an example of nesting markup?
The TestPage looks fine, so we must not have an example there?

~swain

...............................ooo0000ooo.................................
   Hear FM quality freeform radio through the Internet: http://wcsb.org/
                     home page: www.wcsb.org/~swain 

Re: [Phpwiki-talk] Modularization of transform.php

[Arno H. <aho...@xm...>]

> > - redo %%ADMIN-%% tokens -- see my previous email "system page" (Jan =
25)

Is that change ok? (I've not yet written it). Short: mixture mode which=20
allows html mixed with template placeholders and wiki markup.


> > Note that recursive calls (nesting markup) are not possible.
> Hmm. I don't quite understand. Can you give an example of nesting marku=
p?
> The TestPage looks fine, so we must not have an example there?

Right now we don't have nested markup. A simple (senseless) example is
bold&italic markup inside bracketlinks, e.g. [__bold text for__|BoldPage]
I guess nested markup is only interesting if phpwiki allows
multi-line markup. Then we have one markup (multi-line) which may contain=
=20
other markup (bold, lists, links, ...) So my suggestion was: the multilin=
e=20
markup should then just register another transformer object and do=20
do_transform() with its contained wiki data.

/Arno

Re: [Phpwiki-talk] Modularization of transform.php

[Steve W. <sw...@wc...>]

On Tue, 6 Feb 2001, Arno Hollosi wrote:

> 
> > > - redo %%ADMIN-%% tokens -- see my previous email "system page" (Jan 25)
> 
> Is that change ok? (I've not yet written it). Short: mixture mode which 
> allows html mixed with template placeholders and wiki markup.

I haven't looked into this yet but I still have your email. I'll check it
later...

> Right now we don't have nested markup. A simple (senseless) example is
> bold&italic markup inside bracketlinks, e.g. [__bold text for__|BoldPage]
> I guess nested markup is only interesting if phpwiki allows
> multi-line markup. Then we have one markup (multi-line) which may contain 
> other markup (bold, lists, links, ...) So my suggestion was: the multiline 
> markup should then just register another transformer object and do 
> do_transform() with its contained wiki data.

That sounds fine... I wonder, what if we stopped doing line by line
processing? Wouldn't we gain something from that? Or would it be too hard?
For example, tokenize the entire page and process it (via recursive
descent parsing or something similar).

~swain


...............................ooo0000ooo.................................
   Hear FM quality freeform radio through the Internet: http://wcsb.org/
                     home page: www.wcsb.org/~swain