phpwiki-talk

[Phpwiki-talk] Patch for warnings

[Cameron B. <ga...@in...>]

These diff's removed 3 warnings on my phpWiki setup. I dont know if the 
request patch is as good as it could be but I could not find anywhere 
else that called the second function that I cleaned up so I assumed on 
the input. Hopefully I was right.

That said, I have 1 more warning, here it is below,

In template 'head'(In template 'html'?):58: Notice[8]: Use of undefined 
constant RECENT_CHANGES - assumed 'RECENT_CHANGES':

    * <link rel="alternate" type="application/rss+xml" title="RSS"
      href="<?=WikiURL(RECENT_CHANGES, array('format' => 'rss'))?>" />

turns out the configurator's config doesnt seem to contain

if (!defined('RECENT_CHANGES')) define ('RECENT_CHANGES', 'RecentChanges');

and also the template doesnt do a defined (tho i assume that should be 
assumed).

So far so good, only remaining bug I know of is the cgi php errors.


Cameron Brunner
inetsalestech.com

Re: [Phpwiki-talk] Patch for warnings

[Jeff D. <da...@da...>]

On Tue, 04 Mar 2003 20:03:02 +1000
Cameron Brunner <ga...@in...> wrote:

> These diff's removed 3 warnings on my phpWiki setup.
> 
> turns out the configurator's config doesnt seem to contain
> 
> if (!defined('RECENT_CHANGES')) define ('RECENT_CHANGES',
> 'RecentChanges');


The configurator script is not kept as up-to-date as might be desirable.

(When in doubt, the distributed index.php is still the authoritative
source for configuration information.)

(Joby's working on a new scripted configuration system that will
(when it works) probably replace index.php.)


I'll go stick RECENT_CHANGES, and the CACHE_CONTROL defines
into either the configurator script or lib/config.php right now...

Does anybody know of any others that are missing?

Re: [Phpwiki-talk] Patch for warnings

[Jeff D. <da...@da...>]

Hi Andrey

> does it possible to replace index.php:544 line
> define("CHARSET", "iso-8859-1");
> with the
> if (defined("CHARSET")) define("CHARSET", "iso-8859-1");
> ?

Okay, done.

> And would be great to have possibility to override
> COMPRESS_OUTPUT variable and $DBParams array.

COMPRESS_OUTPUT is commented out in the distributed index.php,
so if you want to define it in your custom configu file, there
should be no problem.  (Note that the default behavior can
only be obtained by leaving COMPRESS_OUTPUT undefined.)


As for DBParams, I'd rather not add that logic/clutter
to index.php right now.  (Joby Walker is working on a whole
new configuration scheme which should make the kind of customization
you're doing easier.)

> (I may post this to 'feature request' form, but my English is too poor
> :(

Your English is just fine!

Jeff

RE: [sf] Re: [Phpwiki-talk] Patch for warnings

[Andrey C. <an...@ch...>]

> > if (defined("CHARSET")) define("CHARSET", "iso-8859-1");
> Okay, done.

Thank you! There is my mistake - "defined" instead of "!defined".

Next issue. I'm using PhpWiki under Windows 2000 more than year,
and in each PhpWiki version I'm forced to change the default
date/time format, because defaults
  $Theme->setDateFormat("%A, %B %e, %Y");
  $Theme->setTimeFormat("%l:%M:%S %p");
not working under Windows:
%e not prints day of month, and %l prints nothing (%l is not
documented in PHP at all). So, date/time show like this:
Last edited on Friday, March , 2003 :38:13 pm.
(PHP4.3.1/Windows2000/English)
See notes in http://www.php.net/manual/ru/function.strftime.php :
Not all conversion specifiers may be supported by your C library, in which
case they will not be supported by PHP's strftime(). This means that e.g.
%e, %T, %R and %D (there might be more) will not work on Windows.

Re: [sf] Re: [Phpwiki-talk] Patch for warnings

[Carsten K. <car...@ya...>]

Hi Andrey,

Sorry for the delay in replying.

* Actually, I made a mistake: there really should be an "!" in there:
  if (!defined("CHARSET")) define("CHARSET", "iso-8859-1");
If you have heavily modified your PhpWiki's index.php, it would be a 
good idea to make sure that CHARSET is also not being defined anywhere 
else.

Sorry if this caused any confusion.

Would you send me the date/time format string you hopefully figured out 
for your own windows server? :) I will try to somehow, automatically 
integrate it into PhpWiki.

Cheers,
Carsten

On Monday, March 10, 2003, at 07:37  am, Andrey Cherezov wrote:

>>> if (defined("CHARSET")) define("CHARSET", "iso-8859-1");
>> Okay, done.
>
> Thank you! There is my mistake - "defined" instead of "!defined".
>
> Next issue. I'm using PhpWiki under Windows 2000 more than year,
> and in each PhpWiki version I'm forced to change the default
> date/time format, because defaults
>   $Theme->setDateFormat("%A, %B %e, %Y");
>   $Theme->setTimeFormat("%l:%M:%S %p");
> not working under Windows:
> %e not prints day of month, and %l prints nothing (%l is not
> documented in PHP at all). So, date/time show like this:
> Last edited on Friday, March , 2003 :38:13 pm.
> (PHP4.3.1/Windows2000/English)
> See notes in http://www.php.net/manual/ru/function.strftime.php :
> Not all conversion specifiers may be supported by your C library, in 
> which
> case they will not be supported by PHP's strftime(). This means that 
> e.g.
> %e, %T, %R and %D (there might be more) will not work on Windows.
>
>
>
>
> -------------------------------------------------------
> This sf.net email is sponsored by:ThinkGeek
> Welcome to geek heaven.
> http://thinkgeek.com/sf
> _______________________________________________
> Phpwiki-talk mailing list
> Php...@li...
> https://lists.sourceforge.net/lists/listinfo/phpwiki-talk
>

RE: [sf] Re: [Phpwiki-talk] Patch for warnings

[Andrey C. <an...@ch...>]

> Would you send me the date/time format string you hopefully
> figured out
> for your own windows server? :) I will try to somehow, automatically
> integrate it into PhpWiki.

I'm using this format on the Windows server:
$Theme->setDateFormat("%d.%m.%Y");
$Theme->setTimeFormat("%H:%M:%S");

> > date/time format, because defaults
> >   $Theme->setDateFormat("%A, %B %e, %Y");
> >   $Theme->setTimeFormat("%l:%M:%S %p");
> > not working under Windows:
> > %e not prints day of month, and %l prints nothing (%l is not
> > documented in PHP at all). So, date/time show like this:
> > Last edited on Friday, March , 2003 :38:13 pm.
> > (PHP4.3.1/Windows2000/English)
> > See notes in http://www.php.net/manual/ru/function.strftime.php :
> > Not all conversion specifiers may be supported by your C
> library, in
> > which
> > case they will not be supported by PHP's strftime(). This
> means that
> > e.g.
> > %e, %T, %R and %D (there might be more) will not work on Windows.

Re: [work] Re: [sf] Re: [Phpwiki-talk] Patch for warnings

[Stanislaw B. <sb...@po...>]

I had this issue with my first installation of PhpWiki (Win2000, eng, 
PHP 4.3.2, PhpWiki  1.3.3).  And I had to do modify formatDate function 
to get the day displayed.  However, the second and 3rd installations, 
(similar environment but PhpWiki 1.3.4) didn't have this problem.

Stan Berka

 >>>>>
On Monday, March 10, 2003, at 07:37  am, Andrey Cherezov wrote:

Next issue. I'm using PhpWiki under Windows 2000 more than year,
and in each PhpWiki version I'm forced to change the default
date/time format, because defaults
  $Theme->setDateFormat("%A, %B %e, %Y");
  $Theme->setTimeFormat("%l:%M:%S %p");
not working under Windows:
%e not prints day of month, and %l prints nothing (%l is not
documented in PHP at all). So, date/time show like this:
Last edited on Friday, March , 2003 :38:13 pm.
(PHP4.3.1/Windows2000/English)