phpwiki-talk

[Phpwiki-talk] another phpwiki 1.1.8 proposed change (fwd)

[Steve W. <sw...@wc...>]

...............................ooo0000ooo.................................
   Hear FM quality freeform radio through the Internet: http://wcsb.org/
                     home page: www.wcsb.org/~swain 

---------- Forwarded message ----------
Date: Tue, 31 Oct 2000 21:43:09 +0200
From: Ori Folger <or...@co...>
To: Steve Wainstead <sw...@wc...>
Subject: another phpwiki 1.1.8 proposed change

Hi

On my system I have PHP set to show non-critical warning, like referring to
a variable before defining its value.

phpwiki emits a lot of these.

The following line turns off these non-critical warnings:

ini_set("error_reporting", ini_get("error_reporting") & 2039);

It should be line 10 of index.php.

It is also php4 specific.

Ori Folger

Re: [Phpwiki-talk] another phpwiki 1.1.8 proposed change

[Arno H. <aho...@in...>]

> On my system I have PHP set to show non-critical warning, like referring to
> a variable before defining its value.
> phpwiki emits a lot of these.

I think it's better to remove the cause of these notices, instead of just 
suppressing them. Thus I fixed 99.9% of those warnings just now.
Actually this revealed some serious errors, like e.g. $FieldSeparator not 
defined as "global" in some functions, or e.g. dbm not closing the dbm-files.

> ini_set("error_reporting", ini_get("error_reporting") & 2039);
> It is also php4 specific.

I added "error_reporting(E_ALL ^ E_NOTICE)" to index.php which is useable for 
both php3 and php4.

I suggest that everyone on this list removes "^ E_NOTICE" when testing 
phpwiki.


> I'd like to suggest that on lines 30 and 33 of lib/config.php $REQUEST_URI
> be replaced with $SCRIPT_NAME. The REQUEST_URI environment variable is

Done.

/Arno