From: Steven M. <st...@mu...> - 2001-10-21 21:14:47
Attachments:
pageinfo.diff
stdlib.diff
|
Hi All, I've been having fun playing with the new features the alpha version gives, and it has mostly worked well. I have had a couple of problems, which I will explain here in the hope that it will help anyone else who is having the same problems. The first happens when the "History" of a page is requested in order to perform a diff. The pageinfo.php file is used, however when the diff is requested, a diff on HomePage is performed regardless of the page whose History is being displayed. This seems to be due to the pageinfo page not including a pagename field. This problem could occur because I have set USE_PATH_INFO to be false. The attached patch adds a pagename field to pageinfo, and while it might not be the correct solution it at least seems to work on my installation. Often when a diff is requested on a page with many revisions, and is performed on the HomePage (which has few revisions), a revision cannot be retried, which causes another problem. If diff cannot find a revision the NoSuchRevision() function in stdlib.php is called, which in turn calls GeneratePage(). However GeneratePage() is not defined and a error message is displayed. The GeneratePage() function of relevance seems to be defined in Template.php so the attached patch includes this file. Once again this might not be the best way to do it since I am not familiar with PHP in general nor PHPWiki in particular, but it works for me. I have posted bug reports about these problems on Sourceforge too. Hope this helps, Steven Murdoch. |
From: Pablo R. <pr...@cl...> - 2001-10-24 09:50:50
|
Hi, -How far are we from a new release? (Perhaps phpwiki 1.3) -Does the Jeff hack will be the next phpwiki?, cause I see at: http://phpwiki.sourceforge.net/phpwiki/ that is the previous version And some things more: Bug #468595, is very easy to solve, just commit as binary. Saludos, Pablo Roca - MS VFP - MVP La Coru=F1a - Espa=F1a Sysop del Portal gratuito de Visualfoxpro en Espa=F1ol http://www.portalfox.com |
From: Pablo R. <pr...@cl...> - 2001-10-24 11:26:22
|
I downloaded the latest CVS, but I don't know how to fill the $DBParams. I'm using MySQL, my data is: User: root withouh password Database: dbwiki so I assume this in index.php would work .. $DBParams =3D array( // Select the database type: 'dbtype' =3D> 'SQL', //'dbtype' =3D> 'dba', =20 // For SQL based backends, specify the database as a DSN // The most general form of a DSN looks like: // // phptype(dbsyntax)://username:password@protocol+hostspec/database // // For a MySQL database, the following should work: // // mysql://user:password@host/databasename // // FIXME: My version Pear::DB seems to be broken enough that there is // no way to connect to a mysql server over a socket right now. //'dsn' =3D> 'mysql://guest@:/var/lib/mysql/mysql.sock/test', 'dsn' =3D> 'mysql://root@localhost/dbwiki', //'dsn' =3D> 'pgsql://localhost/test', =20 // Used by all DB types: // prefix for filenames or table names /*=20 * currently you MUST EDIT THE SQL file too (in the schemas/ directory * because we aren't doing on the fly sql generation during the * installation. */ //'prefix' =3D> 'phpwiki_', =20 // Used by 'dba' 'directory' =3D> "/tmp", 'dba_handler' =3D> 'gdbm', // Either of 'gdbm' or 'db2' work great for me. //'dba_handler' =3D> 'db2', //'dba_handler' =3D> 'db3', // doesn't work at all for me.... 'timeout' =3D> 20, //'timeout' =3D> 5 ); But don't. I'm using this with: Local network Windows 2000 Server Nusphere 1.3.11 for Windows Any cue? Regards, Pablo Roca - MS VFP - MVP La Coru=F1a - Espa=F1a Sysop del Portal gratuito de Visualfoxpro en Espa=F1ol http://www.portalfox.com |
From: Steve W. <sw...@pa...> - 2001-10-27 16:42:40
|
On Wed, 24 Oct 2001, Pablo Roca wrote: > I downloaded the latest CVS, but I don't know how to fill the $DBParams. [...] > 'dsn' =3D> 'mysql://root@localhost/dbwiki', Maybe when you don't use a password you still need a colon (:) after root? i.e. mysql://root:@localhost/dbwiki Otherwise yours looks identical to the alpha site's config file. ~swain > > // Used by all DB types: > > // prefix for filenames or table names > /* > * currently you MUST EDIT THE SQL file too (in the schemas/ > directory > * because we aren't doing on the fly sql generation during the > * installation. > */ > //'prefix' =3D> 'phpwiki_', > > // Used by 'dba' > 'directory' =3D> "/tmp", > 'dba_handler' =3D> 'gdbm', // Either of 'gdbm' or 'db2' work great > for me. > //'dba_handler' =3D> 'db2', > //'dba_handler' =3D> 'db3', // doesn't work at all for me.... > 'timeout' =3D> 20, > //'timeout' =3D> 5 > ); > > But don't. > > I'm using this with: > > Local network > Windows 2000 Server > Nusphere 1.3.11 for Windows > > Any cue? > > Regards, > > Pablo Roca - MS VFP - MVP > La Coru=F1a - Espa=F1a > Sysop del Portal gratuito de Visualfoxpro en Espa=F1ol > http://www.portalfox.com > > > _______________________________________________ > Phpwiki-talk mailing list > Php...@li... > https://lists.sourceforge.net/lists/listinfo/phpwiki-talk > --- http://www.panix.com/~swain/ "Without music to decorate it, time is just a bunch of boring production deadlines or dates by which bills must be paid." -- Frank Zappa |
From: Steve W. <sw...@pa...> - 2001-10-27 16:36:47
|
I'm in Florida again until Tuesday, but I promise two things: versions 1.2.1 and 1.3.1. The development branch has some minor bugs but I think it's suitable for an alpha release (maybe even early beta?) We might attract some patches this way. Yes, Jeff's hacks will be the 1.3 release. Look for the releases October 31st. Boo! Scary! If you have some work you need to commit, please do so as soon as possible. el jefe ~swain On Wed, 24 Oct 2001, Pablo Roca wrote: > Hi, > > -How far are we from a new release? (Perhaps phpwiki 1.3) > -Does the Jeff hack will be the next phpwiki?, cause I see at: > http://phpwiki.sourceforge.net/phpwiki/ that is the previous version > > And some things more: > > Bug #468595, is very easy to solve, just commit as binary. > > > Saludos, > > Pablo Roca - MS VFP - MVP > La Coru=F1a - Espa=F1a > Sysop del Portal gratuito de Visualfoxpro en Espa=F1ol > http://www.portalfox.com > > > _______________________________________________ > Phpwiki-talk mailing list > Php...@li... > https://lists.sourceforge.net/lists/listinfo/phpwiki-talk > --- http://www.panix.com/~swain/ "Without music to decorate it, time is just a bunch of boring production deadlines or dates by which bills must be paid." -- Frank Zappa |
From: Gary B. <ga...@in...> - 2001-10-27 18:22:22
|
On Sat, 27 Oct 2001, Steve Wainstead wrote: > I'm in Florida again until Tuesday, but I promise two things: versions > 1.2.1 and 1.3.1. The development branch has some minor bugs but I think > it's suitable for an alpha release (maybe even early beta?) We might > attract some patches this way. Yes, Jeff's hacks will be the 1.3 release. Excellent! I was hoping you'd release something soon, because anyone looking at the project page might think it was moribund. One of the things that swayed me towards PhpWiki in the first place was that it looked like it was under active development. > If you have some work you need to commit, please do so as soon as > possible. Well, I just committed a quick-and-dirty email notification patch to the patch manager, but I don't know if it will be of any use. It only emails one person, whose address is hardwired in, but you could perhaps do something with it. I wrote it so I didn't have to keep looking at the RecentChanges on the GtmWiki. Later, Gary PS. the emails it sends look like this: | Date: Sat, 27 Oct 2001 19:19:43 +0100 (BST) | From: GtmWiki <gt...@in...> | To: Gary Benson <ga...@in...> | Subject: Re: edit: GtmHistory | | Modified: GtmHistory | URL: http://inauspicious.org/gtmwiki/?GtmHistory | Author: GaryBenson | | =================================================================== | diff -u -r8 -r9 | --- /tmp/gtmwiki-GtmHistory.8 Sat Oct 27 19:01:00 2001 | +++ /tmp/gtmwiki-GtmHistory.9 Sat Oct 27 19:01:00 2001 | @@ -1,5 +1,5 @@ | This page needs to be written. In the meantime look or http://www.gtmcars.co.uk/gtm_history.htm and http://www.ijohnson.demon.co.uk/gtmoc/gtmhist.htm. | | -I'll probably split this up into separate pages for the GtmCoupe, the GtmRossa, the [GtmRossaK3] and the GtmLibra. | +I'll probably split it up into separate pages for the GtmCoupe, the GtmRossa, the [GtmRossaK3] and the GtmLibra unless anyone has any better ideas. Note to self: get permission to use the stuff from GtmCars's website. | | -- GaryBenson |
From: Steve W. <sw...@pa...> - 2001-11-07 04:23:49
|
Hi Gary, I didn't put this patch into the 1.2.1 release because of the dependencies on diff and Unix. I guess I'm starting to become sensitive to Windows users! Save me! It's a good patch, and if users want that or ask for it we'll definitely point them to it. I think a robust email notification system will be welcomed by a lot of people. It will make it more useful to an intranet. ~swain On Sat, 27 Oct 2001, Gary Benson wrote: > > On Sat, 27 Oct 2001, Steve Wainstead wrote: > > > I'm in Florida again until Tuesday, but I promise two things: versions > > 1.2.1 and 1.3.1. The development branch has some minor bugs but I think > > it's suitable for an alpha release (maybe even early beta?) We might > > attract some patches this way. Yes, Jeff's hacks will be the 1.3 release. > > Excellent! I was hoping you'd release something soon, because anyone > looking at the project page might think it was moribund. One of the things > that swayed me towards PhpWiki in the first place was that it looked like > it was under active development. > > > If you have some work you need to commit, please do so as soon as > > possible. > > Well, I just committed a quick-and-dirty email notification patch to the > patch manager, but I don't know if it will be of any use. It only emails > one person, whose address is hardwired in, but you could perhaps do > something with it. I wrote it so I didn't have to keep looking at the > RecentChanges on the GtmWiki. > > Later, > Gary > > PS. the emails it sends look like this: > > | Date: Sat, 27 Oct 2001 19:19:43 +0100 (BST) > | From: GtmWiki <gt...@in...> > | To: Gary Benson <ga...@in...> > | Subject: Re: edit: GtmHistory > | > | Modified: GtmHistory > | URL: http://inauspicious.org/gtmwiki/?GtmHistory > | Author: GaryBenson > | > | =================================================================== > | diff -u -r8 -r9 > | --- /tmp/gtmwiki-GtmHistory.8 Sat Oct 27 19:01:00 2001 > | +++ /tmp/gtmwiki-GtmHistory.9 Sat Oct 27 19:01:00 2001 > | @@ -1,5 +1,5 @@ > | This page needs to be written. In the meantime look or http://www.gtmcars.co.uk/gtm_history.htm and http://www.ijohnson.demon.co.uk/gtmoc/gtmhist.htm. > | > | -I'll probably split this up into separate pages for the GtmCoupe, the GtmRossa, the [GtmRossaK3] and the GtmLibra. > | +I'll probably split it up into separate pages for the GtmCoupe, the GtmRossa, the [GtmRossaK3] and the GtmLibra unless anyone has any better ideas. Note to self: get permission to use the stuff from GtmCars's website. > | > | -- GaryBenson > --- http://www.panix.com/~swain/ "Without music to decorate it, time is just a bunch of boring production deadlines or dates by which bills must be paid." -- Frank Zappa |
From: Steven M. <st...@mu...> - 2001-10-27 16:49:51
|
At 12:36 27/10/01 -0400, you wrote: >If you have some work you need to commit, please do so as soon as >possible. How about my attempt to fix the problems with "No Such Revision" (http://sourceforge.net/tracker/index.php?func=detail&aid=473493&group_id=6121&atid=106121), PageInfo (http://sourceforge.net/tracker/index.php?func=detail&aid=473499&group_id=6121&atid=106121) and removing pages (not on SourceForge, but can be seen in http://www.geocrawler.com/lists/3/SourceForge/4037/25/6769881/ Has anyone had a chance to look at these patches? They probably won't be the best solution but should help debugging. Thank you, Steven Murdoch. -- email: st...@mu... web: http://www.murdomedia.net/ PGP/GnuPG keys: http://www.murdomedia.net/keys.html |
From: Jeff D. <da...@da...> - 2001-10-27 19:37:51
|
> How about my attempt to fix the problems with "No Such Revision" > PageInfo > and removing pages (not on SourceForge, but can be seen in I promise to look at these on Monday. (If there are other bugs I should be looking at as well, send me a quick note to remind me of them.) It'll be good to have new releases out. "Release early and release often" should be the motto, especially for the development branch... -- Jeff Dairiki <da...@da...> |
From: Steven M. <st...@mu...> - 2001-10-28 15:50:20
|
At 12:37 27/10/01 -0700, you wrote: > > How about my attempt to fix the problems with "No Such Revision" > > PageInfo > > and removing pages (not on SourceForge, but can be seen in > >I promise to look at these on Monday. (If there are other bugs I should >be looking at as well, send me a quick note to remind me of them.) I've put the bug report and patch for removing pages up on Sourceforge. Steve Wainstead said that he would add it a while back but Sourceforge was having problems then so it might have been lost. It can now be seen at http://sourceforge.net/tracker/index.php?func=detail&aid=475757&group_id=6121&atid=106121 The only other bug I have noticed is not being able to unlock pages, which is already on Sourceforge (http://sourceforge.net/tracker/index.php?func=detail&aid=468595&group_id=6121&atid=106121). This would have been particularly annoying since when I tried importing serialized pages from a 1.2 PhpWiki they were all automatically locked. I managed to work around this by hacking the import code to set all pages to be unlocked, but this really isn't a good solution. I haven't looked properly into either problem. >It'll be good to have new releases out. "Release early and release often" >should be the motto, especially for the development branch... I agree. Thanks, Steven. -- email: st...@mu... web: http://www.murdomedia.net/ PGP/GnuPG keys: http://www.murdomedia.net/keys.html |