Re: [Phpwiki-talk] Patch for warnings

[Jeff D. <da...@da...>]

Hi Andrey

> does it possible to replace index.php:544 line
> define("CHARSET", "iso-8859-1");
> with the
> if (defined("CHARSET")) define("CHARSET", "iso-8859-1");
> ?

Okay, done.

> And would be great to have possibility to override
> COMPRESS_OUTPUT variable and $DBParams array.

COMPRESS_OUTPUT is commented out in the distributed index.php,
so if you want to define it in your custom configu file, there
should be no problem.  (Note that the default behavior can
only be obtained by leaving COMPRESS_OUTPUT undefined.)


As for DBParams, I'd rather not add that logic/clutter
to index.php right now.  (Joby Walker is working on a whole
new configuration scheme which should make the kind of customization
you're doing easier.)

> (I may post this to 'feature request' form, but my English is too poor
> :(

Your English is just fine!

Jeff