[Phpwiki-talk] WikiDB_Page::isUserPage()

[Joby W. <joby@u.washington.edu>]

In doing some long delayed work on the Group interface I was 
investigating the isUserPage() method of WikiDB_Page.  I think this was 
part of Reini's work on the User Interface (it is used in the 
AllUsers.php plugin).

This just can't be right (lib/WikiDB.php 827):

--------------------------------------------------
     function isUserPage ($include_empty = true) {
         return $this->get('pref') ? true : false;
         if ($include_empty)
             return true;
         $current = $this->getCurrentRevision();
         return ! $current->hasDefaultContents();
     }
--------------------------------------------------

The only line that will get executed is the first "return".  Are the 
others hold overs from an older version or a munged new version?  Should 
probably be:

--------------------------------------------------
     function isUserPage ($include_empty = true) {
         if ($include_empty) {
             $current = $this->getCurrentRevision();
             if ($current->hasDefaultContents()) {
                 return false;
             }
         }
         return $this->get('pref') ? true : false;
     }
--------------------------------------------------

Any objections to me commiting this?

jbw