[Phpwiki-talk] Think I found someof the getDbh problems

[Zot O'C. <zo...@wh...>]

lib/imagecache.php:

     66 function mainImageCache() {
     67     $request = new Request;
     68     //$request->setArg('pagename', deduce_pagename($request));
     69     //$pagename = $request->getArg('pagename');
     70 
     71     // assume that every user may use the cache
     72     global $user; // FIXME: necessary ?
     73 //zot
     74 print "lib/imagecache.php: mainImageCache next<br>\n";
     75     $user = new WikiUser($request, 'ANON_OK');
     76 //zot

This calls WikiUser with a Request, NOT a WikiRequest.

grep -r getDbh *| grep fun
lib/main.php:    function getDbh () {

lib/main.php:
    16  class WikiRequest extends Request {
    17      // var $_dbi;
    18  
    19      function WikiRequest () {
    20          if (USE_DB_SESSION) {
    21              $this->_dbi = $this->getDbh();
...
   126      function getDbh () {
   127          if (!isset($this->_dbi)) {
   128              // needs PHP 4.1. better use $this->_user->...
   129              $this->_dbi = WikiDB::open($GLOBALS['DBParams']);
   130          }
   131          return $this->_dbi;
   132      }

So when the WikiUser call get

lib/WikiUser.php:
    48      function WikiUser ($userid = false, $authlevel = false) {
    49          $this->_request = &$GLOBALS['request'];
    50          $this->_dbi = &$this->_request->getDbh();
    51  

It assumes it is getter a WikiRequest, but here it is getting a Request.

It looks like possibledeflowervirign may fall prey to this error
(thought it did not look like at first glance).

This *might* explain the dbm issues I was seeing.



-- 
Zot O'Connor

http://www.ZotConsulting.com
http://www.WhiteKnightHackers.com