[Phpwiki-talk] Niggling RSS & configurator errors

[Bob A. <apt...@cy...>]

Hi,

I just upgraded from 1.3.3 to 1.3.4 and I ran into a problem with an RSS
link. It's a one-line change to phpwiki/themes/default/templates/head.tmpl
so it didn't seem to warrant a real diff - here's the change:

67c67
< <link rel="alternate" type="application/rss+xml" title="RSS" href="<?=WikiURL(RECENT_CHANGES, array('format' => 'rss'))?>" />
---
> <link rel="alternate" type="application/rss+xml" title="RSS" href="<?=WikiURL(_("RecentChanges"), array('format' => 'rss'))?>" />

Also, a piece of text isn't properly passed on as a comment in
phpwiki/configurator.php; this causes silent, inexplicable failure when
using the generated index.php file. The broken comment lights up if you're
using an editor with syntax highlighting but is somewhat difficult to spot
in the black and green world of the vt100. I'm not familiar enough with
the code or with PHP to fix this right now; the problem is related to

$properties["LDAP Root Search"] =
  new _define_optional('LDAP_AUTH_SEARCH', "ou=mycompany.com,o=My Company",
  "Give the right LDAP root search information in the next statement.");

with the latter comment not being prefaced with '// '; the generated code
fragment looks like:

...
// LDAP Authentication
//
if (!defined('ALLOW_LDAP_LOGIN')) define('ALLOW_LDAP_LOGIN', 'true');
if (!defined('LDAP_AUTH_HOST')) define('LDAP_AUTH_HOST', 'localhost');
Give the right LDAP root search information in the next statement.
if (!defined('LDAP_AUTH_SEARCH')) define('LDAP_AUTH_SEARCH', 'ou=mycompany.com,o=My Company');

// IMAP Authentication
...


I checked the CVS repository and verified neither issue has yet been
addressed.

Otherwise, once I figured out which parts of index.php needed to be
commented out (or not), migration from 1.3.3 went pretty well, importing
about 500kb of wiki archives into the new system.

hth,

-- Bob