Re: [Phpwiki-talk] Bug fix for removepage.php

[Jeff D. <da...@da...>]

On Sun, 20 Oct 2002 21:46:26 +0200
"Oliver Betz" <ob...@de...> wrote:

> This works here: 
> 
>  if (isset($_GET['pagename']))     return $_GET['pagename']; 
> 
> Or $GLOBALS['HTTP_GET_VARS']['pagename'] for "old" PHP. 
> 
> but I have no clue whether this is good style. 

That's, essentially, what I did.  (Using $HTTP_GET_VARS rather
than $_GET, since I think we all decided a couple of months ago
that that's the way to go for now...)  (I sure wish those PHP
guys would stop changing basic things like that...)

> I assume that there is a reason for the nesting and against combining it
> 
> in request(). 

You mean WikiRequest vs. Request?  They could be combined with no
functional
loss --- I left them separate for both evolutinary and organizational
reason.
Request is completely non-wiki-specific.  It just deals with CGI request
things: gettings query args, setting cookies, etc...
WikiRequest deals with all the specifics of handling a request
to view/edit a PhpWiki page.  In retrospect WikiRequest should probably
_use_ Request rather than _being_ a Request.

(So anything that treats 'pagename' differently than any other
query arg should be in WikiRequest, not Request....)


> I see, the problem is really the missing argument from the "action" of a
> 
> "get" form. I checked also Opera 6.05 and Mozilla 1.1 with a simple
> form, but didn't find the argument passed to a PHP variable, so I
> wouldn't call it InternetExplorerGetMethodBug. So I use the fixes with
> hidden input fields. 

Is this still a problem in the current CVS code?  If so, can you provide
me a few details?