Re: [Phpwiki-talk] Bug fix for removepage.php

[Oliver B. <ob...@de...>]

Jeff Dairiki wrote: 

[$request->getArg looks in HTTP_POST_VARS] 

> Yes, but not quite.  $Request is a WikiRequest, and the constructor
> for WikiRequest fills in 'pagename' from some other sources if it's

I see. 

[merge HTTP_POST_VARS and HTTP_GET_VARS] 

> In general, I think that's a bad idea.  For security reasons, one should

Ack. I only thought about 'pagename'. 

[...] 

> So (shortly) I'm going to fix WikiRequest::_deducePagename() 
> (in main.php) so that it'll be able to figure out pagename from
> HTTP_GET_VARS...

This works here: 

 if (isset($_GET['pagename']))     return $_GET['pagename']; 

Or $GLOBALS['HTTP_GET_VARS']['pagename'] for "old" PHP. 

but I have no clue whether this is good style. 


I assume that there is a reason for the nesting and against combining it 
in request(). 


[Could this relate to the search functions not working...] 


> It might be related to other problems with USE_PATH_INFO=false, but I
> doubt it has to do with USE_PATH_INFO=true problems.

I see, the problem is really the missing argument from the "action" of a 
"get" form. I checked also Opera 6.05 and Mozilla 1.1 with a simple form, 
but didn't find the argument passed to a PHP variable, so I wouldn't call 
it InternetExplorerGetMethodBug. So I use the fixes with hidden input 
fields. 


Oliver 
-- 
Oliver Betz, Muenchen