Re: [Phpwiki-talk] Single word action pages?

[Reini U. <ru...@x-...>]

Jeff Dairiki schrieb:
> I just found this in WikiRequest::isActionPage:
> 
>  $singleWordActionPages = array("Historique", "Info", _('Preferences'));
> 
> I really would like to avoid hardcoding magic pagenames into the
> PhpWiki source code.  I know there are other places where page
> names are hardcoded as well (e.g. HomePage and InterwikiMap)
> 
> But, in this case, this seems completely unnecessary to me.
> Why shouldn't these pages be called PageInfo and UserPreferences
> (both of which are significantly more descriptive of their
> purpose than just Info and Preferences.)

True. I was just testing single word SubPages.
I liked the idea of [/Info] [/Help] [/Preferences] ...

But if the single word page in question has the plugin included it 
qualifies as actionpage also, so it would be okay to remove it.

> (I know no French, so can't rag specifically on Historique.  But
> I suspect that similar arguments apply...)
> 
> Also _("Today"), _("Administration"), and _("Help") appear
> as hardcoded action page names in WikiRequest::requiredAuthority().
> I'm not sure if these are even used...  But: keep in mind that
> these are names of wiki pages.  Can't they be more descriptively named?
> The requirement that they be WikiWords doesn't really seem
> overly restrictive to me in these cases.

I found this useful on my test setup. I believe it was only for 
aesthetic reasons, so that these buttons appear consistently with the 
neighbors.
-- 
Reini Urban
http://xarch.tu-graz.ac.at/home/rurban/