[Phpwiki-talk] Re: [phpwiki-checkins] CVS: phpwiki/lib/plugin RedirectTo.php,1.2,1.3

[Reini U. <ru...@x-...>]

Geoffrey T. Dairiki schrieb:
> Index: RedirectTo.php
> + * BUGS/COMMENTS:
> + *
> + * Actually, it seems that this plugin can be invoked from anywhere on a page.
> + * (Not just the first line.)

fixed in current CVS.

> + * This plugin could probably result in a lot of confusion, especially when
> + * redirecting to external sites.  (Perhaps it can even be used for dastardly
> + * purposes?)  Maybe it should be disabled by default.
> + *
> + * It would be nice, when redirecting to another wiki page, to (as
> + * UseModWiki does) add a note to the top of the target page saying
> + * something like "(Redirected from SomeRedirectingPage)".

See this patch attached.
Maybe we shouldn't check for another get argument at WikiRequest. 
redirectfrom=FromPage. But okay for me.

The question is if we should add the note "Redirected from Pagename" at 
the top or bottom. Currently at the bottom. Looks better to me, but for 
consistency it would also be okay at the top.
-- 
Reini Urban
http://xarch.tu-graz.ac.at/home/rurban/