From: Joby W. <joby@u.washington.edu> - 2002-09-13 23:25:18
|
Martin Geisler wrote: > Aha, like a linked list? But the comments also say that you cannot > modify a revision, you can only create or delete them, so perhaps this > is a bigger issue? > Kinda. I'm not a huge fan of the current structure, but as far as I can see by looking at the database (version table). Each record stores the mtime of the version number that replaces it. Thus the following would have to happen: I'll use R0 for the revision to be deleted. R1 for a revision that might follow R0. And R-1 for the revision that is prior to R0. If the purged revision is the newest: 1) delete R0 2) revert R-1 to be the final version If there is a R1: 1) grab from R0 the mtime of R1 2) change the mtime stored in R-1 (which would be R0) to value in 1) 3) delete R0. There might be other consiquenses. I haven't looked too much into this. The developers that have been around longer would know. > But I imagined that it should work just like the 'Remove Page' button > that only appears when you're signed in as the administrator. So > normal users shouldn't have access to it. > That's not really the issue. I don't want _ANYONE_ to be able to delete versions. Although I have an intesive backup scheme, I don't want to lose any data -- even if undesireable. Of course I am implimenting some severe editing restrictions so undesireable content is unlikely to occur. I would prefer if this functionality would have to be enabled via a defined constant in index.php. jbw |