Re: [Phpwiki-talk] [Fwd: [PhpWiki] Call Time Pass By Reference]

[Lawrence A. <ao...@ds...>]

Thanks for the report.

By a strange coincidence, this has also been reported as a bug on=
 SF. 
A couple of function calls were incorrectly coded.  I have fixed=
 it 
in cvs, and there should be no need to change the .htaccess=
 files.

If you want to change it in your own version, here are the=
 changes I 
made:


1)
in lib/editpage.php:  lines 131 and 156 (or thereabouts): change=
 
this->setPageLockChanged($isadmin, $lock, &$page);  

to 

this->setPageLockChanged($isadmin, $lock, $page);

[Note the removal of the &]

2)
in lib/diff.php: line 339:  change

  $html->pushContent(HTML::Table(PageInfoRow(_("Newer page:"),=
 $new, 
&$request),  PageInfoRow(_("Older page:"), $old, &$request))); 

to

  $html->pushContent(HTML::Table(PageInfoRow(_("Newer page:"),=
 $new, 
&$request),  PageInfoRow(_("Older page:"), $old, $request))); 

[again, only change is removal of &]

I hope this works.

It would be great if someone could test it and let me know if the=
 
warnings have gone.

Lawrence


On 21 Mar 2002 10:38:45 -0800, Adam Shand wrote:
>Hey Dennis,
>
>My contributions to PhpWiki are mostly answering what questions=
 I
>can on
>the mailing list and keeping the cruft off the wiki site (it's
>amazing
>how much crap people want to create sometimes :-).
>
>As such I've forwarded your message back to the list.
>
>Adam.
>
>-----Forwarded Message-----
>
>From: Dennis Kehrig <Th...@we...>
>To: ad...@pe...
>Subject: [PhpWiki] Call Time Pass By Reference
>Date: 21 Mar 2002 16:37:07 +0100
>
>Hi Adam,
>
>since I did not find too many email addresses on the PhpWiki=
 page, I
>chose you as my victim.
>
>PhpWiki seems to make usage of the feature mentioned in the=
 subject,
>but
>it is disabled in recent PHP versions by default.
>
>You (or whoever feels responsible for this) might consider=
 adding
>this
>line to the .htaccess file:
>
>    php_flag allow_call_time_pass_reference on
>
>I guess this will be sufficient for the majority of PhpWiki=
 users
>(those
>with Apache and the more or less default PHP settings).
>
>Regards,
>
>Dennis
>


--