Re: [Phpwiki-talk] phpWiki patch - concurrent updates

[Marcel v. d. B. <ma...@hs...>]

>
>
>Marcel's patch (which is reversed?)
>
Yep, it's reverse I'm sorry, too quick...

>turns
>saving a concurrent update from an error (save fails) into a warning
>(save succeeds).
>
>If that's right, it's a bad idea IMHO.  It makes it just too easy for some
>bozo to blow away somebody else's edits.
>
>If someone tries to run PhpWiki in an environment where it routinely
>sees multiple edits per minute per page, this issue is going to be
>among the least of their problems, I think.
>
- It makes it easy to create a newer revision, but no data is lost. (it 
needs extra work though when a bozo has done the editting ) The patch 
should obviously be more elegant (besides being reversed) than it is 
now. But (at least in the PN module version) the instructions of the 
error message are wrong. When hitting the back button, the page is 
retrieved from the db again, so the last changes are lost. (maybe that 
is the error).
- our Wiki isn't busy at all. The number of edits per minute is not 
really relevant, but the time elapsed between start of edit and save. We 
are creating documents in a team and especially when creating new 
documents it happens frequently that users are working on the same 
documents ( a development task list for example is quite a busy document)
Sometimes I'm testing some software and keep the edit window of a Wiki 
page open for  a longer period of time to document the results as I go 
along.  I applied the patch to our installation after loosing edits 
several times. The Wiki doesn't have to be busy at all for this. All it 
takes is one edit during the time I'm editting.
- the bozo factor is a risk in a Wiki, especially if you have a loose 
permission scheme.  We have a PostNuke permission scheme in place to 
minimize this risk.

Marcel