Re: [Phpwiki-talk] Re: [phpwiki-checkins] CVS: phpwiki phpwiki-heavy.css,1.7,1.8 phpwiki.css,1.25,1.26

[Carsten K. <car...@ma...>]

Didn't remember I'd done that until I read my comments in the log:

establishes (diff) as a wikiaction link, for hiding it in phpwiki-printer.
css

Besides hiding the diffs from printed output, there's no reason (for 
themes or whatnot) that it need be a wikiaction. The RecentChanges days 
buttons don't hide from the printer.css properly either.

So I'm thinking of this... I'm not happy with this class name 'no-printer'
  but can't think of anything better.

     function diffLink ($rev) {
         global $Theme;
!       return $Theme->makeButton(_("(diff)"), $this->diffURL($rev), 
'no-printer');
     }




                 $b->addButton($label, "RecentChanges?days=" .$daynum
                                       .$url_show_minor .$url_show_all,
                               'wikiaction');
             }
!           return HTML::div(array('class'=>'no-printer'), $b->getContent(
));
         }


On Friday, January 25, 2002, at 11:12  pm, Jeff Dairiki wrote:

> Carsten Klapp said:
>> I think I prefer the plain-text ones as well.
>>
>> Somewhere along the way to the new ButtonFactory the RecentChanges
>> '(diff) 's were converted into buttons...
>
> It was before that, I think.
>
> It used to be that the (diff) links were just plain links --- not
> tagged with any CSS class.  It was you who added the wikiaction class to 
> the
> diff links (v 1.16 of lib/plugin/RecentChanges.php):
> http://cvs.sf.net/cgi-
> bin/viewcvs.cgi/phpwiki/phpwiki/lib/plugin/RecentChanges.php.diff?r1=1.15&
> r2=1.16
> I think it's best we leave the .wikiaction and .wikiadmin classes
> signifying the links one might like buttonized (the links in the toolbars,
> and some of thes ones in PhpWikiAdministration.)
>
> I say just remove the wikiaction class designation from the "(diff)" 
> links.
> (Or I guess, if it's needed for some themes, make them be of yet another
> (new) class.)
>
> In other words, don't de-button them by changing the CSS, de-button them
> by changing the HTML.
>
>
>