Re: [Phpwiki-talk] FileFinder.php default path logic

[Marc-Etienne V. (Nokia) <mar...@no...>]

Hi Christof,

Thank you for the report.

I have fixed the test, now testing against “array()” instead of “false”.

Best regards,

Marc-Etienne

--
Marc-Etienne Vargenau mar...@no...<mailto:mar...@no...>
Nokia, 12, rue Jean-Bart, 91300 Massy, FRANCE
Mobile: +33 6 24 49 78 68<tel:+33624497868>
Senior Specialist Open Source
Planned absence: none


De : Christof Meerwald via Phpwiki-talk <php...@li...>
Date : dimanche, 21 janvier 2024 à 19:57
À : php...@li... <php...@li...>
Cc : Christof Meerwald <cm...@cm...>
Objet : [Phpwiki-talk] FileFinder.php default path logic

CAUTION: This is an external email. Please be very careful when clicking links or opening attachments. See the URL nok.it/ext for additional information.



I don't think it makes sense to check if the member has already been
set in the constructor. And having the default argument "array()", but
then comparing against "false" means we never get into the then
branch. Patch is attached (so we only use the _get_include_path if
FileFinder has been called with no argument specified, which I think
is the intention here).


Christof

--

https://cmeerw.org                             sip:cmeerw at cmeerw.org
mailto:cmeerw at cmeerw.org                   xmpp:cmeerw at cmeerw.org