From: Geoffrey T. D. <da...@us...> - 2001-12-15 02:36:59
|
Update of /cvsroot/phpwiki/phpwiki/lib/plugin In directory usw-pr-cvs1:/tmp/cvs-serv5381/lib/plugin Modified Files: PageHistory.php Log Message: Use GET instead of POST for diff form action. (There are no side effects of viewing a diff, so POST is not really appropriate.) Index: PageHistory.php =================================================================== RCS file: /cvsroot/phpwiki/phpwiki/lib/plugin/PageHistory.php,v retrieving revision 1.1 retrieving revision 1.2 diff -C2 -r1.1 -r1.2 *** PageHistory.php 2001/12/14 20:28:02 1.1 --- PageHistory.php 2001/12/15 02:36:56 1.2 *************** *** 104,113 **** 'name' => 'action', 'value' => 'diff')); ! $html[] = Element('input', array('type' => 'hidden', ! 'name' => 'pagename', ! 'value' => $pagename)); ! $action = USE_PATH_INFO ? WikiURL($pagename) : SCRIPT_NAME; ! return Element('form', array('method' => 'post', 'action' => $action, 'name' => 'diff-select'), --- 104,118 ---- 'name' => 'action', 'value' => 'diff')); ! if (USE_PATH_INFO) { ! $action = WikiURL($pagename); ! } ! else { ! $action = SCRIPT_NAME; ! $html[] = Element('input', array('type' => 'hidden', ! 'name' => 'pagename', ! 'value' => $pagename)); ! } ! return Element('form', array('method' => 'get', 'action' => $action, 'name' => 'diff-select'), |