From: Jeff D. <da...@da...> - 2001-02-14 22:50:48
|
In message <3A8...@x-...>,Reini Urban writes: >What about removing %%Search%% and %%Fullsearch%% sooner or later? >The new MacigPhpWikiURLs are functionally equivalent and even better. > > [ Title Search | phpwiki:?action=search&searchterm=() ] > [ Full Search | phpwiki:?action=search&searchtype=full&searchterm=() ] Yes, I think that's a good plan eventually. Note that while I like the idea of the magic phpwiki:, I don't really like the grammar I implemented, and would appreciate suggestions for improvements. Pros: Very flexible. Can embed all sort of links/forms for administrative actions without having a special token (like %%Search%%) for everything one might want to do. Cons: The syntax is a bit confusing. (Not a huge con, since the average user, or even average admin never has to write any of these links.) Not flexible enough. As an example: on the UserPreferences page, it would be nice to have a form with two input fields (edit area height and width). It would also be nice to set the default values for these inputs to the users current settings. Can't do that with the current syntax. (Now there's two seperate forms --- one for height, one for width --- and no (or constant) default values.) Tokens like %%EDIT_WIDTH%% would solve this (the default value) problem, but then, we wanted to get away from tokens. Or did we? Another example: how to exand/modify the syntax to allow for image buttons, etc... as Reini has requested? Another consideration is that it would be nice to be able to (easily) generate these sorts of links in the template files. For example, one might like to put a search form somewhere in the browse template --- it would be convenient not to have to enter the entire form by hand. Also, it would eliminate a lot of the template tokens we have now. E.g. it would be nice to be able to say someting like %%%[Edit this page|phpwiki:?action=edit]%%% rather than <a class="wikiaction" href="###ACTION###edit">Edit this page</a> Or See %%%[phpwiki:UserPreferences]%%% . rather than See <a class="wikilink" href="###BROWSE###UserPreferences"><span class="wikiword">UserPreferences</span></a>. Perhaps we could introduce a way to delimit text in the templates which should be run through transform.php? e.g: {{{See UserPreferences.}}} (The option to use PATH_INFO or not has made the task of generating URLs in the templates much more complicated than it used to be. This is compounded by all the class= args added for CSS support.) While we're on the subject of templates, I think it would be nice to implement some sort of "loop" construct in the templates. In the not too distant future (once we move to multiple saved versions) were going to have to generate more tables (and more complicated tables) than we are now. I think that it would be nice to get the table layout into the template files, rather than being hard-coded into the php code. Jeff |