[Phpwiki-talk] Re: phpwiki 1.1.8

[Arno H. <aho...@in...>]

> Strange your email hasn't come through...

Neither did yours - but the phpwiki-talk archive on Geocrawler has all 
messages. My first email surfaced with a 24hours delay. Anyone else seeing 
these delays with the list?

> > E.g. I got a strange bug, where if you edit a file and write
> > word1
> > word2
> > it would be rendered as "word1word2" (no space!!)

> No, I haven't encountered this yet.

Could you verify that? Also, could you verify that my fix in wiki_transform
doesn't break things at your end? (try pre-formatted text and see if
erroneous empty lines are displayed)

> > The current form of OpenDataBase is silly. It should be split into a
> > "ConnectDataBase" and "SelectDataBase".
> hmm. Perhaps I don't understand. Open the database, and interact with the
> database. 

As it is now, OpenDataBase connects to e.g. mySQL every time it is called. 
OpenDataBase might be called several times when editing or saving - and 
everytime it connects to mySQL again. Similar when using dbmlib all dbm files 
get opened several times. What we really want is to connect/open once,
and then just select which database we are using: wiki or archive.

> But there is a third argument now to specify the table (page or
> archive). I realized there is an inconsistency that there is one
> RetrievePage and two functions for inserting pages (InsertPage and
> SaveCopyToArchive) and that it's a mess and needs cleaning up... 

The inconsistence I'm complaining about is: some functions rely on the 
pagestore opened by OpenDataBase($pagestore) (e.g. the search functions), 
some are using a 3rd argument (e.g. RetrievePage), and some are splitted into 
two separate functions alltogether (InsertPage, SaveCopyToArchive).
This is bad and will lead to obscure errors.

A possible solution: get rid of multiple functions and 3rd arguments, and 
split OpenDateBase in two functions: a real OpenDB that connects to resp. 
opens the DB, and a SelectPageStore(). Or use 3 arguments throughout.

Going to correct another bug now: search results display lines without 
safeguarding against HTML - try a fulltext search on wiki and look for the 
results of TestPage and you see what I mean.

Oh, and of course the entire documentation could need an overhaul.
Any volunteers? ;o)

/Arno