[Phpwiki-talk] follow-up on pre-1.1.8

[Arno H. <aho...@in...>]

Hi again,

I've slightly modified wiki_mysql.php3 so that it runs with OpenDataBase as 
intended.

Are we using "lib/*" yet? index.php3 still uses wiki_*.php3, so I fixed those 
files.

It looks like the current CVS MAIN branch isn't in good shape.

E.g. I got a strange bug, where if you edit a file and write

word1
word2

it would be rendered as "word1word2" (no space!!)

The cause: Jeff's change in version 1.1.3 of wiki_savepage
He modified
	$pagehash["content"] = explode("\n", $content);
to
	$pagehash["content"] = preg_split('/[ \t\r]*\n/', chop($content));
in order to get rid of all unnecessary spaces.

Actually this removed the trailing '\r' our lines used to have in the
pagehash[content] array - that's why some parts may behave strange.

This (IMHO serious) bug was introduced 2000/07/20 (I don't blame Jeff, these 
things just happen). But it got unnoticed until now - or can't you reproduce 
the bug?

Next, "admin/" is broken - it doesn't use the latest DB interface.

The current form of OpenDataBase is silly. It should be split into a
"ConnectDataBase" and "SelectDataBase". Also, I find the change of 3 
arguments for RetrievePage() questionable. Either use OpenDataBase 
throughout, or use 3 argument fucntions throughout, but don't mix the two 
cases. This is a Bad Thing to do.


So what I'm saying is: before Steve releases 1.1.8 we should get our act 
together and do some cleanup and testing.

/Arno