Re: [Phpwiki-talk] 1.1.6 up

[Arno H. <aho...@in...>]

Steve,

just checking out 1.1.6.

Two things:

- why is test2.php3 in 1.1.6?

- phpwiki no longer runs out of the box, due to a config error.
  offending lines:

  $ServerAddress = "http://127.0.0.1:8080/phpwiki/";
  and
  /*
   if (preg_match("#(.*?)([^/]*$)#", $REQUEST_URI, $matches)) {
      $ServerAddress = "http://$SERVER_NAME:$SERVER_PORT" . $matches[1];
   } else {
      $ServerAddress = "http://$SERVER_NAME:$SERVER_PORT$REQUEST_URI";
   }
  */

  the first should be commented out, the second should be default.
  (no not everyone has a webserver running localhost:8080 ;o)

  Also, the comment doesn't make sense:
  // You should set the $ServerAddress as below, and comment out
  // the if/else below.
  "and" should be "or"

 > A simple patch would be to do a s/// for
 > <, > and &.

 Or htmlspecialchars() the whole thing

 > I know some time ago, very early in the development of 1.1, I rewrote
 > UpdateRecentChanges so it listed the pages newest-first instead of putting
 > the newest at the bottom. I wonder what happened to this change? I don't
 > know if I have a copy of it still.

I never touched it - apart from fixing some bugs.
I'll try to find out what's wrong.

 > I think the next thing to work on is the HitCount. It should be
 > straightforward to add to PhpWiki. Do we want to include it at the bottom
 > of each page? Also, "version" provides a way to count how many times a
 > page was edited. Do we want to add this info to the bottom of the page
 > too, or leave it in [more info] ?

We can use placeholders, so wiki-admins can decide themselves.
There's already a ###VERSION### placeholder if memory serves right.

/Arno