Re: [Phpwiki-talk] some bugs

[Steve W. <sw...@wc...>]

Hi Arno!

Did you forget to cvs add the templating stuff? I can't check it out, and
I get:


[snip]
Warning: File("templates/browse.html") - No such file or directory in
wiki_stdlib.php3 on line 28

Warning: Bad arguments to join() in wiki_stdlib.php3 on line 28
[snip]


when I try to run my copy of PhpWiki. 

> full text search & dbm: try searching for "eat".
> All pages get listed. Reason: fieldname "cr_eat_ed"
> dbm search should limit its search to the actual content.

OK, not a show stopper but it needs fixing.

> edit copy: the logic when to show the EditCopy link is flawed.
> I think the link should always be shown.
> Example: I edit page PAGE, screw up, but save anyway
> Upon seeing the new PAGE I realize my error
> I would like to undo my error by using EditCopy
> ->currently not possible

Good point. Let's start a TODO list in the project to add these things,
and keep it in CVS as well.

> I.e. only because I'm the last one who has edited PAGE I'm not allowed 
> to access the archived version? Why?
> (note: the way pages get stored in the archive prevents any abuse)

Right... while it's important that the current editor of the page be
prevented from erasing the previous copy there's no reason why we can't
give her read-only access to retrieve it. 

 
> And my LostUpdate fix doesn't handle EditCopy cases correctly.
> It assumes that only one version has been created since the archived
> version. Which is of course an invalid assumption, as a single author
> might create multiple revisions (e.g. editing -> finding mistake ->
> editing again).
> 
> I was too lazy to fix this now.
> 
> See "FIXME" notes in wiki_savepage.php3

I have the current version from CVS but I don't find 'fixme' anywhere
(maybe you need to check in changes?). Then again I've been teaching
myself Emacs and maybe I don't use ^s properly. ;-)

I like the function you added to the pageviewer, but we should agree on a
place to put functions in pages instead of the middle (CVS merged its copy
with mine; I was playing with it last night trying to get the Postgres
version of InsertPage to work). Anyway, my preference is for function
definitions to go at the bottom of the source file (like having your
"main" at the top). I'll entertain arguments to the contrary... doesn't
PHP demand the function be defined before it's used?

sw


...............................ooo0000ooo.................................
   Hear FM quality freeform radio through the Internet: http://wcsb.org/
                     home page: www.wcsb.org/~swain