[Phpwiki-talk] LostUpdateProblem fixed & some other stuff

[Arno H. <aho...@in...>]

Hi there,

I added a patch for the LostUpdateProblem just now.
It ignores EditLinks though.

Also, RecentChanges now indicates newly created pages with '(new)'.

On a side note:
Could we move some stuff out of wiki_stdlib.php3?
I would suggest to move the following:
	- UpdateRecentChanges() to wiki_savepage
	- SetHTMLOutputMode(), $stack, and ParseAndLink() to
	  wiki_display

Reason: functions are only used in those files and somehow belong
there. Also, wiki_stdlib is included for every hit and these changes
would make it smaller & less expensive.

Also, I would suggest that we redefine the directives for
the search boxes from [Search] and [Fullsearch] to something like
%%Search%% and %%Fullsearch%% - seems cleaner this way and frees
up those names as page names. Also, we can add new directives later on 
without having to worry about side effects.

On a related note: I don't like using ''' for bold. It may be the
"standard" way, but it's odd. For one thing you can't do things like:
''emphasis this '''bold text''' correctly'' easily. Plus you have to
type 6 chars. Actually, in textual conversation three ways to
emphasize text have gained popularity:
emphasis like *this* and like _this_ and like THIS.
Writing in caps is out of question, *this* may become a nightmare
because of using '*' for lists, but _this_ seems sensible. In order to 
be able to use '_' within text we just use '__' as markup.
The above problematic sentence thus would read:
''emphasis this __bold text__ correctly''
Looks natural to me and solves many regexp problems.
Comments?

Should I include a patch that limits chars within "[]"?
(option through wiki_config)


Footnote on the mySQL schema: while writing the patch for LostUpdate
I came accross those references again. Do we really perform such
sophisticated actions on those refs that the overhead of using a
separate table is justified? Thinking about it again I would suggest:
dropping the wiki_refs table and instead add a column refs to the wiki
table. Yes, it's not 100% normalized but I think it serves our purposes
well (and better than a separate table). This column would be included
in the archive table as well.


/Arno

P.S: Nicholas, I'm from Graz, Austria.