[phpwiki-checkins] SF.net SVN: phpwiki:[10272] trunk

[<var...@us...>]

Revision: 10272
          http://sourceforge.net/p/phpwiki/code/10272
Author:   vargenau
Date:     2021-02-23 17:56:45 +0000 (Tue, 23 Feb 2021)
Log Message:
-----------
plugin UserRatings: better test boolean arguments "noheader", "userPage" and "nobuds"

Modified Paths:
--------------
    trunk/lib/plugin/UserRatings.php
    trunk/pgsrc/Help%2FUserRatingsPlugin

Modified: trunk/lib/plugin/UserRatings.php
===================================================================
--- trunk/lib/plugin/UserRatings.php	2021-02-23 13:53:17 UTC (rev 10271)
+++ trunk/lib/plugin/UserRatings.php	2021-02-23 17:56:45 UTC (rev 10272)
@@ -58,7 +58,7 @@
             'pagename' => '[pagename]', // hackish
             'exclude' => '',
             'limit' => 0, // limit of <=0 is show-all
-            'noheader' => 0,
+            'noheader' => false,
             'userPage' => false,
             'nobuds' => false,
             // rating columns are added later
@@ -82,6 +82,30 @@
     {
         extract($this->getArgs($argstr, $request));
 
+        if (($noheader == '0') || ($noheader == 'false')) {
+            $noheader = false;
+        } elseif (($noheader == '1') || ($noheader == 'true')) {
+            $noheader = true;
+        } else {
+            return $this->error(sprintf(_("Argument '%s' must be a boolean"), "noheader"));
+        }
+
+        if (($userPage == '0') || ($userPage == 'false')) {
+            $userPage = false;
+        } elseif (($userPage == '1') || ($userPage == 'true')) {
+            $userPage = true;
+        } else {
+            return $this->error(sprintf(_("Argument '%s' must be a boolean"), "userPage"));
+        }
+
+        if (($nobuds == '0') || ($nobuds == 'false')) {
+            $nobuds = false;
+        } elseif (($nobuds == '1') || ($nobuds == 'true')) {
+            $nobuds = true;
+        } else {
+            return $this->error(sprintf(_("Argument '%s' must be a boolean"), "nobuds"));
+        }
+
         // XXX: fix to reflect multi-user ratings?
         $caption = _("Displaying %d ratings:");
 

Modified: trunk/pgsrc/Help%2FUserRatingsPlugin
===================================================================
--- trunk/pgsrc/Help%2FUserRatingsPlugin	2021-02-23 13:53:17 UTC (rev 10271)
+++ trunk/pgsrc/Help%2FUserRatingsPlugin	2021-02-23 17:56:45 UTC (rev 10272)
@@ -1,4 +1,4 @@
-Date: Mon, 22 Feb 2021 19:16:32 +0000
+Date: Tue, 23 Feb 2021 18:51:32 +0000
 Mime-Version: 1.0 (Produced by PhpWiki 1.6.0)
 Content-Type: application/x-phpwiki;
   pagename=Help%2FUserRatingsPlugin;
@@ -44,7 +44,7 @@
 |-
 | **exclude**
 | Pages to exclude (allows multiple pagenames exclude=HomePage,RecentChanges)
-|
+| none
 |-
 | **limit**
 | limit of <=0 is show-all
@@ -55,9 +55,13 @@
 | false
 |-
 | **userPage**
-|
+| Boolean. If true, we're on a user's homepage, get **their** ratings
 | false
 |-
+| **nobuds**
+| Boolean.
+| false
+|-
 | **info**
 | columns to display (hits, pagename, author, ratingwidget...)
 | pagename

This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.